From patchwork Thu Nov 10 12:29:32 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jan Beulich X-Patchwork-Id: 9421013 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 96B0860484 for ; Thu, 10 Nov 2016 12:32:15 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 7D090292D4 for ; Thu, 10 Nov 2016 12:32:15 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 712F8292EC; Thu, 10 Nov 2016 12:32:15 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=2.0 tests=BAYES_00, RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id ED9A5292D4 for ; Thu, 10 Nov 2016 12:32:14 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1c4oUG-00088p-7w; Thu, 10 Nov 2016 12:29:48 +0000 Received: from mail6.bemta6.messagelabs.com ([193.109.254.103]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1c4oUE-00088h-FX for xen-devel@lists.xenproject.org; Thu, 10 Nov 2016 12:29:46 +0000 Received: from [85.158.143.35] by server-1.bemta-6.messagelabs.com id 3B/B6-24503-93864285; Thu, 10 Nov 2016 12:29:45 +0000 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrPIsWRWlGSWpSXmKPExsXS6fjDS9ciQyX C4PFvG4vvWyYzOTB6HP5whSWAMYo1My8pvyKBNePN6eesBev4Kk60XGRuYFzP3cXIySEkkCfx 4sol5i5GDg5eATuJz92eIGEJAUOJp++vs4HYLAKqEl9udDCD2GwC6hJtz7azgpSLCBhInDuaB BJmFgiUuHV/BiOILSzgLLF49XoWiImCEn93CEOU2En8e3efZQIj1yyEzCwkGQhbS+Lhr1tQtr bEsoWvmUHKmQWkJZb/44AI20jc+3aACVUJiO0ucXf+SuYFjByrGNWLU4vKUot0zfSSijLTM0p yEzNzdA0NzPRyU4uLE9NTcxKTivWS83M3MQIDjwEIdjDOO+F/iFGSg0lJlHdHgEqEEF9Sfkpl RmJxRnxRaU5q8SFGDQ4OgW27Vl9glGLJy89LVZLglU4HqhMsSk1PrUjLzAHGBkypBAePkghvE 0iat7ggMbc4Mx0idYpRUUqcVxUkIQCSyCjNg2uDxeMlRlkpYV5GoKOEeApSi3IzS1DlXzGKcz AqCfMKgEzhycwrgZv+CmgxE9DiGXFgi0sSEVJSDYw6mtL/4mweP5b0+Xt/bX/MEpdFsvM8NR6 WeEdG/ePOZ+r0VZ3/sr7wr9Np6/QvUwo8j4f/Mf+//KLZ+TW3dpX/yX65LVJ7P8Pe3Z4mtz8d c/+u93vlEc3arGz9l58+zWAXnfy82sTu9WVn17h6FpfjZg8zuXtzhJdsOrVzVd19MQWuD3vXm z1QYinOSDTUYi4qTgQA5pgHgsICAAA= X-Env-Sender: JBeulich@suse.com X-Msg-Ref: server-14.tower-21.messagelabs.com!1478780982!37277239!1 X-Originating-IP: [137.65.248.74] X-SpamReason: No, hits=0.0 required=7.0 tests= X-StarScan-Received: X-StarScan-Version: 9.0.16; banners=-,-,- X-VirusChecked: Checked Received: (qmail 56163 invoked from network); 10 Nov 2016 12:29:44 -0000 Received: from prv-mh.provo.novell.com (HELO prv-mh.provo.novell.com) (137.65.248.74) by server-14.tower-21.messagelabs.com with DHE-RSA-AES256-GCM-SHA384 encrypted SMTP; 10 Nov 2016 12:29:44 -0000 Received: from INET-PRV-MTA by prv-mh.provo.novell.com with Novell_GroupWise; Thu, 10 Nov 2016 05:29:33 -0700 Message-Id: <5824763C020000780011DA56@prv-mh.provo.novell.com> X-Mailer: Novell GroupWise Internet Agent 14.2.1 Date: Thu, 10 Nov 2016 05:29:32 -0700 From: "Jan Beulich" To: "xen-devel" Mime-Version: 1.0 Cc: Andrew Cooper , Wei Liu Subject: [Xen-devel] [PATCH] x86emul: suppress alignment check for {, v}mov{d, q} X-BeenThere: xen-devel@lists.xen.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" X-Virus-Scanned: ClamAV using ClamSMTP When introducing support for these instructions, adjustment for the alignment check logic (generating #GP(0)) was overlooked. Signed-off-by: Jan Beulich x86emul: suppress alignment check for {,v}mov{d,q} When introducing support for these instructions, adjustment for the alignment check logic (generating #GP(0)) was overlooked. Signed-off-by: Jan Beulich --- a/xen/arch/x86/x86_emulate/x86_emulate.c +++ b/xen/arch/x86/x86_emulate/x86_emulate.c @@ -4940,7 +4940,7 @@ x86_emulate( { uint32_t mxcsr = 0; - if ( vex.pfx != vex_66 ) + if ( ea.bytes < 16 || vex.pfx == vex_f3 ) mxcsr = MXCSR_MM; else if ( vcpu_has_misalignsse() ) asm ( "stmxcsr %0" : "=m" (mxcsr) ); Reviewed-by: Andrew Cooper --- a/xen/arch/x86/x86_emulate/x86_emulate.c +++ b/xen/arch/x86/x86_emulate/x86_emulate.c @@ -4940,7 +4940,7 @@ x86_emulate( { uint32_t mxcsr = 0; - if ( vex.pfx != vex_66 ) + if ( ea.bytes < 16 || vex.pfx == vex_f3 ) mxcsr = MXCSR_MM; else if ( vcpu_has_misalignsse() ) asm ( "stmxcsr %0" : "=m" (mxcsr) );