From patchwork Thu Dec 8 11:53:56 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jan Beulich X-Patchwork-Id: 9466211 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 8E6CE6071E for ; Thu, 8 Dec 2016 11:56:02 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 7579928577 for ; Thu, 8 Dec 2016 11:56:02 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 69F9E2857B; Thu, 8 Dec 2016 11:56:02 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=2.0 tests=BAYES_00, RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 03B3028577 for ; Thu, 8 Dec 2016 11:56:01 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cExH0-0004vV-Ct; Thu, 08 Dec 2016 11:54:02 +0000 Received: from mail6.bemta6.messagelabs.com ([193.109.254.103]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cExGz-0004vI-Sc for xen-devel@lists.xenproject.org; Thu, 08 Dec 2016 11:54:01 +0000 Received: from [193.109.254.147] by server-7.bemta-6.messagelabs.com id 7E/E4-29519-9D949485; Thu, 08 Dec 2016 11:54:01 +0000 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrPIsWRWlGSWpSXmKPExsXS6fjDS/eap2e Ewe2TAhbft0xmcmD0OPzhCksAYxRrZl5SfkUCa8bbOf/YCzpEKiZ2fWZpYDwj0MXIySEkkCfR 9mcTI4jNK2Ancf7HAzYQW0LAUOLp++tgNouAqsSq1YdYQWw2AXWJtmfbgWwODhEBA4lzR5NAT GYBfYlt61hAKoQFzCVmn/wAVsErICjxd4cwSJgZaPiXTV8ZJzByzULIzEKSgbC1JB7+usUCYW tLLFv4mnkW2HxpieX/OCDCLhIdK2exYSrxl1hy0HUBI8cqRo3i1KKy1CJdIwO9pKLM9IyS3MT MHF1DAzO93NTi4sT01JzEpGK95PzcTYzAwGMAgh2Mv5YFHGKU5GBSEuXdNcE9QogvKT+lMiOx OCO+qDQntfgQowwHh5IE71IPzwghwaLU9NSKtMwcYAzApCU4eJREeFndgdK8xQWJucWZ6RCpU 4y6HNOeLX7KJMSSl5+XKiXOWwkyQwCkKKM0D24ELB4vMcpKCfMyAh0lxFOQWpSbWYIq/4pRnI NRSRjiEp7MvBK4Ta+AjmACOmLeDXeQI0oSEVJSDYwpR/+VTE7yFYzmOjFhRvD8zZMmZhROWPp ULvSzn8afTe0antJqIS3PVr/kDPr6Ta9r5+rInBv1R+2Lf1bM6p7990fzlFuXK5oz7A/1XCvz v3G88IhE5/bH9jv21L22vn+H6WLGcaXHUa2871d4G298KnPGrVl754LKfpakC2ePiHz1V1u25 uxOJZbijERDLeai4kQAWU9QCsICAAA= X-Env-Sender: JBeulich@suse.com X-Msg-Ref: server-11.tower-27.messagelabs.com!1481198036!45872746!1 X-Originating-IP: [137.65.248.74] X-SpamReason: No, hits=0.0 required=7.0 tests= X-StarScan-Received: X-StarScan-Version: 9.0.16; banners=-,-,- X-VirusChecked: Checked Received: (qmail 25460 invoked from network); 8 Dec 2016 11:53:57 -0000 Received: from prv-mh.provo.novell.com (HELO prv-mh.provo.novell.com) (137.65.248.74) by server-11.tower-27.messagelabs.com with DHE-RSA-AES256-GCM-SHA384 encrypted SMTP; 8 Dec 2016 11:53:57 -0000 Received: from INET-PRV-MTA by prv-mh.provo.novell.com with Novell_GroupWise; Thu, 08 Dec 2016 04:53:55 -0700 Message-Id: <584957E40200007800126B4F@prv-mh.provo.novell.com> X-Mailer: Novell GroupWise Internet Agent 14.2.1 Date: Thu, 08 Dec 2016 04:53:56 -0700 From: "Jan Beulich" To: "xen-devel" Mime-Version: 1.0 Cc: Andrew Cooper Subject: [Xen-devel] [PATCH] x86emul/test: avoid meaningless output X-BeenThere: xen-devel@lists.xen.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" X-Virus-Scanned: ClamAV using ClamSMTP Unconditionally reporting a skipped test in 64-bit builds is not very useful, especially when quite a few more tests are about to be added. Signed-off-by: Jan Beulich x86emul/test: avoid meaningless output Unconditionally reporting a skipped test in 64-bit builds is not very useful, especially when quite a few more tests are about to be added. Signed-off-by: Jan Beulich --- a/tools/tests/x86_emulator/test_x86_emulator.c +++ b/tools/tests/x86_emulator/test_x86_emulator.c @@ -613,8 +613,8 @@ int main(int argc, char **argv) goto fail; printf("okay\n"); - printf("%-40s", "Testing daa/das (all inputs)..."); #ifndef __x86_64__ + printf("%-40s", "Testing daa/das (all inputs)..."); /* Bits 0-7: AL; Bit 8: EFLG_AF; Bit 9: EFLG_CF; Bit 10: DAA vs. DAS. */ for ( i = 0; i < 0x800; i++ ) { @@ -679,9 +679,7 @@ int main(int argc, char **argv) } } printf("okay\n"); -#else - printf("skipped\n"); - +#else /* x86-64 */ printf("%-40s", "Testing cmovz %ecx,%eax..."); instr[0] = 0x0f; instr[1] = 0x44; instr[2] = 0xc1; regs.eflags = 0x200; Reviewed-by: Andrew Cooper --- a/tools/tests/x86_emulator/test_x86_emulator.c +++ b/tools/tests/x86_emulator/test_x86_emulator.c @@ -613,8 +613,8 @@ int main(int argc, char **argv) goto fail; printf("okay\n"); - printf("%-40s", "Testing daa/das (all inputs)..."); #ifndef __x86_64__ + printf("%-40s", "Testing daa/das (all inputs)..."); /* Bits 0-7: AL; Bit 8: EFLG_AF; Bit 9: EFLG_CF; Bit 10: DAA vs. DAS. */ for ( i = 0; i < 0x800; i++ ) { @@ -679,9 +679,7 @@ int main(int argc, char **argv) } } printf("okay\n"); -#else - printf("skipped\n"); - +#else /* x86-64 */ printf("%-40s", "Testing cmovz %ecx,%eax..."); instr[0] = 0x0f; instr[1] = 0x44; instr[2] = 0xc1; regs.eflags = 0x200;