diff mbox

x86/time: don't omit newline in dump_softtsc()

Message ID 584E68F80200007800127C46@prv-mh.provo.novell.com (mailing list archive)
State New, archived
Headers show

Commit Message

Jan Beulich Dec. 12, 2016, 8:08 a.m. UTC 
Reported-by: Anton Samsonov <devel@zxlab.ru>
Signed-off-by: Jan Beulich <jbeulich@suse.com>
x86/time: don't omit newline in dump_softtsc()

Reported-by: Anton Samsonov <devel@zxlab.ru>
Signed-off-by: Jan Beulich <jbeulich@suse.com>

--- a/xen/arch/x86/time.c
+++ b/xen/arch/x86/time.c
@@ -2145,12 +2145,11 @@ static void dump_softtsc(unsigned char k
         if ( d->arch.incarnation )
             printk(",inc=%"PRIu32, d->arch.incarnation);
 #if !defined(NDEBUG) || defined(CONFIG_PERF_COUNTERS)
-        if ( !(d->arch.vtsc_kerncount | d->arch.vtsc_usercount) )
-            printk("\n");
-        else
-            printk(",vtsc count: %"PRIu64" kernel, %"PRIu64" user\n",
+        if ( d->arch.vtsc_kerncount | d->arch.vtsc_usercount )
+            printk(",vtsc count: %"PRIu64" kernel,%"PRIu64" user",
                    d->arch.vtsc_kerncount, d->arch.vtsc_usercount);
 #endif
+        printk("\n");
         domcnt++;
     }

Comments

Andrew Cooper Dec. 12, 2016, 10 a.m. UTC | #1 
On 12/12/16 08:08, Jan Beulich wrote:
> Reported-by: Anton Samsonov <devel@zxlab.ru>
> Signed-off-by: Jan Beulich <jbeulich@suse.com>

Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>
diff mbox

Patch

--- a/xen/arch/x86/time.c
+++ b/xen/arch/x86/time.c
@@ -2145,12 +2145,11 @@  static void dump_softtsc(unsigned char k
         if ( d->arch.incarnation )
             printk(",inc=%"PRIu32, d->arch.incarnation);
 #if !defined(NDEBUG) || defined(CONFIG_PERF_COUNTERS)
-        if ( !(d->arch.vtsc_kerncount | d->arch.vtsc_usercount) )
-            printk("\n");
-        else
-            printk(",vtsc count: %"PRIu64" kernel, %"PRIu64" user\n",
+        if ( d->arch.vtsc_kerncount | d->arch.vtsc_usercount )
+            printk(",vtsc count: %"PRIu64" kernel,%"PRIu64" user",
                    d->arch.vtsc_kerncount, d->arch.vtsc_usercount);
 #endif
+        printk("\n");
         domcnt++;
     }