diff mbox series

fix vbd rd_sects stat

Message ID 585c34fd96c6e22847333d9d18843c0f@kojedz.in (mailing list archive)
State New
Headers show
Series fix vbd rd_sects stat | expand

Commit Message

Richard Kojedzinszky July 9, 2021, 8:09 a.m. UTC

Comments

Andrew Cooper July 9, 2021, 8:59 a.m. UTC | #1
On 09/07/2021 09:09, Richard Kojedzinszky wrote:

Thankyou for the patch.  That is quite an embarrassing bug.

However, for copyright reasons, we require all submissions to contain a
Signed-off-by line, as per the Developer's Certificate of Origin,
https://wiki.xenproject.org/wiki/Submitting_Xen_Project_Patches#Signed-off-by

Given how trivial this patch is, feel free to just reply to this email
with confirmation and I can sort it out on commit.

However, for future patches, please include directly.  (Also, if you are
able to use git-send-email, and the get_maintainers.pl script, that
would be even better.)

~Andrew
Richard Kojedzinszky July 9, 2021, 9:32 a.m. UTC | #2
Then please add signed-by headers. :)


Thanks

2021. július 9. 10:59:54 CEST, Andrew Cooper <andrew.cooper3@citrix.com> írta:
>On 09/07/2021 09:09, Richard Kojedzinszky wrote:
>
>Thankyou for the patch.  That is quite an embarrassing bug.
>
>However, for copyright reasons, we require all submissions to contain a
>Signed-off-by line, as per the Developer's Certificate of Origin,
>https://wiki.xenproject.org/wiki/Submitting_Xen_Project_Patches#Signed-off-by
>
>Given how trivial this patch is, feel free to just reply to this email
>with confirmation and I can sort it out on commit.
>
>However, for future patches, please include directly.  (Also, if you
>are
>able to use git-send-email, and the get_maintainers.pl script, that
>would be even better.)
>
>~Andrew
Andrew Cooper July 9, 2021, 11:30 a.m. UTC | #3
On 09/07/2021 10:32, Richard Kojedzinszky wrote:
> Then please add signed-by headers. :)

Ok.   I have fixed up and committed the patch.

https://xenbits.xen.org/gitweb/?p=xen.git;a=commitdiff;h=89d57f291e37b4769ab26db919eba46548f2e13e

This will want queueing for backporting

~Andrew
Richard Kojedzinszky July 9, 2021, 11:37 a.m. UTC | #4
Dear Andrew,

Many thanks.

Meanwhile I would like to promote our xenstat-exporter, which we use for 
monitoring our vps instances.

https://github.com/euronetzrt/xenstat-exporter

We've spotted the bug during browsing the metrics.

Regards,
Richard

2021-07-09 13:30 időpontban Andrew Cooper ezt írta:
> On 09/07/2021 10:32, Richard Kojedzinszky wrote:
>> Then please add signed-by headers. :)
> 
> Ok.   I have fixed up and committed the patch.
> 
> https://xenbits.xen.org/gitweb/?p=xen.git;a=commitdiff;h=89d57f291e37b4769ab26db919eba46548f2e13e
> 
> This will want queueing for backporting
> 
> ~Andrew
Andrew Cooper July 9, 2021, 12:18 p.m. UTC | #5
On 09/07/2021 12:37, Richard Kojedzinszky wrote:
> Dear Andrew,
>
> Many thanks.
>
> Meanwhile I would like to promote our xenstat-exporter, which we use
> for monitoring our vps instances.
>
> https://github.com/euronetzrt/xenstat-exporter
>
> We've spotted the bug during browsing the metrics.

Hello.

We're always interested to hear what people are doing in the Xen
ecosystem.  CC-ing the Community Manager.

~Andrew
diff mbox series

Patch

From d09d27e40cfbdd2dbf5aefaa40a4f46ccb268056 Mon Sep 17 00:00:00 2001
Message-Id: <d09d27e40cfbdd2dbf5aefaa40a4f46ccb268056.1625818025.git.richard@kojedz.in>
From: Richard Kojedzinszky <richard@kojedz.in>
Date: Fri, 9 Jul 2021 10:06:45 +0200
Subject: [PATCH] xenstat_linux.c: fix populating vbd.rd_sect

---
 tools/libs/stat/xenstat_linux.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/libs/stat/xenstat_linux.c b/tools/libs/stat/xenstat_linux.c
index 875a0617ad..8939cf3bcd 100644
--- a/tools/libs/stat/xenstat_linux.c
+++ b/tools/libs/stat/xenstat_linux.c
@@ -475,7 +475,7 @@  int xenstat_collect_vbds(xenstat_node * node)
 				(read_attributes_vbd(dp->d_name, "statistics/wr_req", buf, 256)<=0) ||
 				((ret = sscanf(buf, "%llu", &vbd.wr_reqs)) != 1) ||
 				(read_attributes_vbd(dp->d_name, "statistics/rd_sect", buf, 256)<=0) ||
-				((ret = sscanf(buf, "%llu", &vbd.wr_sects)) != 1) ||
+				((ret = sscanf(buf, "%llu", &vbd.rd_sect)) != 1) ||
 				(read_attributes_vbd(dp->d_name, "statistics/wr_sect", buf, 256)<=0) ||
 				((ret = sscanf(buf, "%llu", &vbd.wr_sects)) != 1))
 			{
-- 
2.20.1