diff mbox

x86/EFI: avoid overrunning mb_modules[]

Message ID 58CBC32702000078001442BA@prv-mh.provo.novell.com (mailing list archive)
State New, archived
Headers show

Commit Message

Jan Beulich March 17, 2017, 10:06 a.m. UTC 
Commit 436fb462ab ("x86/microcode: enable boot time (pre-Dom0)
loading") added a 4th module without providing an array slot for it.

Signed-off-by: Jan Beulich <jbeulich@suse.com>
x86/EFI: avoid overrunning mb_modules[]

Commit 436fb462ab ("x86/microcode: enable boot time (pre-Dom0)
loading") added a 4th module without providing an array slot for it.

Signed-off-by: Jan Beulich <jbeulich@suse.com>

--- a/xen/arch/x86/efi/efi-boot.h
+++ b/xen/arch/x86/efi/efi-boot.h
@@ -13,7 +13,7 @@ static struct file __initdata ucode;
 static multiboot_info_t __initdata mbi = {
     .flags = MBI_MODULES | MBI_LOADERNAME
 };
-static module_t __initdata mb_modules[3];
+static module_t __initdata mb_modules[4];
 
 static void __init edd_put_string(u8 *dst, size_t n, const char *src)
 {

Comments

Andrew Cooper March 17, 2017, 10:36 a.m. UTC | #1 
On 17/03/17 10:06, Jan Beulich wrote:
> Commit 436fb462ab ("x86/microcode: enable boot time (pre-Dom0)
> loading") added a 4th module without providing an array slot for it.
>
> Signed-off-by: Jan Beulich <jbeulich@suse.com>

Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>
diff mbox

Patch

--- a/xen/arch/x86/efi/efi-boot.h
+++ b/xen/arch/x86/efi/efi-boot.h
@@ -13,7 +13,7 @@  static struct file __initdata ucode;
 static multiboot_info_t __initdata mbi = {
     .flags = MBI_MODULES | MBI_LOADERNAME
 };
-static module_t __initdata mb_modules[3];
+static module_t __initdata mb_modules[4];
 
 static void __init edd_put_string(u8 *dst, size_t n, const char *src)
 {