diff mbox

x86/MSI: improve memory usage in struct msi_desc

Message ID 592E8794020000780015DF57@prv-mh.provo.novell.com (mailing list archive)
State New, archived
Headers show

Commit Message

Jan Beulich May 31, 2017, 7:06 a.m. UTC 
There's no reason to have both a 4-byte hole and 4 bytes of tail
padding.

Signed-off-by: Jan Beulich <jbeulich@suse.com>
x86/MSI: improve memory usage in struct msi_desc

There's no reason to have both a 4-byte hole and 4 bytes of tail
padding.

Signed-off-by: Jan Beulich <jbeulich@suse.com>

--- a/xen/include/asm-x86/msi.h
+++ b/xen/include/asm-x86/msi.h
@@ -119,10 +119,9 @@ struct msi_desc {
 	};
 	struct pci_dev *dev;
 	int irq;
+	int remap_index;		/* index in interrupt remapping table */
 
 	struct msi_msg msg;		/* Last set MSI message */
-
-	int remap_index;		/* index in interrupt remapping table */
 };
 
 /*

Comments

Andrew Cooper May 31, 2017, 9:55 a.m. UTC | #1 
On 31/05/17 08:06, Jan Beulich wrote:
> There's no reason to have both a 4-byte hole and 4 bytes of tail
> padding.
>
> Signed-off-by: Jan Beulich <jbeulich@suse.com>

Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>
diff mbox

Patch

--- a/xen/include/asm-x86/msi.h
+++ b/xen/include/asm-x86/msi.h
@@ -119,10 +119,9 @@  struct msi_desc {
 	};
 	struct pci_dev *dev;
 	int irq;
+	int remap_index;		/* index in interrupt remapping table */
 
 	struct msi_msg msg;		/* Last set MSI message */
-
-	int remap_index;		/* index in interrupt remapping table */
 };
 
 /*