diff mbox

smp: assert that all affected CPUs are online in on_selected_cpus()

Message ID 592E91C6020000780015E066@prv-mh.provo.novell.com (mailing list archive)
State New, archived
Headers show

Commit Message

Jan Beulich May 31, 2017, 7:49 a.m. UTC 
Signed-off-by: Jan Beulich <jbeulich@suse.com>
Suggested-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>
smp: assert that all affected CPUs are online in on_selected_cpus()

Signed-off-by: Jan Beulich <jbeulich@suse.com>
Suggested-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>

--- a/xen/common/smp.c
+++ b/xen/common/smp.c
@@ -53,6 +53,7 @@ void on_selected_cpus(
     unsigned int nr_cpus;
 
     ASSERT(local_irq_is_enabled());
+    ASSERT(cpumask_subset(selected, &cpu_online_map));
 
     spin_lock(&call_lock);

Comments

Wei Liu May 31, 2017, 9:52 a.m. UTC | #1 
On Wed, May 31, 2017 at 01:49:58AM -0600, Jan Beulich wrote:
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
> Suggested-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>

Reviewed-by: Wei Liu <wei.liu2@citrix.com>
Andrew Cooper May 31, 2017, 12:45 p.m. UTC | #2 
On 31/05/17 08:49, Jan Beulich wrote:
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
> Suggested-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>

Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>
diff mbox

Patch

--- a/xen/common/smp.c
+++ b/xen/common/smp.c
@@ -53,6 +53,7 @@  void on_selected_cpus(
     unsigned int nr_cpus;
 
     ASSERT(local_irq_is_enabled());
+    ASSERT(cpumask_subset(selected, &cpu_online_map));
 
     spin_lock(&call_lock);