diff mbox

x86/HAP: don't open code clear_domain_page()

Message ID 59302436020000780015EB54@prv-mh.provo.novell.com (mailing list archive)
State New, archived
Headers show

Commit Message

Jan Beulich June 1, 2017, 12:27 p.m. UTC 
Also drop a stray initializer.

Signed-off-by: Jan Beulich <jbeulich@suse.com>
x86/HAP: don't open code clear_domain_page()

Also drop a stray initializer.

Signed-off-by: Jan Beulich <jbeulich@suse.com>

--- a/xen/arch/x86/mm/hap/hap.c
+++ b/xen/arch/x86/mm/hap/hap.c
@@ -248,8 +248,7 @@ static void hap_clean_dirty_bitmap(struc
 /************************************************/
 static struct page_info *hap_alloc(struct domain *d)
 {
-    struct page_info *pg = NULL;
-    void *p;
+    struct page_info *pg;
 
     ASSERT(paging_locked_by_me(d));
 
@@ -259,9 +258,7 @@ static struct page_info *hap_alloc(struc
 
     d->arch.paging.hap.free_pages--;
 
-    p = __map_domain_page(pg);
-    clear_page(p);
-    unmap_domain_page(p);
+    clear_domain_page(page_to_mfn(pg));
 
     return pg;
 }

Comments

Andrew Cooper June 1, 2017, 1:13 p.m. UTC | #1 
On 01/06/17 13:27, Jan Beulich wrote:
> Also drop a stray initializer.
>
> Signed-off-by: Jan Beulich <jbeulich@suse.com>

Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>
George Dunlap June 1, 2017, 2:50 p.m. UTC | #2 
On 01/06/17 13:27, Jan Beulich wrote:
> Also drop a stray initializer.
> 
> Signed-off-by: Jan Beulich <jbeulich@suse.com>

Acked-by: George Dunlap <george.dunlap@citrix.com>

> 
> --- a/xen/arch/x86/mm/hap/hap.c
> +++ b/xen/arch/x86/mm/hap/hap.c
> @@ -248,8 +248,7 @@ static void hap_clean_dirty_bitmap(struc
>  /************************************************/
>  static struct page_info *hap_alloc(struct domain *d)
>  {
> -    struct page_info *pg = NULL;
> -    void *p;
> +    struct page_info *pg;
>  
>      ASSERT(paging_locked_by_me(d));
>  
> @@ -259,9 +258,7 @@ static struct page_info *hap_alloc(struc
>  
>      d->arch.paging.hap.free_pages--;
>  
> -    p = __map_domain_page(pg);
> -    clear_page(p);
> -    unmap_domain_page(p);
> +    clear_domain_page(page_to_mfn(pg));
>  
>      return pg;
>  }
> 
> 
>
diff mbox

Patch

--- a/xen/arch/x86/mm/hap/hap.c
+++ b/xen/arch/x86/mm/hap/hap.c
@@ -248,8 +248,7 @@  static void hap_clean_dirty_bitmap(struc
 /************************************************/
 static struct page_info *hap_alloc(struct domain *d)
 {
-    struct page_info *pg = NULL;
-    void *p;
+    struct page_info *pg;
 
     ASSERT(paging_locked_by_me(d));
 
@@ -259,9 +258,7 @@  static struct page_info *hap_alloc(struc
 
     d->arch.paging.hap.free_pages--;
 
-    p = __map_domain_page(pg);
-    clear_page(p);
-    unmap_domain_page(p);
+    clear_domain_page(page_to_mfn(pg));
 
     return pg;
 }