From patchwork Fri Jun 9 14:01:57 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jan Beulich X-Patchwork-Id: 9778609 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 45E936034B for ; Fri, 9 Jun 2017 14:04:06 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 37BBC285C2 for ; Fri, 9 Jun 2017 14:04:06 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 2C52128618; Fri, 9 Jun 2017 14:04:06 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=2.0 tests=BAYES_00, RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id A0985285C2 for ; Fri, 9 Jun 2017 14:04:05 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dJKUF-0001M3-LM; Fri, 09 Jun 2017 14:02:03 +0000 Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dJKUD-0001Lw-La for xen-devel@lists.xenproject.org; Fri, 09 Jun 2017 14:02:01 +0000 Received: from [85.158.137.68] by server-8.bemta-3.messagelabs.com id 33/E8-23755-85AAA395; Fri, 09 Jun 2017 14:02:00 +0000 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrPIsWRWlGSWpSXmKPExsXS6fjDSzdilVW kwZ37LBbft0xmcmD0OPzhCksAYxRrZl5SfkUCa8a5v3wFz2Qq7r07zdzAeECii5GTQ0ggT+L0 oZ2MXYwcHLwCdhL/njiDhCUEDCVOL7zJAmKzCKhKnLxzB8xmE1CXaHu2nRWkXETAQOLc0aQuR i4OZoGrTBJNi1eyg9QIC9hIvJvXxQIx3k5i2owdrBDjBSX+7hAGCTMDhTu63rFNYOSehZCZhS QDYWtJPPx1iwXC1pZYtvA1M0g5s4C0xPJ/HBBhZ4klT7ayoioBsf0kpj44xraAkWMVo3pxalF ZapGuiV5SUWZ6RkluYmaOrqGBsV5uanFxYnpqTmJSsV5yfu4mRmBAMgDBDsbGL06HGCU5mJRE eacVWEUK8SXlp1RmJBZnxBeV5qQWH2KU4eBQkuB9vgIoJ1iUmp5akZaZA4wNmLQEB4+SCK/9S qA0b3FBYm5xZjpE6hSjopQ4bxFIQgAkkVGaB9cGi8dLjLJSwryMQIcI8RSkFuVmlqDKv2IU52 BUEuZlA5nCk5lXAjf9FdBiJqDFS95ZgCwuSURISTUwLs+rcu15/6hstw33v7MFgiJfvKwmXqv eqf5D0S611i426LHGl94NJ/nneWy211Zlt6t1fOhuqm19x9rPP77HofF3cN6zUk2ROywSD00W vJmk+vyv+tIuncNPXq8N6ii4t1RcQGb14v37Vn7UiVhatKiHc0GuthRP8rntVhd+9Py5c/hD7 wErJZbijERDLeai4kQAryOGlMICAAA= X-Env-Sender: JBeulich@suse.com X-Msg-Ref: server-4.tower-31.messagelabs.com!1497016918!46821957!1 X-Originating-IP: [137.65.248.74] X-SpamReason: No, hits=0.0 required=7.0 tests= X-StarScan-Received: X-StarScan-Version: 9.4.19; banners=-,-,- X-VirusChecked: Checked Received: (qmail 50107 invoked from network); 9 Jun 2017 14:01:59 -0000 Received: from prv-mh.provo.novell.com (HELO prv-mh.provo.novell.com) (137.65.248.74) by server-4.tower-31.messagelabs.com with DHE-RSA-AES256-GCM-SHA384 encrypted SMTP; 9 Jun 2017 14:01:59 -0000 Received: from INET-PRV-MTA by prv-mh.provo.novell.com with Novell_GroupWise; Fri, 09 Jun 2017 08:01:57 -0600 Message-Id: <593AC675020000780016160F@prv-mh.provo.novell.com> X-Mailer: Novell GroupWise Internet Agent 14.2.2 Date: Fri, 09 Jun 2017 08:01:57 -0600 From: "Jan Beulich" To: "xen-devel" References: <593AC675020000780016160F@prv-mh.provo.novell.com> Mime-Version: 1.0 Cc: Stefano Stabellini , Wei Liu , George Dunlap , Andrew Cooper , Ian Jackson , Tim Deegan , Julien Grall Subject: [Xen-devel] [PATCH v2] public: there's no MMUEXT_SET_FOREIGNDOM X-BeenThere: xen-devel@lists.xen.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" X-Virus-Scanned: ClamAV using ClamSMTP Correct respective comments. Signed-off-by: Jan Beulich Acked-by: Andrew Cooper --- v2: Also mention XENMAPSPACE_gmfn_foreign for DOMID_XEN. public: there's no MMUEXT_SET_FOREIGNDOM Correct respective comments. Signed-off-by: Jan Beulich --- v2: Also mention XENMAPSPACE_gmfn_foreign for DOMID_XEN. --- a/xen/include/public/xen.h +++ b/xen/include/public/xen.h @@ -550,16 +550,21 @@ DEFINE_XEN_GUEST_HANDLE(mmuext_op_t); * is useful to ensure that no mappings to the OS's own heap are accidentally * installed. (e.g., in Linux this could cause havoc as reference counts * aren't adjusted on the I/O-mapping code path). - * This only makes sense in MMUEXT_SET_FOREIGNDOM, but in that context can - * be specified by any calling domain. + * This only makes sense as HYPERVISOR_mmu_update()'s and + * HYPERVISOR_update_va_mapping_otherdomain()'s "foreigndom" argument. For + * HYPERVISOR_mmu_update() context it can be specified by any calling domain, + * otherwise it's only permitted if the caller is privileged. */ #define DOMID_IO xen_mk_uint(0x7FF1) /* * DOMID_XEN is used to allow privileged domains to map restricted parts of * Xen's heap space (e.g., the machine_to_phys table). - * This only makes sense in MMUEXT_SET_FOREIGNDOM, and is only permitted if - * the caller is privileged. + * This only makes sense as + * - HYPERVISOR_mmu_update()'s, HYPERVISOR_mmuext_op()'s, or + * HYPERVISOR_update_va_mapping_otherdomain()'s "foreigndom" argument, + * - with XENMAPSPACE_gmfn_foreign, + * and is only permitted if the caller is privileged. */ #define DOMID_XEN xen_mk_uint(0x7FF2) --- a/xen/include/public/xen.h +++ b/xen/include/public/xen.h @@ -550,16 +550,21 @@ DEFINE_XEN_GUEST_HANDLE(mmuext_op_t); * is useful to ensure that no mappings to the OS's own heap are accidentally * installed. (e.g., in Linux this could cause havoc as reference counts * aren't adjusted on the I/O-mapping code path). - * This only makes sense in MMUEXT_SET_FOREIGNDOM, but in that context can - * be specified by any calling domain. + * This only makes sense as HYPERVISOR_mmu_update()'s and + * HYPERVISOR_update_va_mapping_otherdomain()'s "foreigndom" argument. For + * HYPERVISOR_mmu_update() context it can be specified by any calling domain, + * otherwise it's only permitted if the caller is privileged. */ #define DOMID_IO xen_mk_uint(0x7FF1) /* * DOMID_XEN is used to allow privileged domains to map restricted parts of * Xen's heap space (e.g., the machine_to_phys table). - * This only makes sense in MMUEXT_SET_FOREIGNDOM, and is only permitted if - * the caller is privileged. + * This only makes sense as + * - HYPERVISOR_mmu_update()'s, HYPERVISOR_mmuext_op()'s, or + * HYPERVISOR_update_va_mapping_otherdomain()'s "foreigndom" argument, + * - with XENMAPSPACE_gmfn_foreign, + * and is only permitted if the caller is privileged. */ #define DOMID_XEN xen_mk_uint(0x7FF2)