From patchwork Fri Jun 16 09:08:38 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jan Beulich X-Patchwork-Id: 9790963 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 7933960326 for ; Fri, 16 Jun 2017 09:11:05 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 6F59828572 for ; Fri, 16 Jun 2017 09:11:05 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 63F3D28589; Fri, 16 Jun 2017 09:11:05 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=2.0 tests=BAYES_00, RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id E9CFD28572 for ; Fri, 16 Jun 2017 09:11:04 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dLnFF-0003AF-W9; Fri, 16 Jun 2017 09:08:45 +0000 Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dLnFF-0003A9-7h for xen-devel@lists.xenproject.org; Fri, 16 Jun 2017 09:08:45 +0000 Received: from [85.158.137.68] by server-6.bemta-3.messagelabs.com id B6/F4-19409-C10A3495; Fri, 16 Jun 2017 09:08:44 +0000 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrDIsWRWlGSWpSXmKPExsXS6fjDS1d6gXO kwbejMhbft0xmcmD0OPzhCksAYxRrZl5SfkUCa8aveTuZC5ZJVuxpXs3ewPhWuIuRk0NIIE+i dc8tdhCbV8BOoufCfWYQW0LAUOL0wpssIDaLgKrEuRkbWEFsNgF1ibZn24FsDg4RAQOJc0eTQ ExmAX2JbevAqoUFtCSuLJzCBjHdTqLz9FEmkBJeAUGJvzvAljIDhS++3sM4gZF7FkJmFpIMhK 0l8fDXLRYIW1ti2cLXzLPAdklLLP/HARE2k3g/ZSYjqhIQ21Hi8t6PzAsYOVYxahSnFpWlFuk aWeolFWWmZ5TkJmbm6BoaGOvlphYXJ6an5iQmFesl5+duYgSGZD0DA+MOxqa9focYJTmYlER5 +eWcIoX4kvJTKjMSizPii0pzUosPMWpwcAhs27X6AqMUS15+XqqSBO+6ec6RQoJFqempFWmZO cCogSmV4OBREuE90A6U5i0uSMwtzkyHSJ1iVJQS5+0H6RMASWSU5sG1wSL1EqOslDAvIwMDgx BPQWpRbmYJqvwrRnEORiVhXof5QFN4MvNK4Ka/AlrMBLQ46IIDyOKSRISUVAOjztHkdR3fjjY nv9puMXFd3IcZHorzfaVC/sU5OglsCrNM/pa+ZErb3ykMz+49Tg8z3xX9qi30pG/+7nl+F3Y9 cS965qM8827Ynt7InSodwsYCl3bM2Bb8WDeH9cyTWWd3rl/Z779s25xCHabzU/f+e7/Qqp7bw lL8Evs6w4NKm24dtnz1zMjmqBJLcUaioRZzUXEiAN4tsrXPAgAA X-Env-Sender: JBeulich@suse.com X-Msg-Ref: server-15.tower-31.messagelabs.com!1497604121!101880336!1 X-Originating-IP: [137.65.248.74] X-SpamReason: No, hits=0.0 required=7.0 tests= X-StarScan-Received: X-StarScan-Version: 9.4.19; banners=-,-,- X-VirusChecked: Checked Received: (qmail 3767 invoked from network); 16 Jun 2017 09:08:43 -0000 Received: from prv-mh.provo.novell.com (HELO prv-mh.provo.novell.com) (137.65.248.74) by server-15.tower-31.messagelabs.com with DHE-RSA-AES256-GCM-SHA384 encrypted SMTP; 16 Jun 2017 09:08:43 -0000 Received: from INET-PRV-MTA by prv-mh.provo.novell.com with Novell_GroupWise; Fri, 16 Jun 2017 03:08:40 -0600 Message-Id: <5943BC3602000078001635E0@prv-mh.provo.novell.com> X-Mailer: Novell GroupWise Internet Agent 14.2.2 Date: Fri, 16 Jun 2017 03:08:38 -0600 From: "Jan Beulich" To: "xen-devel" References: <5943BC3602000078001635E0@prv-mh.provo.novell.com> Mime-Version: 1.0 Cc: Andrew Cooper Subject: [Xen-devel] [PATCH v2] x86emul: minor cleanup X-BeenThere: xen-devel@lists.xen.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" X-Virus-Scanned: ClamAV using ClamSMTP Drop a redundant input constraint and correct a comment. Signed-off-by: Jan Beulich Reviewed-by: Andrew Cooper --- v2: Drop exception handling related adjustments (moved to patch converting that to the stub model). x86emul: minor cleanup Drop a redundant input constraint and correct a comment. Signed-off-by: Jan Beulich --- v2: Drop exception handling related adjustments (moved to patch converting that to the stub model). --- a/xen/arch/x86/x86_emulate/x86_emulate.c +++ b/xen/arch/x86/x86_emulate/x86_emulate.c @@ -5681,8 +5681,7 @@ x86_emulate( [eflags] "+g" (_regs.eflags), [tmp] "=&r" (dummy), "+m" (*mmvalp), "+m" (fic.exn_raised) - : [func] "rm" (stub.func), "a" (mmvalp), - [mask] "i" (EFLAGS_MASK)); + : "a" (mmvalp), [mask] "i" (EFLAGS_MASK)); put_stub(stub); check_xmm_exn(&fic); @@ -6086,7 +6085,7 @@ x86_emulate( case X86EMUL_OPC_F3(0x0f, 0x6f): /* movdqu xmm/m128,xmm */ case X86EMUL_OPC_VEX_F3(0x0f, 0x6f): /* vmovdqu {x,y}mm/mem,{x,y}mm */ case X86EMUL_OPC_66(0x0f, 0x7f): /* movdqa xmm,xmm/m128 */ - case X86EMUL_OPC_VEX_66(0x0f, 0x7f): /* vmovdqa {x,y}mm,{x,y}mm/m128 */ + case X86EMUL_OPC_VEX_66(0x0f, 0x7f): /* vmovdqa {x,y}mm,{x,y}mm/mem */ case X86EMUL_OPC_F3(0x0f, 0x7f): /* movdqu xmm,xmm/m128 */ case X86EMUL_OPC_VEX_F3(0x0f, 0x7f): /* vmovdqu {x,y}mm,{x,y}mm/mem */ movdqa: --- a/xen/arch/x86/x86_emulate/x86_emulate.c +++ b/xen/arch/x86/x86_emulate/x86_emulate.c @@ -5681,8 +5681,7 @@ x86_emulate( [eflags] "+g" (_regs.eflags), [tmp] "=&r" (dummy), "+m" (*mmvalp), "+m" (fic.exn_raised) - : [func] "rm" (stub.func), "a" (mmvalp), - [mask] "i" (EFLAGS_MASK)); + : "a" (mmvalp), [mask] "i" (EFLAGS_MASK)); put_stub(stub); check_xmm_exn(&fic); @@ -6086,7 +6085,7 @@ x86_emulate( case X86EMUL_OPC_F3(0x0f, 0x6f): /* movdqu xmm/m128,xmm */ case X86EMUL_OPC_VEX_F3(0x0f, 0x6f): /* vmovdqu {x,y}mm/mem,{x,y}mm */ case X86EMUL_OPC_66(0x0f, 0x7f): /* movdqa xmm,xmm/m128 */ - case X86EMUL_OPC_VEX_66(0x0f, 0x7f): /* vmovdqa {x,y}mm,{x,y}mm/m128 */ + case X86EMUL_OPC_VEX_66(0x0f, 0x7f): /* vmovdqa {x,y}mm,{x,y}mm/mem */ case X86EMUL_OPC_F3(0x0f, 0x7f): /* movdqu xmm,xmm/m128 */ case X86EMUL_OPC_VEX_F3(0x0f, 0x7f): /* vmovdqu {x,y}mm,{x,y}mm/mem */ movdqa: