diff mbox

[02/11] gnttab: remove redundant xenheap check from gnttab_transfer()

Message ID 594A59060200007800165038@prv-mh.provo.novell.com (mailing list archive)
State New, archived
Headers show

Commit Message

Jan Beulich June 21, 2017, 9:31 a.m. UTC 
The message isn't very useful, and the check is being done by
steal_page() anyway.

Signed-off-by: Jan Beulich <jbeulich@suse.com>
gnttab: remove redundant xenheap check from gnttab_transfer()

The message isn't very useful, and the check is being done by
steal_page() anyway.

Signed-off-by: Jan Beulich <jbeulich@suse.com>

--- a/xen/common/grant_table.c
+++ b/xen/common/grant_table.c
@@ -1843,15 +1843,6 @@ gnttab_transfer(
         }
 
         page = mfn_to_page(mfn);
-        if ( unlikely(is_xen_heap_page(page)) )
-        { 
-            put_gfn(d, gop.mfn);
-            gdprintk(XENLOG_INFO, "gnttab_transfer: xen frame %lx\n",
-                    (unsigned long)gop.mfn);
-            gop.status = GNTST_bad_page;
-            goto copyback;
-        }
-
         if ( steal_page(d, page, 0) < 0 )
         {
             put_gfn(d, gop.mfn);

Comments

Andrew Cooper June 21, 2017, 11:28 a.m. UTC | #1 
On 21/06/17 10:31, Jan Beulich wrote:
> The message isn't very useful, and the check is being done by
> steal_page() anyway.
>
> Signed-off-by: Jan Beulich <jbeulich@suse.com>

Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>
diff mbox

Patch

--- a/xen/common/grant_table.c
+++ b/xen/common/grant_table.c
@@ -1843,15 +1843,6 @@  gnttab_transfer(
         }
 
         page = mfn_to_page(mfn);
-        if ( unlikely(is_xen_heap_page(page)) )
-        { 
-            put_gfn(d, gop.mfn);
-            gdprintk(XENLOG_INFO, "gnttab_transfer: xen frame %lx\n",
-                    (unsigned long)gop.mfn);
-            gop.status = GNTST_bad_page;
-            goto copyback;
-        }
-
         if ( steal_page(d, page, 0) < 0 )
         {
             put_gfn(d, gop.mfn);