From patchwork Wed Jun 21 09:31:18 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jan Beulich X-Patchwork-Id: 9801323 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id B17E560329 for ; Wed, 21 Jun 2017 09:33:21 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 9E9E91FF12 for ; Wed, 21 Jun 2017 09:33:21 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 937F920243; Wed, 21 Jun 2017 09:33:21 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=2.0 tests=BAYES_00, RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 102A41FF12 for ; Wed, 21 Jun 2017 09:33:20 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dNbyu-0007pO-DS; Wed, 21 Jun 2017 09:31:24 +0000 Received: from mail6.bemta6.messagelabs.com ([193.109.254.103]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dNbyt-0007oy-0l for xen-devel@lists.xenproject.org; Wed, 21 Jun 2017 09:31:23 +0000 Received: from [193.109.254.147] by server-10.bemta-6.messagelabs.com id 31/48-03613-AEC3A495; Wed, 21 Jun 2017 09:31:22 +0000 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrOIsWRWlGSWpSXmKPExsXS6fjDS/eljVe kwe2dOhbft0xmcmD0OPzhCksAYxRrZl5SfkUCa8bO/T2MBc/5K5b/e8bUwDiJp4uRk0NIIE9i 9qY3TCA2r4CdRN/FF+wgtoSAocTphTdZuhg5OFgEVCVe7EwFCbMJqEu0PdvOChIWETCQOHc0q YuRi4NZYC2TxMVZd5lA4sICoRIvP7JCTC+S2HpgNdhETgF7iTnLXrOBlPAKCEr83SEMEmYGWt rR/ohxAiPPLITMLCQZCFtL4uGvWywQtrbEsoWvmUHKmQWkJZb/44AwrSQeL3ZGVQFiu0oc+vq IcQEjxypGjeLUorLUIl1DU72kosz0jJLcxMwcXUMDM73c1OLixPTUnMSkYr3k/NxNjMBAZQCC HYzflgUcYpTkYFIS5b0g6xUpxJeUn1KZkVicEV9UmpNafIhRhoNDSYK30BooJ1iUmp5akZaZA 4wZmLQEB4+SCO8yc6A0b3FBYm5xZjpE6hSjLseG1eu/MAmx5OXnpUqJ83aAzBAAKcoozYMbAY vfS4yyUsK8jEBHCfEUpBblZpagyr9iFOdgVBLmfWcFNIUnM68EbtMroCOYgI54ccQD5IiSRIS UVAOjqd2pawonqk5suDU/qN+nNOxDmMbBD2Zqzy6UeRetWL200U3WYbJF3SPen+4Wuu8+Xuvo qJL5VsYesbHPOFLZqXwiU0BknsDp5LIsE47N2QXbrxZGBFTcK4xZp3OQXevMT6m37zTDY/OXr mCblVYo1rZQq12lgEfsgc2eLV76ezYc+Hpwb6oSS3FGoqEWc1FxIgDaPeQc2gIAAA== X-Env-Sender: JBeulich@suse.com X-Msg-Ref: server-2.tower-27.messagelabs.com!1498037480!49177275!1 X-Originating-IP: [137.65.248.74] X-SpamReason: No, hits=0.0 required=7.0 tests= X-StarScan-Received: X-StarScan-Version: 9.4.19; banners=-,-,- X-VirusChecked: Checked Received: (qmail 8412 invoked from network); 21 Jun 2017 09:31:21 -0000 Received: from prv-mh.provo.novell.com (HELO prv-mh.provo.novell.com) (137.65.248.74) by server-2.tower-27.messagelabs.com with DHE-RSA-AES256-GCM-SHA384 encrypted SMTP; 21 Jun 2017 09:31:21 -0000 Received: from INET-PRV-MTA by prv-mh.provo.novell.com with Novell_GroupWise; Wed, 21 Jun 2017 03:31:19 -0600 Message-Id: <594A59060200007800165038@prv-mh.provo.novell.com> X-Mailer: Novell GroupWise Internet Agent 14.2.2 Date: Wed, 21 Jun 2017 03:31:18 -0600 From: "Jan Beulich" To: "xen-devel" References: <594A57B10200007800165012@prv-mh.provo.novell.com> <594A57B10200007800165012@prv-mh.provo.novell.com> In-Reply-To: <594A57B10200007800165012@prv-mh.provo.novell.com> Mime-Version: 1.0 Cc: Stefano Stabellini , Wei Liu , George Dunlap , Andrew Cooper , Ian Jackson , Tim Deegan Subject: [Xen-devel] [PATCH 02/11] gnttab: remove redundant xenheap check from gnttab_transfer() X-BeenThere: xen-devel@lists.xen.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" X-Virus-Scanned: ClamAV using ClamSMTP The message isn't very useful, and the check is being done by steal_page() anyway. Signed-off-by: Jan Beulich gnttab: remove redundant xenheap check from gnttab_transfer() The message isn't very useful, and the check is being done by steal_page() anyway. Signed-off-by: Jan Beulich --- a/xen/common/grant_table.c +++ b/xen/common/grant_table.c @@ -1843,15 +1843,6 @@ gnttab_transfer( } page = mfn_to_page(mfn); - if ( unlikely(is_xen_heap_page(page)) ) - { - put_gfn(d, gop.mfn); - gdprintk(XENLOG_INFO, "gnttab_transfer: xen frame %lx\n", - (unsigned long)gop.mfn); - gop.status = GNTST_bad_page; - goto copyback; - } - if ( steal_page(d, page, 0) < 0 ) { put_gfn(d, gop.mfn); Reviewed-by: Andrew Cooper --- a/xen/common/grant_table.c +++ b/xen/common/grant_table.c @@ -1843,15 +1843,6 @@ gnttab_transfer( } page = mfn_to_page(mfn); - if ( unlikely(is_xen_heap_page(page)) ) - { - put_gfn(d, gop.mfn); - gdprintk(XENLOG_INFO, "gnttab_transfer: xen frame %lx\n", - (unsigned long)gop.mfn); - gop.status = GNTST_bad_page; - goto copyback; - } - if ( steal_page(d, page, 0) < 0 ) { put_gfn(d, gop.mfn);