diff mbox

IOMMU/PCI: properly annotate setup_one_hwdom_device()

Message ID 598C268F020000780016E675@prv-mh.provo.novell.com (mailing list archive)
State New, archived
Headers show

Commit Message

Jan Beulich Aug. 10, 2017, 7:25 a.m. UTC 
Its sole caller is __hwdom_init, so it can be such itself, too.

Signed-off-by: Jan Beulich <jbeulich@suse.com>

Comments

Andrew Cooper Aug. 10, 2017, 8:28 a.m. UTC | #1 
On 10/08/2017 08:25, Jan Beulich wrote:
> Its sole caller is __hwdom_init, so it can be such itself, too.
>
> Signed-off-by: Jan Beulich <jbeulich@suse.com>

Acked-by: Andrew Cooper <andrew.cooper3@citrix.com>
Roger Pau Monné Aug. 10, 2017, 9:45 a.m. UTC | #2 
On Thu, Aug 10, 2017 at 01:25:35AM -0600, Jan Beulich wrote:
> Its sole caller is __hwdom_init, so it can be such itself, too.
> 
> Signed-off-by: Jan Beulich <jbeulich@suse.com>

Reviewed-by: Roger Pau Monné <roger.pau@citrix.com>

Had the same patch in my queue, but you beat it to me.

Thanks, Roger.
diff mbox

Patch

--- a/xen/drivers/passthrough/pci.c
+++ b/xen/drivers/passthrough/pci.c
@@ -1026,8 +1026,8 @@  struct setup_hwdom {
     int (*handler)(u8 devfn, struct pci_dev *);
 };
 
-static void setup_one_hwdom_device(const struct setup_hwdom *ctxt,
-                                  struct pci_dev *pdev)
+static void __hwdom_init setup_one_hwdom_device(const struct setup_hwdom *ctxt,
+                                                struct pci_dev *pdev)
 {
     u8 devfn = pdev->devfn;