diff mbox

MAINTAINERS: add arch specific public headers to arch file groups

Message ID 59A95658020000780017678B@prv-mh.provo.novell.com (mailing list archive)
State New, archived
Headers show

Commit Message

Jan Beulich Sept. 1, 2017, 10:45 a.m. UTC
I've recently got sufficiently annoyed by people not applying enough
common sense to get_maintainer.pl output, Cc-ing all REST maintainers
on ARM-only public interface changes.

Sort ARM's xen/ groups of path specifications at the same time.

Signed-off-by: Jan Beulich <jbeulich@suse.com>

Comments

Andrew Cooper Sept. 1, 2017, 10:56 a.m. UTC | #1
On 01/09/17 11:45, Jan Beulich wrote:
> I've recently got sufficiently annoyed by people not applying enough
> common sense to get_maintainer.pl output, Cc-ing all REST maintainers
> on ARM-only public interface changes.
>
> Sort ARM's xen/ groups of path specifications at the same time.
>
> Signed-off-by: Jan Beulich <jbeulich@suse.com>

Acked-by: Andrew Cooper <andrew.cooper3@citrix.com>

>
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -166,14 +166,15 @@ S:	Supported
>  L:	xen-devel@lists.xen.org 
>  F:	docs/misc/arm/
>  F:	xen/arch/arm/
> -F:	xen/include/asm-arm/
> -F:	xen/drivers/char/cadence-uart.c
>  F:	xen/drivers/char/arm-uart.c
> +F:	xen/drivers/char/cadence-uart.c
>  F:	xen/drivers/char/exynos4210-uart.c
>  F:	xen/drivers/char/omap-uart.c
>  F:	xen/drivers/char/pl011.c
>  F:	xen/drivers/char/scif-uart.c
>  F:	xen/drivers/passthrough/arm/
> +F:	xen/include/asm-arm/
> +F:	xen/include/public/arch-arm/
>  
>  CPU POOLS
>  M:	Juergen Gross <jgross@suse.com>
> @@ -434,6 +435,7 @@ S:	Supported
>  L:	xen-devel@lists.xen.org 
>  F:	xen/arch/x86/
>  F:	xen/include/asm-x86/
> +F:	xen/include/public/arch-x86/
>  F:	tools/firmware/hvmloader/
>  F:	tools/firmware/rombios/
>  F:	tools/firmware/vgabios/
>
>
>
Wei Liu Sept. 4, 2017, 8:33 a.m. UTC | #2
On Fri, Sep 01, 2017 at 04:45:12AM -0600, Jan Beulich wrote:
> I've recently got sufficiently annoyed by people not applying enough
> common sense to get_maintainer.pl output, Cc-ing all REST maintainers
> on ARM-only public interface changes.
> 
> Sort ARM's xen/ groups of path specifications at the same time.
> 
> Signed-off-by: Jan Beulich <jbeulich@suse.com>

I tried to apply this patch from a downloaded maildir but it got
rejected.

I manually committed the changes, copied the commit message over and
pushed it, but it turns out I forgot to change the authorship to you. I
hope you don't mind.
Jan Beulich Sept. 4, 2017, 9:06 a.m. UTC | #3
>>> On 04.09.17 at 10:33, <wei.liu2@citrix.com> wrote:
> On Fri, Sep 01, 2017 at 04:45:12AM -0600, Jan Beulich wrote:
>> I've recently got sufficiently annoyed by people not applying enough
>> common sense to get_maintainer.pl output, Cc-ing all REST maintainers
>> on ARM-only public interface changes.
>> 
>> Sort ARM's xen/ groups of path specifications at the same time.
>> 
>> Signed-off-by: Jan Beulich <jbeulich@suse.com>
> 
> I tried to apply this patch from a downloaded maildir but it got
> rejected.
> 
> I manually committed the changes, copied the commit message over and
> pushed it, but it turns out I forgot to change the authorship to you. I
> hope you don't mind.

No problem at all - the main thing is that the change is in place.

Jan
Julien Grall Sept. 18, 2017, 10:10 a.m. UTC | #4
Hi Jan,

On 01/09/17 11:45, Jan Beulich wrote:
> I've recently got sufficiently annoyed by people not applying enough
> common sense to get_maintainer.pl output, Cc-ing all REST maintainers
> on ARM-only public interface changes.

It seems that you didn't move arch-arm.h, arch-x86_{32,64}.h under resp. 
ARM and x86 maintainership. Was it intentional?

Cheers,

> 
> Sort ARM's xen/ groups of path specifications at the same time.
> 
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
> 
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -166,14 +166,15 @@ S:	Supported
>   L:	xen-devel@lists.xen.org
>   F:	docs/misc/arm/
>   F:	xen/arch/arm/
> -F:	xen/include/asm-arm/
> -F:	xen/drivers/char/cadence-uart.c
>   F:	xen/drivers/char/arm-uart.c
> +F:	xen/drivers/char/cadence-uart.c
>   F:	xen/drivers/char/exynos4210-uart.c
>   F:	xen/drivers/char/omap-uart.c
>   F:	xen/drivers/char/pl011.c
>   F:	xen/drivers/char/scif-uart.c
>   F:	xen/drivers/passthrough/arm/
> +F:	xen/include/asm-arm/
> +F:	xen/include/public/arch-arm/
>   
>   CPU POOLS
>   M:	Juergen Gross <jgross@suse.com>
> @@ -434,6 +435,7 @@ S:	Supported
>   L:	xen-devel@lists.xen.org
>   F:	xen/arch/x86/
>   F:	xen/include/asm-x86/
> +F:	xen/include/public/arch-x86/
>   F:	tools/firmware/hvmloader/
>   F:	tools/firmware/rombios/
>   F:	tools/firmware/vgabios/
> 
> 
> 
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> https://lists.xen.org/xen-devel
>
Jan Beulich Sept. 18, 2017, 10:37 a.m. UTC | #5
>>> On 18.09.17 at 12:10, <julien.grall@arm.com> wrote:
> Hi Jan,
> 
> On 01/09/17 11:45, Jan Beulich wrote:
>> I've recently got sufficiently annoyed by people not applying enough
>> common sense to get_maintainer.pl output, Cc-ing all REST maintainers
>> on ARM-only public interface changes.
> 
> It seems that you didn't move arch-arm.h, arch-x86_{32,64}.h under resp. 
> ARM and x86 maintainership. Was it intentional?

No, but the two x86 ones you mention are merely compatibility
stubs, which aren't really expected to ever change, so who is
their formal maintainer doesn't matter. For arch-arm.h I agree
it should be put under ARM maintainership.

Jan
diff mbox

Patch

--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -166,14 +166,15 @@  S:	Supported
 L:	xen-devel@lists.xen.org 
 F:	docs/misc/arm/
 F:	xen/arch/arm/
-F:	xen/include/asm-arm/
-F:	xen/drivers/char/cadence-uart.c
 F:	xen/drivers/char/arm-uart.c
+F:	xen/drivers/char/cadence-uart.c
 F:	xen/drivers/char/exynos4210-uart.c
 F:	xen/drivers/char/omap-uart.c
 F:	xen/drivers/char/pl011.c
 F:	xen/drivers/char/scif-uart.c
 F:	xen/drivers/passthrough/arm/
+F:	xen/include/asm-arm/
+F:	xen/include/public/arch-arm/
 
 CPU POOLS
 M:	Juergen Gross <jgross@suse.com>
@@ -434,6 +435,7 @@  S:	Supported
 L:	xen-devel@lists.xen.org 
 F:	xen/arch/x86/
 F:	xen/include/asm-x86/
+F:	xen/include/public/arch-x86/
 F:	tools/firmware/hvmloader/
 F:	tools/firmware/rombios/
 F:	tools/firmware/vgabios/