diff mbox series

[v8,01/50] x86emul: no need to set fault_suppression to false for VMOVNT*

Message ID 5C8B802A020000780021F116@prv1-mh.provo.novell.com (mailing list archive)
State New, archived
Headers show
Series x86emul: remaining AVX512 support | expand

Commit Message

Jan Beulich March 15, 2019, 10:36 a.m. UTC 
When evex.opmsk is required to be zero there's no need for this, as it
won't have been set to true in the first place.

Signed-off-by: Jan Beulich <jbeulich@suse.com>
---
v8: Add this previously standalone patch into the series.

Comments

Andrew Cooper March 15, 2019, 4:52 p.m. UTC | #1 
On 15/03/2019 10:36, Jan Beulich wrote:
> When evex.opmsk is required to be zero there's no need for this, as it
> won't have been set to true in the first place.
>
> Signed-off-by: Jan Beulich <jbeulich@suse.com>

Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>
diff mbox series

Patch

--- a/xen/arch/x86/x86_emulate/x86_emulate.c
+++ b/xen/arch/x86/x86_emulate/x86_emulate.c
@@ -5911,7 +5911,6 @@  x86_emulate(
     CASE_SIMD_PACKED_FP(_EVEX, 0x0f, 0x2b): /* vmovntp{s,d} [xyz]mm,mem */
         generate_exception_if(ea.type != OP_MEM || evex.opmsk, EXC_UD);
         sfence = true;
-        fault_suppression = false;
         /* fall through */
     CASE_SIMD_PACKED_FP(_EVEX, 0x0f, 0x10): /* vmovup{s,d} [xyz]mm/mem,[xyz]mm{k} */
     CASE_SIMD_SCALAR_FP(_EVEX, 0x0f, 0x10): /* vmovs{s,d} mem,xmm{k} */
@@ -6795,7 +6794,6 @@  x86_emulate(
         generate_exception_if(ea.type != OP_MEM || evex.opmsk || evex.w,
                               EXC_UD);
         sfence = true;
-        fault_suppression = false;
         /* fall through */
     case X86EMUL_OPC_EVEX_66(0x0f, 0x6f): /* vmovdqa{32,64} [xyz]mm/mem,[xyz]mm{k} */
     case X86EMUL_OPC_EVEX_F3(0x0f, 0x6f): /* vmovdqu{32,64} [xyz]mm/mem,[xyz]mm{k} */