| Message ID | 5CD2D598020000780022CD43@prv1-mh.provo.novell.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | x86: IRQ management adjustments | expand |
On Wed, May 08, 2019 at 07:11:52AM -0600, Jan Beulich wrote: > If any particular value was to be checked against, it would need to be > IRQ_VECTOR_UNASSIGNED. > > Reported-by: Roger Pau Monné <roger.pau@citrix.com> > > Be more strict though and use valid_irq_vector() instead. > > Take the opportunity and also convert local variables to unsigned int. > > Signed-off-by: Jan Beulich <jbeulich@suse.com> Reviewed-by: Roger Pau Monné <roger.pau@citrix.com> Thanks, Roger.
--- a/xen/arch/x86/irq.c +++ b/xen/arch/x86/irq.c @@ -276,14 +276,13 @@ static void release_old_vec(struct irq_d static void _clear_irq_vector(struct irq_desc *desc) { - unsigned int cpu; - int vector, old_vector, irq = desc->irq; + unsigned int cpu, old_vector, irq = desc->irq; + unsigned int vector = desc->arch.vector; cpumask_t tmp_mask; - BUG_ON(!desc->arch.vector); + BUG_ON(!valid_irq_vector(vector)); /* Always clear desc->arch.vector */ - vector = desc->arch.vector; cpumask_and(&tmp_mask, desc->arch.cpu_mask, &cpu_online_map); for_each_cpu(cpu, &tmp_mask) {
If any particular value was to be checked against, it would need to be IRQ_VECTOR_UNASSIGNED. Reported-by: Roger Pau Monné <roger.pau@citrix.com> Be more strict though and use valid_irq_vector() instead. Take the opportunity and also convert local variables to unsigned int. Signed-off-by: Jan Beulich <jbeulich@suse.com> --- v2: New.