kconfig: ensure strndup() declaration is visible

Commit Message

Jan Beulich Jan. 11, 2021, 2:42 p.m. UTC

Its guard was updated such that it is visible by default when POSIX 2008
was adopted by glibc. It's not visible by default on older glibc.

Fixes: f80fe2b34f08 ("xen: Update Kconfig to Linux v5.4")
Signed-off-by: Jan Beulich <[e-mail]>

Comments

Andrew Cooper Jan. 13, 2021, 9:14 p.m. UTC | #1

On 11/01/2021 14:42, Jan Beulich wrote:
> Its guard was updated such that it is visible by default when POSIX 2008
> was adopted by glibc. It's not visible by default on older glibc.
>
> Fixes: f80fe2b34f08 ("xen: Update Kconfig to Linux v5.4")
> Signed-off-by: Jan Beulich <[e-mail]>

Acked-by: Andrew Cooper <[e-mail]>

Jan Beulich Jan. 18, 2021, 3:39 p.m. UTC | #2

Doug,

On 11.01.2021 15:42, Jan Beulich wrote:
> Its guard was updated such that it is visible by default when POSIX 2008
> was adopted by glibc. It's not visible by default on older glibc.
> 
> Fixes: f80fe2b34f08 ("xen: Update Kconfig to Linux v5.4")
> Signed-off-by: Jan Beulich <[e-mail]>

I've got an ack from Andrew, but strictly speaking I need yours
aiui. I'll wait some more, but will commit this perhaps by mid
of the week.

Jan

Douglas Goldstein Jan. 18, 2021, 5:21 p.m. UTC | #3

On 1/11/21 8:42 AM, Jan Beulich wrote:
> Its guard was updated such that it is visible by default when POSIX 2008
> was adopted by glibc. It's not visible by default on older glibc.
> 
> Fixes: f80fe2b34f08 ("xen: Update Kconfig to Linux v5.4")
> Signed-off-by: Jan Beulich <[e-mail]>
> 
> --- a/xen/tools/kconfig/parser.y
> +++ b/xen/tools/kconfig/parser.y
> @@ -4,6 +4,7 @@
>    */
>   %{
>   
> +#define _GNU_SOURCE
>   #include <ctype.h>
>   #include <stdarg.h>
>   #include <stdio.h>
> 

Ack-by: Doug Goldstein <[e-mail]>

Patch

--- a/xen/tools/kconfig/parser.y
+++ b/xen/tools/kconfig/parser.y
@@ -4,6 +4,7 @@ 
  */
 %{
 
+#define _GNU_SOURCE
 #include <ctype.h>
 #include <stdarg.h>
 #include <stdio.h>