diff mbox series

[XEN,v1,1/3] automation: Fix URL to the gitlab container registry documentation

Message ID 5ebb776792a345724b43b0843aa41c21febcc843.1729170005.git.javi.merino@cloud.com (mailing list archive)
State New
Headers show
Series CI: Upgrade the Fedora container and fix build failure | expand

Commit Message

Javi Merino Oct. 17, 2024, 4:20 p.m. UTC
The gitlab documentation is now at
https://docs.gitlab.com/ee/administration/packages/container_registry.html

Signed-off-by: Javi Merino <javi.merino@cloud.com>
---
 automation/build/README.md | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Anthony PERARD Oct. 17, 2024, 5:02 p.m. UTC | #1
On Thu, Oct 17, 2024 at 05:20:19PM +0100, Javi Merino wrote:
> The gitlab documentation is now at
> https://docs.gitlab.com/ee/administration/packages/container_registry.html

This link seems to be for self-managed instance of gitlab, but the link
in the patch looks fine.

> Signed-off-by: Javi Merino <javi.merino@cloud.com>

The patch description could be removed, so:
Reviewed-by: Anthony PERARD <anthony.perard@vates.tech>

Thanks,

> ---
>  automation/build/README.md | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/automation/build/README.md b/automation/build/README.md
> index bd0c0e041804..ecc898680c91 100644
> --- a/automation/build/README.md
> +++ b/automation/build/README.md
> @@ -110,7 +110,7 @@ make -C automation/build opensuse/tumbleweed-x86_64 PUSH=1
>  
>  [BuildKit]: https://docs.docker.com/build/buildkit/
>  [registry]: https://gitlab.com/xen-project/xen/container_registry
> -[registry help]: https://gitlab.com/help/user/project/container_registry
> +[registry help]: https://docs.gitlab.com/ee/user/packages/container_registry/
>  
>  
>  Building/Running container for a different architecture
Stefano Stabellini Oct. 18, 2024, 2:01 a.m. UTC | #2
On Thu, 17 Oct 2024, Anthony PERARD wrote:
> On Thu, Oct 17, 2024 at 05:20:19PM +0100, Javi Merino wrote:
> > The gitlab documentation is now at
> > https://docs.gitlab.com/ee/administration/packages/container_registry.html
> 
> This link seems to be for self-managed instance of gitlab, but the link
> in the patch looks fine.
> 
> > Signed-off-by: Javi Merino <javi.merino@cloud.com>
> 
> The patch description could be removed, so:
> Reviewed-by: Anthony PERARD <anthony.perard@vates.tech>


Acked-by: Stefano Stabellini <sstabellini@kernel.org>

 
> > ---
> >  automation/build/README.md | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/automation/build/README.md b/automation/build/README.md
> > index bd0c0e041804..ecc898680c91 100644
> > --- a/automation/build/README.md
> > +++ b/automation/build/README.md
> > @@ -110,7 +110,7 @@ make -C automation/build opensuse/tumbleweed-x86_64 PUSH=1
> >  
> >  [BuildKit]: https://docs.docker.com/build/buildkit/
> >  [registry]: https://gitlab.com/xen-project/xen/container_registry
> > -[registry help]: https://gitlab.com/help/user/project/container_registry
> > +[registry help]: https://docs.gitlab.com/ee/user/packages/container_registry/
> >  
> >  
> >  Building/Running container for a different architecture
> 
> -- 
> 
> Anthony Perard | Vates XCP-ng Developer
> 
> XCP-ng & Xen Orchestra - Vates solutions
> 
> web: https://vates.tech
>
diff mbox series

Patch

diff --git a/automation/build/README.md b/automation/build/README.md
index bd0c0e041804..ecc898680c91 100644
--- a/automation/build/README.md
+++ b/automation/build/README.md
@@ -110,7 +110,7 @@  make -C automation/build opensuse/tumbleweed-x86_64 PUSH=1
 
 [BuildKit]: https://docs.docker.com/build/buildkit/
 [registry]: https://gitlab.com/xen-project/xen/container_registry
-[registry help]: https://gitlab.com/help/user/project/container_registry
+[registry help]: https://docs.gitlab.com/ee/user/packages/container_registry/
 
 
 Building/Running container for a different architecture