From patchwork Thu Mar 30 11:28:04 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jan Beulich X-Patchwork-Id: 13193982 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B4005C761A6 for ; Thu, 30 Mar 2023 11:28:19 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.516635.801073 (Exim 4.92) (envelope-from ) id 1phqRu-0008Lm-Jc; Thu, 30 Mar 2023 11:28:10 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 516635.801073; Thu, 30 Mar 2023 11:28:10 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1phqRu-0008Lf-Gk; Thu, 30 Mar 2023 11:28:10 +0000 Received: by outflank-mailman (input) for mailman id 516635; Thu, 30 Mar 2023 11:28:09 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1phqRt-0008Hi-7b for xen-devel@lists.xenproject.org; Thu, 30 Mar 2023 11:28:09 +0000 Received: from EUR03-DBA-obe.outbound.protection.outlook.com (mail-dbaeur03on2060f.outbound.protection.outlook.com [2a01:111:f400:fe1a::60f]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id f17ae3ad-ceed-11ed-b464-930f4c7d94ae; Thu, 30 Mar 2023 13:28:07 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by PAXPR04MB8782.eurprd04.prod.outlook.com (2603:10a6:102:20d::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6222.35; Thu, 30 Mar 2023 11:28:06 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::154e:166d:ec25:531b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::154e:166d:ec25:531b%6]) with mapi id 15.20.6222.033; Thu, 30 Mar 2023 11:28:05 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f17ae3ad-ceed-11ed-b464-930f4c7d94ae ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dHhl5j7FNcvkHOfe24V4SM18kCPTzXi+RRxUi7vk0sifUa3lgs6Mp69rZY35nLyx4KsMo0nGDgSmaiombpLoTpHjZZnlfVsHZ1u9sJjg9ZTbc3WPqwmF7GJstR8Nggi7kLa8K8tqEFUG4+v5DsBIJVU1A8QXQRux9wMkH8K3X2cYFkFKDhGyZaoo0tDHDze38gYKY8lZ2ulPvJ1fEzg/S0Zx9vL+K6el6lB0n9wA5ZiA5jhAp32n+HZokynrQyczDfscjXs2wR/UdCpfPKFzb68UorZ5X3jZ6BSglv+4SlNyQc82o9AJuRCATsh2DoBjJHhS9DhXjMAvPVutB2H0Jg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=bLFXY1A1PoRDeG2OxMqFXZeghqkcVHyCuf7lr3QrX/U=; b=LGIbasSAViVCSKX+dCOV9iyH+d19WKFAnbd2vtR0Eem1zG+jt69M4tfe3W8NM5RJ2e3OVTERrg3gYtvPJAHhAlnMleA81Xl3z7uVVZJ59WptKej4lb8ry5DyxqmsnDyiw+rLeB2Tv0PMrIrxzpDcHuW27bhaN/iNSIafMgJwUlsWRxb+qFDCCXPN9B/yhSoKw3LcIhA5281PjEiN3I/iHTp1Dry3MJmuryhMMb/f846P4UOnaoqQbWoKImcT28PBcrs4SUWHKHEifmy3oxiLQAAr5dtaMod8tIMM+nMuJutsi/h10JVOJHIcUntIbGEJ3RPRZ5Te9XJhus3m/j3Y2w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=bLFXY1A1PoRDeG2OxMqFXZeghqkcVHyCuf7lr3QrX/U=; b=otxxi+15956H2KFZJhaldcSAmVBLCw1pUJDwmbnpRcKcrDxfg6BV4GZ5tAo6H+xP8I1pcBQkaCyTEvLYbkFpJ+G4FkLap9orf0YjxyzT+crw93jd+8AMPecX/Zfv//k9M1dN4vGbm/5VnN8MTl2SL4KXgaa06vLofZdifgOsDyY95bVqnSneN24vycATzeVh2n8BkAUIDYooxjDMxKhylkjUvJZb3JkuOyBjvlOQPAFKXTazKhpILJqr8TynFeFAOq/Re6Azy2RSDKaFiVxWX8Lg1qVzumIQ6tOnaOIIQtdr3sZCujHtDwNERpGwMS9V1WCi2NIVTtX3+ZiF8Q/7HQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <6363f9aa-4030-d889-a85d-f5834e607d85@suse.com> Date: Thu, 30 Mar 2023 13:28:04 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: [PATCH v2 05/13] x86/shadow: don't generate bogus "domain dying" trace entry from sh_page_fault() Content-Language: en-US From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , Wei Liu , =?utf-8?q?Roger_Pau_Monn=C3=A9?= , George Dunlap , Tim Deegan References: In-Reply-To: X-ClientProxiedBy: FR3P281CA0192.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a4::16) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|PAXPR04MB8782:EE_ X-MS-Office365-Filtering-Correlation-Id: 1ed8ee46-0696-4e5a-9a0c-08db3111d4d4 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: kkYaEWtsx7PFfKM1PwHx6ux3lX/5+JYW5iaNU4gaMLqiCj/dLuDY34hw5EYx69kAq3wA5Orm7qsh3/zRJ02Rln81zb026YzqQ/+1al5TPH2uPh71zRBxEq6l/958odINyftdk1VFgMDT6vDxuXRyNHALOCwMDdYzqNX03C5r0ZopW+9b8rwLQ7zFEc7HLEVCSzyxhmH/TKCJB9Eow4ZwPzOPACHrSQddv9M6pcHvjGER0d1dl/edMxb3Urq7P/1X++xwfQ9fduwW7VnlAe610HqOSqNWdTYym7y71XNqjiTKyJA4jZSRkmtzqbatE1FNrmhNQH13njoDkBI+6GDgD39Sf+2w9DaJx4rUZF2vMRagUlmKEapADmzlqx/Xwu/2ELxWP+3P8u4jbujn1p4f/gR9QZTwCwrkxetRt4/ZN9znJN5b0H20F9A80+AkQHHJ5fNYZuiTta5Xu9phyZGWKwGGoDrru/87EtyRxiHaaQhAZK6EZX+aaIzWHqyR5HBCdW6rq0QFXa1rwrKwHzQj6hvlI/zlxhHqv4khPibcFTkkt8icPmxGL8h1mF8ETLuJN1ZlDjAdEGQFoVQ82JyvkDFBnQ9Nt4B2mH4ZCggfBapaAGPd9F25hovP2jh5P5rGmY7DJZzucUn0nvk7vcCb6JenJY+9skcXhSx8B6kjxf3ciBOeSzeZw+SSWIVRFj7AXxRmfZI1z3us6sQQ8mRzSw== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(346002)(366004)(136003)(39860400002)(396003)(376002)(451199021)(316002)(66556008)(8676002)(66476007)(54906003)(6916009)(5660300002)(38100700002)(41300700001)(4744005)(66946007)(8936002)(186003)(4326008)(2616005)(6506007)(6486002)(6512007)(478600001)(83380400001)(26005)(86362001)(2906002)(31696002)(36756003)(31686004)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?F1C6AmujT8GQB2+70O+p0OeooKFD?= =?utf-8?q?v8jJI+shE0WJoPwFxXdPGYKTghvkQKudNZGqgdnRV14bcnWeYb43zZNi9Kfqe+yOm?= =?utf-8?q?xkbrjIZpPsLtUVTNqJiP1yCymevDIEZUuN6q8B5RLVSXr4M7hUupyjgcHxV9rqftR?= =?utf-8?q?i8/ySTm41PHMk6puWpDuEjkLvy0V0Ic2mY0x/KKR5272AaE0iyNw5UtpRzmyiiVcS?= =?utf-8?q?eUH5rFTJzd8Ds8WfhIMS53GAN0VkD7R1VBA/xFA+491ytkIB2gvXPDx3Pv7Ui4Q43?= =?utf-8?q?xM8hf0Am0t7eHHz8ZmLOinPWobOTbjuq7srjSkCffH2RrNgnn1Jfz7pL36oC6jF6c?= =?utf-8?q?gpPw3L5GKUCXTB84LFFCcvx0gjlEHDU0Atk/BY1Fn5GCaJJSsBr47c9LjM+vAwy+v?= =?utf-8?q?ajaW5WuwE1eghdAXg+UAdWeB2Mb//UIZsg/A8r1SpawFZq4G4+X202MdnkLCYI6Mj?= =?utf-8?q?x18l7c7Fw40boC2Q+D4R6OKiEzQSsGjZ0s/Ar8LFO+zygXDRKgYGbZzuC9mkLsANu?= =?utf-8?q?9ugUaiFwhI9kSdaoGvNyK/yW2IZCb/u6W0AvNdzRfc9b/iizAPDGHLbl7opMVYtRC?= =?utf-8?q?9eGNktvNg1IBBevD9MRgbDlXYnOizPVNu0JeHak2hwfAACWDl3Aet4sSTiHJqPm8s?= =?utf-8?q?IfTt14c/XY2uXv8fnAwAU3ifQ3qOhY7dLHbx11i3F4M47c2qTX4RxDZwemnWcM1J3?= =?utf-8?q?zewI3ysn912aOfRZ59mXoXDihBLpeJbJ0moJngCc7g+L6H6A5OyDK9Hugvd0+ud4A?= =?utf-8?q?ysdjrjPI+4WaqxzFDdPy7OJ4u4KYWawlsvj9+U0OB4J++eMxi6hqzoEO4/FNbvSwu?= =?utf-8?q?okULYTyAMe/bkv3lG4vY3wxBaX1DSd1J6LZdqw34PP9BMEuOg77ulzeDM6Tezy1Tq?= =?utf-8?q?2HmvtEk9msqKcOBZNDiwDVd1NHwMXzo6LcpLi3kVps2kTgM4Cs/R8a4+5sPRxYWDx?= =?utf-8?q?qlIm3YHMdosAoGdvxTOE8D1Bw2sdcuuDhKrA5E6QBtJirN4TxUK2MxnkEynR8BHSH?= =?utf-8?q?xefxRkMbhVwO5o6BQmezN16SZWqyUFhcjFEau9b+Bmxdb/v8NjqBYWKGtB/3U8njP?= =?utf-8?q?2BSj//GY+v/QPuvhu68JOdp4VQ3NfJrhX/3hZRjrK4xIXZqcygYvgll8aNeqkyVkk?= =?utf-8?q?x/ysHo2er8vU7HZqbRw0+Us/Ts4pkdNp0WeySU8FM93G9xdydSjqf1WZLxmzASJn+?= =?utf-8?q?gOjkPgvbqOGVVXJPVZrUvCUvL+xoNQ2wGjJqxlylLxwSY+pNzuak5wN6hn6Rdi6nO?= =?utf-8?q?wiUTs+lb8o0GFVso2bKzqiJYVarKxdNz/lPC+3AQkokVulKevrGkxvG4xF4WA3c2Z?= =?utf-8?q?thc+GT9GYI7t87JIjA8sQnW41/XLvzwtYa4J7ILPZ2DPjXX2K/eTXwRGjYsr6zCYV?= =?utf-8?q?CxmvL59RuLoKnKX+Grp2xQZ2AHPxLdm+yHg1o4ieQkR0ZdeLKYmwgAYxeC5RcobrO?= =?utf-8?q?3aM1trPeXNjPo+ZfaDu6XhxyxA4uDB6hVRwpE6hdYcyiYsEa+wMtv5MGSMVN514Dl?= =?utf-8?q?FBMKuGFjASGu?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1ed8ee46-0696-4e5a-9a0c-08db3111d4d4 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Mar 2023 11:28:05.9154 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: MAPpOQJNCsFA6To+zP515CbVcui0/lVJEhFS/0UQ4q9TUH5kg0u7LDYmbbIovPka0tTJQ9MTfClbu9aTYe8OKw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB8782 When in 3-level guest mode we help a guest to stay alive, we also shouldn't emit a trace entry to the contrary. Move the invocation up into the respective #ifdef, noting that while this moves it into the locked region, emitting trace records with the paging lock held is okay (as done elsewhere as well), just needlessly increasing lock holding time a little. Signed-off-by: Jan Beulich --- v2: New. --- a/xen/arch/x86/mm/shadow/multi.c +++ b/xen/arch/x86/mm/shadow/multi.c @@ -2492,10 +2492,10 @@ static int cf_check sh_page_fault( sh_update_cr3(v, 0, false); #else ASSERT(d->is_shutting_down); + trace_shadow_gen(TRC_SHADOW_DOMF_DYING, va); #endif paging_unlock(d); put_gfn(d, gfn_x(gfn)); - trace_shadow_gen(TRC_SHADOW_DOMF_DYING, va); return 0; }