diff mbox series

[4.17] Arm32: prune (again) ld warning about mismatched wchar_t sizes

Message ID 6a6df9c5-a527-63ac-60ec-fe7f3b6fadbd@suse.com (mailing list archive)
State New, archived
Headers show
Series [4.17] Arm32: prune (again) ld warning about mismatched wchar_t sizes | expand

Commit Message

Jan Beulich Oct. 27, 2022, 9:30 a.m. UTC
The name change (stub.c -> common-stub.c) rendered the earlier
workaround (commit a4d4c541f58b ["xen/arm32: avoid EFI stub wchar_t size
linker warning"]) ineffectual.

Fixes: bfd3e9945d1b ("build: fix x86 out-of-tree build without EFI")
Signed-off-by: Jan Beulich <jbeulich@suse.com>

Comments

Julien Grall Oct. 27, 2022, 9:32 a.m. UTC | #1
Hi Jan,

On 27/10/2022 10:30, Jan Beulich wrote:
> The name change (stub.c -> common-stub.c) rendered the earlier
> workaround (commit a4d4c541f58b ["xen/arm32: avoid EFI stub wchar_t size
> linker warning"]) ineffectual.

Ah! I noticed this warning over the week-end and was wondering why it 
was still there...

> 
> Fixes: bfd3e9945d1b ("build: fix x86 out-of-tree build without EFI")
> Signed-off-by: Jan Beulich <jbeulich@suse.com>

Acked-by: Julien Grall <jgrall@amazon.com>

Cheers,
Henry Wang Oct. 27, 2022, 9:34 a.m. UTC | #2
Hi Jan,

> -----Original Message-----
> From: Jan Beulich <jbeulich@suse.com>
> Subject: [PATCH][4.17] Arm32: prune (again) ld warning about mismatched
> wchar_t sizes
> 
> The name change (stub.c -> common-stub.c) rendered the earlier
> workaround (commit a4d4c541f58b ["xen/arm32: avoid EFI stub wchar_t size
> linker warning"]) ineffectual.
> 
> Fixes: bfd3e9945d1b ("build: fix x86 out-of-tree build without EFI")
> Signed-off-by: Jan Beulich <jbeulich@suse.com>

Release-acked-by: Henry Wang <Henry.Wang@arm.com>

Kind regards,
Henry
diff mbox series

Patch

--- a/xen/arch/arm/efi/Makefile
+++ b/xen/arch/arm/efi/Makefile
@@ -6,6 +6,6 @@  obj-$(CONFIG_ACPI) +=  efi-dom0.init.o
 else
 obj-y += common-stub.o
 
-$(obj)/stub.o: CFLAGS-y += -fno-short-wchar
+$(obj)/common-stub.o: CFLAGS-y += -fno-short-wchar
 
 endif