diff mbox series

x86emul/test: drop check for AVX512-4FMAPS

Message ID 779957ca-3250-4b33-ac1d-ace1dcdaafc0@suse.com (mailing list archive)
State New
Headers show
Series x86emul/test: drop check for AVX512-4FMAPS | expand

Commit Message

Jan Beulich April 8, 2025, 12:28 p.m. UTC
Use of Xeon Phi features was dropped earlier on; this one was overlooked.

Fixes: 85191cf32180 ("x86: drop Xeon Phi support")
Signed-off-by: Jan Beulich <jbeulich@suse.com>
---
In principle it looks as if we could now drop all of this checking, as
gcc5 supports all of the features we check for. AVX512-4FMAPS is an
example though where checking helps, as this and other Xeon Phi features
were supported by an intermediate range of gcc versions.

Comments

Andrew Cooper April 8, 2025, 12:42 p.m. UTC | #1
On 08/04/2025 1:28 pm, Jan Beulich wrote:
> Use of Xeon Phi features was dropped earlier on; this one was overlooked.
>
> Fixes: 85191cf32180 ("x86: drop Xeon Phi support")
> Signed-off-by: Jan Beulich <jbeulich@suse.com>

Acked-by: Andrew Cooper <andrew.cooper3@citrix.com>

> ---
> In principle it looks as if we could now drop all of this checking, as
> gcc5 supports all of the features we check for. AVX512-4FMAPS is an
> example though where checking helps, as this and other Xeon Phi features
> were supported by an intermediate range of gcc versions.

Whatever's easiest.  This is just a test harness.

~Andrew
diff mbox series

Patch

--- a/tools/tests/x86_emulator/Makefile
+++ b/tools/tests/x86_emulator/Makefile
@@ -105,7 +105,7 @@  TARGET-$(shell echo 'int i;' | $(CC) -x
 endef
 
 ISA := bmi bmi2 tbm sse4.1 sse4.2 sse4a avx avx2 f16c
-ISA += $(addprefix avx512,f bw dq 4fmaps)
+ISA += $(addprefix avx512,f bw dq)
 $(foreach isa,$(ISA),$(eval $(call isa-check-cc,$(isa))))
 
 # Also explicitly check for {evex} pseudo-prefix support, which got introduced