diff mbox series

[v3,07/12] x86/shadow: OOS doesn't track VAs anymore

Message ID 834a38d1-6917-7aa8-c560-0c943abb44c5@suse.com (mailing list archive)
State New, archived
Headers show
Series x86: assorted shadow mode adjustments | expand

Commit Message

Jan Beulich May 16, 2023, 7:40 a.m. UTC 
The tracking lasted only for about two weeks, but the related comment
parts were never purged.

Fixes: 50b74f55e0c0 ("OOS cleanup: Fixup arrays instead of fixup tables")
Signed-off-by: Jan Beulich <jbeulich@suse.com>
---
I'm heavily inclined to fold this into "x86/shadow: move OOS functions
to their own file".

This largely removes the justification for the per-vCPU hash. Is there
any other reason to name there in exchange?
---
v3: New.

Comments

Roger Pau Monné May 25, 2023, 2 p.m. UTC | #1 
On Tue, May 16, 2023 at 09:40:50AM +0200, Jan Beulich wrote:
> The tracking lasted only for about two weeks, but the related comment
> parts were never purged.
> 
> Fixes: 50b74f55e0c0 ("OOS cleanup: Fixup arrays instead of fixup tables")
> Signed-off-by: Jan Beulich <jbeulich@suse.com>

Acked-by: Roger Pau Monné <roger.pau@citrix.com>

Thanks, Roger.
diff mbox series

Patch

--- a/xen/arch/x86/mm/shadow/oos.c
+++ b/xen/arch/x86/mm/shadow/oos.c
@@ -51,13 +51,10 @@ 
  *
  * Currently out-of-sync pages are listed in a simple open-addressed
  * hash table with a second chance (must resist temptation to radically
- * over-engineer hash tables...)  The virtual address of the access
- * which caused us to unsync the page is also kept in the hash table, as
- * a hint for finding the writable mappings later.
+ * over-engineer hash tables...).
  *
  * We keep a hash per vcpu, because we want as much as possible to do
- * the re-sync on the save vcpu we did the unsync on, so the VA hint
- * will be valid.
+ * the re-sync on the same vcpu we did the unsync on.
  */
 
 #if SHADOW_AUDIT & SHADOW_AUDIT_ENTRIES_FULL