From patchwork Tue May 16 07:40:50 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Jan Beulich X-Patchwork-Id: 13242718 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 03CFAC77B75 for ; Tue, 16 May 2023 07:41:07 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.535000.832554 (Exim 4.92) (envelope-from ) id 1pypIm-0000KU-GH; Tue, 16 May 2023 07:40:56 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 535000.832554; Tue, 16 May 2023 07:40:56 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pypIm-0000KN-DX; Tue, 16 May 2023 07:40:56 +0000 Received: by outflank-mailman (input) for mailman id 535000; Tue, 16 May 2023 07:40:55 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pypIl-0006iO-GK for xen-devel@lists.xenproject.org; Tue, 16 May 2023 07:40:55 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on2060c.outbound.protection.outlook.com [2a01:111:f400:7d00::60c]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id fca8eebd-f3bc-11ed-8611-37d641c3527e; Tue, 16 May 2023 09:40:54 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM9PR04MB8988.eurprd04.prod.outlook.com (2603:10a6:20b:40b::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6387.30; Tue, 16 May 2023 07:40:52 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e442:306f:7711:e24c]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e442:306f:7711:e24c%4]) with mapi id 15.20.6387.032; Tue, 16 May 2023 07:40:52 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: fca8eebd-f3bc-11ed-8611-37d641c3527e ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=LESN9Lz+A77zqz/xxXRoqlGtXA+cx+68kKUgkcioU7YfAEVQ3KzAyAw4InYh4Xt9wPIPn2BcLhyx1p4ghOoH40DEXYtJjM2OkJcQmdYiECF1yrzC1YFaS99SlUDnYiM32D+KAPKLIfS/pYCUPgcn+D0zGUzJtbH6YV1SCYu8mPoOETYdaPZHn0hWGvDnAJKDBLDBer7w2YCdtjbwEyUqBDEh8OvsqoWCpl180rVrpoQT8MJqimIteTzKnMdQicb+dhkIcw2KqXF5ESq0rPxLR28wMf4Etx1xojmLk88P0rUuGNOmMHTB7/+mtte9o3KEB4welbvD3UCBlHRrZL1JiQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=H9Nh4XX47pvzSkaQ+Ro93eqswTOe4k38U8vTCnXpMhA=; b=NdiUpbXW9NKtSDqhLs32Z2wHbUDmcJC7x9Kf3O4Q5mRuH04o633QBggfD6i3T76FvLyo99jNlV8NhW696Ft5izNKDwjCpFVbbHwnwbxJ5xWvjRjuDn8R9eC4NiNB9MT7cSPI8+aoFUF/pL3CZRp1UVFYkMCB+yTc4v7kWVryvneLGnnsTXKutDFT1XkxVCrNcaTEz6fW2/3EB+dNxSzG5TNYUTEJfzKWxeeod9JZOPxgaCDj51oEzbiMB1gDKnANVcTY/iFmP9PRv/nbDYggLtpS8F/UEccOWw4K5M+kJG2Yc+9HF9Ll4SE4RYnizc97jC4img3w6wGW0mSJwCGysw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=H9Nh4XX47pvzSkaQ+Ro93eqswTOe4k38U8vTCnXpMhA=; b=dqmBO3YSjhye44QfYOimkqdmnBFyj7sPSTYje0JJ/uwg6LCueoPrZD/N5gMsgEeUuDOWttOTltJmPH/MOByGUnvmxqMg6hbpVpk1Av6zZDQpaPMzNPBcqSh2rBGNRx4tB5CpZ3kyDW3TpaFQAv3zfcBgNy0wNiqRGTvq80vzlgRqpTRO46hiHA2VSbynsg0VqdPfAmCzMBBCYuzaabgxeyq2kPUhwzkpYFGwpmPikJPQFQlDYkN2flOkwShlpXniLQuSerjDbjmSBRjxjewf8mzM4GBNbZAcKCv3jZdovnYgiMtpn0X2D7DRTYaB0owPg0WEPr39MLurdypOJ8F5Vg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <834a38d1-6917-7aa8-c560-0c943abb44c5@suse.com> Date: Tue, 16 May 2023 09:40:50 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.10.1 Subject: [PATCH v3 07/12] x86/shadow: OOS doesn't track VAs anymore Content-Language: en-US From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , Wei Liu , =?utf-8?q?Roger_Pau_Monn=C3=A9?= , George Dunlap , Tim Deegan References: <184df995-e668-1cea-6f9f-8e79a1ffcbbd@suse.com> In-Reply-To: <184df995-e668-1cea-6f9f-8e79a1ffcbbd@suse.com> X-ClientProxiedBy: FR0P281CA0192.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:ab::11) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|AM9PR04MB8988:EE_ X-MS-Office365-Filtering-Correlation-Id: e3692e86-6cdd-47fb-13c5-08db55e0e00c X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: kBRLAhLVuxWiGPamyyPsvLdrFJIEKwG9T+zZAXL7UHq5rw91mxS7STYEKzV0hZVq4WIowZPmr8GgwPvpI0nkG1morDCkVzPA4WT9q6NZSlYwaLd2DTcCdNn76uxqW6gXiJvU03VdCXtqiIk5UOQl+wBvoi45WjOZZ5n/Ikbs4MKTww9mH28Gxt+9RcC7io2nIEkem7ZhvgQHwROLRlgJsTiVFikxjLLVIliZ0/IHQNltEkjSsdoWDvmhI9EzssYWcOUoUCl87ftaI2HC8mYUjgc7HMFy8BMZO2ugui+LB1ktPnsF/yN4ubtOyRtOMiqDkIiuE6Kb1NzdfRCHfXwvcoJJmlTMt9d5ncjZ97G6FM7/YsTKwdi9H6xLk+SRURc8FBgjak7PmXtrvPt2D+3mbazdIYz8ipJYosKMu2apgv5FMEMKr8Qtf1YU+TGh1GoLOpnfb3OBTbCSH33BMYdYIMqUIKRXyDxv+F2ynUYM4wJ/6bzXbZ6eJrElKeTIPisznT6ilCgaonqZUHu7oJr+gg42noJOEAy9yNQS/gQoxr9qTt+oRU4DiSYbo5D4zqI7bqmMJxui2+ej/xJh2l40b2ERC/aTPDBY0JBNQwGPvMCshAKrjWUOKPm7W3paQdzmTdeVQY574jg2Tp5xCgq1qw== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(376002)(346002)(366004)(136003)(39860400002)(396003)(451199021)(2906002)(316002)(6916009)(31686004)(66946007)(4326008)(8676002)(5660300002)(8936002)(66556008)(66476007)(41300700001)(86362001)(2616005)(478600001)(54906003)(6486002)(36756003)(6506007)(186003)(31696002)(83380400001)(6512007)(26005)(38100700002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?eQgQrPdmYoBO3RWbrzkIavUcgjpI?= =?utf-8?q?yJYuCqzi+fJ+anqUYJ/7WMVWC6U1jDY3O3zQzXWfZoOtQKuVaH+xqadjHp3EBNin3?= =?utf-8?q?xNNGoTxKipRD+Q69jbht8ccWAF6Uu2CBpGPt60Ip7xLcurz7SG4OAz5X2Ryuc2zoF?= =?utf-8?q?7ze2dBep6O+IYfDBebemSJhMJcLd2eK5/WsEIQuXPmEIBQ6fRkrKjd41n0D/Q6km7?= =?utf-8?q?VasTmTN9RLjlcSfHHTRwXnmUEm2h37kzE8es0tAIrBtzPE8bnMN2gmVXiU++/c53o?= =?utf-8?q?qT82G+3jgv05Ac91byXqfYeMaSv3JCWq5PNM88VX98CndD68L/+Mb5/NvoovTJQkO?= =?utf-8?q?gGPxsAwuJKy6VthpMjw4/4Y4npiR5Ld4Ku2Pbts50smRqnuyHRGld3xe6Mo61yoJJ?= =?utf-8?q?4wpibrMkKeR5Z2uy6WO0NDj6B4kcY80mA/G4Srd2UfpEOPKkliLn3iV4lgNeoYBMt?= =?utf-8?q?yeOVjDpZFFUFCaCslklmFU8DxediOQpDwFOfU3nIaXUOol3mvBXBfQqsPXvL4K+YT?= =?utf-8?q?Vxy9QcTKU2dByzqiOaQroEHok89Y27vzPIy8q88kB166nT4PC0Pc7/TCbAZa7Qaxc?= =?utf-8?q?0EnaVkVELLNMCwGxJB1MvYVGXDEg97bmqYx5w42G613KadD68/+v2ezQzs+KVrl8e?= =?utf-8?q?sAYkzUB/gyd8W4cYSVfBIqTgPNXbtCLG5i1Wj7t8taxcIMB8XGAlAf6uMPdBxjRdG?= =?utf-8?q?v/wYJD6x4iTGkNMmHTTj95bYjkXFcCgIySJgzdrSqgri64g2rlWxbX0RImoBOBYXJ?= =?utf-8?q?dlEdC4zJBLdcTIGmSBhUnBCt1k9e9wQu2qK6zuvTRKTJaIf5W4NMivFyTsRDGeBsu?= =?utf-8?q?IrE3bgM7trnjouEzy7TJLLi9NrI5Qy3YM4lhffHETPLiwElYjgbzCGT+2Zzhqbd8F?= =?utf-8?q?Wv0uqCBYl10gkpUAXSyGVXqBjcg+0GeeP9fuswMSaQw6iEo//KOTOH/fx7S8O8KA7?= =?utf-8?q?T7jUwGFxq4uSD6L5Z3r/P6+6ViFthGuMAqb53HAAaLuKap70NGnoSk1s4lI5azp4D?= =?utf-8?q?/sILjxCTYwIreaRyyJBPB20ZKbeq2h1/Yoq+/8sw0g3e9z4fEdlUliDhn5KefxNzO?= =?utf-8?q?qyS4UCp4XLTjykggqbWx+l4k5tb6unv5hXwUHZUqo1IY+kMIrcwwg2AHqLOowCc5O?= =?utf-8?q?aWAzp0qpdtB/2tX0ClOBMTlrQPwD1ZxO2Yi1IXg2zJjz+9zV6J777LQ7a9wQ0k+tc?= =?utf-8?q?lHGbzyKr/oCpiDKR0f21INwLTw8p+2v+Xhpy6FIkBfZTaPTX9cNXK0flnSloPCh+v?= =?utf-8?q?X0AUoi+j5OihUXN3DJe6Ch5dAonpAAVCo+7xRMvyVaW4ddpyQYeBLsOHCQQmCmj39?= =?utf-8?q?0HMJt08e4yYLWx99A2HC6vDJVkd87U9X4kaZZiUBkGl/YweOwnKqhQPuBlQUiGWYh?= =?utf-8?q?2cJa4n7bbQ8IlG+Rrr9i4l4xkPeQPxxNQCgizmR5Z4Y/Od1Sj8qIyNXwWLqa8hyBh?= =?utf-8?q?UpFr8kYMWMOvgV8FCrfdifbXmmS+dqnrDQOH6U6uO6tyOurOpBII1m/GhupuflVZf?= =?utf-8?q?a9JilZ7Jg4ll?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: e3692e86-6cdd-47fb-13c5-08db55e0e00c X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 May 2023 07:40:52.4220 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 52kfRysJJE1vGN75oFRRPRh8C/BKcH4z095LQAhTmzEP5xSacf89pqj09bj87rmm5XMgt88atD9lIbYDwH8LeQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR04MB8988 The tracking lasted only for about two weeks, but the related comment parts were never purged. Fixes: 50b74f55e0c0 ("OOS cleanup: Fixup arrays instead of fixup tables") Signed-off-by: Jan Beulich Acked-by: Roger Pau Monné --- I'm heavily inclined to fold this into "x86/shadow: move OOS functions to their own file". This largely removes the justification for the per-vCPU hash. Is there any other reason to name there in exchange? --- v3: New. --- a/xen/arch/x86/mm/shadow/oos.c +++ b/xen/arch/x86/mm/shadow/oos.c @@ -51,13 +51,10 @@ * * Currently out-of-sync pages are listed in a simple open-addressed * hash table with a second chance (must resist temptation to radically - * over-engineer hash tables...) The virtual address of the access - * which caused us to unsync the page is also kept in the hash table, as - * a hint for finding the writable mappings later. + * over-engineer hash tables...). * * We keep a hash per vcpu, because we want as much as possible to do - * the re-sync on the save vcpu we did the unsync on, so the VA hint - * will be valid. + * the re-sync on the same vcpu we did the unsync on. */ #if SHADOW_AUDIT & SHADOW_AUDIT_ENTRIES_FULL