diff mbox series

[XEN,v3,4/4] README: remove old note about the build system's python expectation

Message ID 83e6857f16eb000f8368fcd9995e0411f0177c2e.1695104399.git.javi.merino@cloud.com (mailing list archive)
State New, archived
Headers show
Series python: Support setuptools | expand

Commit Message

Javi Merino Sept. 19, 2023, 6:30 a.m. UTC
5852ca485263 (build: fix tools/configure in case only python3 exists,
2019-12-11) changed the configure script to test for the availability
of python3, python and python2 in that order.  It sets PYTHON to the
first one found in path.  You don't need to have a symlink to python.

Remove the outdated note from the README.

Signed-off-by: Javi Merino <javi.merino@cloud.com>
---
 README | 7 -------
 1 file changed, 7 deletions(-)

Comments

Jan Beulich Sept. 19, 2023, 6:50 a.m. UTC | #1
On 19.09.2023 08:30, Javi Merino wrote:
> 5852ca485263 (build: fix tools/configure in case only python3 exists,
> 2019-12-11) changed the configure script to test for the availability
> of python3, python and python2 in that order.  It sets PYTHON to the
> first one found in path.  You don't need to have a symlink to python.
> 
> Remove the outdated note from the README.

But that note also covers the hypervisor build, which isn't affected by
./configure, and even less so by tools/configure.

Jan
Andrew Cooper Sept. 20, 2023, 7:40 p.m. UTC | #2
On 19/09/2023 7:50 am, Jan Beulich wrote:
> On 19.09.2023 08:30, Javi Merino wrote:
>> 5852ca485263 (build: fix tools/configure in case only python3 exists,
>> 2019-12-11) changed the configure script to test for the availability
>> of python3, python and python2 in that order.  It sets PYTHON to the
>> first one found in path.  You don't need to have a symlink to python.
>>
>> Remove the outdated note from the README.
> But that note also covers the hypervisor build, which isn't affected by
> ./configure, and even less so by tools/configure.

The hypervisor build equally doesn't python= specifying.

~Andrew
Jan Beulich Sept. 21, 2023, 5:59 a.m. UTC | #3
On 20.09.2023 21:40, Andrew Cooper wrote:
> On 19/09/2023 7:50 am, Jan Beulich wrote:
>> On 19.09.2023 08:30, Javi Merino wrote:
>>> 5852ca485263 (build: fix tools/configure in case only python3 exists,
>>> 2019-12-11) changed the configure script to test for the availability
>>> of python3, python and python2 in that order.  It sets PYTHON to the
>>> first one found in path.  You don't need to have a symlink to python.
>>>
>>> Remove the outdated note from the README.
>> But that note also covers the hypervisor build, which isn't affected by
>> ./configure, and even less so by tools/configure.
> 
> The hypervisor build equally doesn't python= specifying.

I'm pretty sure that on at least one of my systems I need PYTHON=python3
when building the hypervisor.

Jan
Andrew Cooper Sept. 21, 2023, 10:30 a.m. UTC | #4
On 21/09/2023 6:59 am, Jan Beulich wrote:
> On 20.09.2023 21:40, Andrew Cooper wrote:
>> On 19/09/2023 7:50 am, Jan Beulich wrote:
>>> On 19.09.2023 08:30, Javi Merino wrote:
>>>> 5852ca485263 (build: fix tools/configure in case only python3 exists,
>>>> 2019-12-11) changed the configure script to test for the availability
>>>> of python3, python and python2 in that order.  It sets PYTHON to the
>>>> first one found in path.  You don't need to have a symlink to python.
>>>>
>>>> Remove the outdated note from the README.
>>> But that note also covers the hypervisor build, which isn't affected by
>>> ./configure, and even less so by tools/configure.
>> The hypervisor build equally doesn't python= specifying.
> I'm pretty sure that on at least one of my systems I need PYTHON=python3
> when building the hypervisor.

Not since c8a8645f1efe you haven't.

~Andrew
diff mbox series

Patch

diff --git a/README b/README
index f75fa536d9..a491c8dce5 100644
--- a/README
+++ b/README
@@ -184,13 +184,6 @@  Various tools, such as pygrub, have the following runtime dependencies:
           URL:    https://www.python.org/
           Debian: python
 
-Note that the build system expects `python` to be available. If your system
-only has `python2` or `python3` but not `python` (as in Linux From Scratch),
-you will need to create a symlink for it, or specify PYTHON= when invoking
-make, like (note the position of PYTHON= matters):
-
-    # make PYTHON=/usr/bin/python3
-
 Intel(R) Trusted Execution Technology Support
 =============================================