| Message ID | 8536f54b708a1b3a906d14a63958c2e6dd0d034e.1691427640.git.federico.serafini@bugseng.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [XEN] x86/cpu: Address a violation of MISRA C:2012 Rule 8.3 | expand |
On 07.08.2023 19:02, Federico Serafini wrote: > A missing change to the type in 'opt_arat' declaration introduced a new > violation of MISRA C:2012 Rule 8.3 ("All declarations of an object or > function shall use the same names and type qualifiers"). > Change the type to restore the consistency between all declarations of > the object and drop a further usage of 'bool_t'. > > Fixes: 202a341f ("x86: Address violations of MISRA C:2012 by replacing bool_t uses") > Reported-by: Andrew Cooper <andrew.cooper3@citrix.com> > Signed-off-by: Federico Serafini <federico.serafini@bugseng.com> Acked-by: Jan Beulich <jbeulich@suse.com>
diff --git a/xen/arch/x86/cpu/cpu.h b/xen/arch/x86/cpu/cpu.h index 85a67771f7..e3d06278b3 100644 --- a/xen/arch/x86/cpu/cpu.h +++ b/xen/arch/x86/cpu/cpu.h @@ -7,7 +7,7 @@ struct cpu_dev { extern const struct cpu_dev intel_cpu_dev, amd_cpu_dev, centaur_cpu_dev, shanghai_cpu_dev, hygon_cpu_dev; -extern bool_t opt_arat; +extern bool opt_arat; extern unsigned int opt_cpuid_mask_ecx, opt_cpuid_mask_edx; extern unsigned int opt_cpuid_mask_xsave_eax; extern unsigned int opt_cpuid_mask_ext_ecx, opt_cpuid_mask_ext_edx;
A missing change to the type in 'opt_arat' declaration introduced a new violation of MISRA C:2012 Rule 8.3 ("All declarations of an object or function shall use the same names and type qualifiers"). Change the type to restore the consistency between all declarations of the object and drop a further usage of 'bool_t'. Fixes: 202a341f ("x86: Address violations of MISRA C:2012 by replacing bool_t uses") Reported-by: Andrew Cooper <andrew.cooper3@citrix.com> Signed-off-by: Federico Serafini <federico.serafini@bugseng.com> --- xen/arch/x86/cpu/cpu.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)