diff mbox series

[2/3] xen/ballon: Avoid calling dummy function __online_page_set_limits()

Message ID 854db2cf8145d9635249c95584d9a91fd774a229.1567889743.git.jrdr.linux@gmail.com (mailing list archive)
State New, archived
Headers show
Series Remove __online_page_set_limits() | expand

Commit Message

Souptick Joarder Sept. 7, 2019, 9:47 p.m. UTC 
__online_page_set_limits() is a dummy function and an extra call
to this function can be avoided.

Signed-off-by: Souptick Joarder <jrdr.linux@gmail.com>
---
 drivers/xen/balloon.c | 1 -
 1 file changed, 1 deletion(-)

Comments

Jürgen Groß Sept. 8, 2019, 5:09 a.m. UTC | #1 
On 07.09.19 23:47, Souptick Joarder wrote:
> __online_page_set_limits() is a dummy function and an extra call
> to this function can be avoided.
> 
> Signed-off-by: Souptick Joarder <jrdr.linux@gmail.com>

Reviewed-by: Juergen Gross <jgross@suse.com>


Juergen
David Hildenbrand Sept. 9, 2019, 7:54 a.m. UTC | #2 
On 07.09.19 23:47, Souptick Joarder wrote:
> __online_page_set_limits() is a dummy function and an extra call
> to this function can be avoided.
> 
> Signed-off-by: Souptick Joarder <jrdr.linux@gmail.com>
> ---
>  drivers/xen/balloon.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/xen/balloon.c b/drivers/xen/balloon.c
> index 4e11de6..05b1f7e 100644
> --- a/drivers/xen/balloon.c
> +++ b/drivers/xen/balloon.c
> @@ -376,7 +376,6 @@ static void xen_online_page(struct page *page, unsigned int order)
>  	mutex_lock(&balloon_mutex);
>  	for (i = 0; i < size; i++) {
>  		p = pfn_to_page(start_pfn + i);
> -		__online_page_set_limits(p);
>  		__SetPageOffline(p);
>  		__balloon_append(p);
>  	}
> 

Reviewed-by: David Hildenbrand <david@redhat.com>
diff mbox series

Patch

diff --git a/drivers/xen/balloon.c b/drivers/xen/balloon.c
index 4e11de6..05b1f7e 100644
--- a/drivers/xen/balloon.c
+++ b/drivers/xen/balloon.c
@@ -376,7 +376,6 @@  static void xen_online_page(struct page *page, unsigned int order)
 	mutex_lock(&balloon_mutex);
 	for (i = 0; i < size; i++) {
 		p = pfn_to_page(start_pfn + i);
-		__online_page_set_limits(p);
 		__SetPageOffline(p);
 		__balloon_append(p);
 	}