diff mbox series

[v2,04/15] xen/asm-generic: introduce generic hypercall.h

Message ID 87a6f7a2135361ad231bfc0cfc2d73ca78c357a3.1699633310.git.oleksii.kurochko@gmail.com (mailing list archive)
State Superseded
Headers show
Series Introduce generic headers | expand

Commit Message

Oleksii Nov. 10, 2023, 4:30 p.m. UTC 
Introduce an empty generic hypercall.h for archs which don't
implement it.

Signed-off-by: Oleksii Kurochko <oleksii.kurochko@gmail.com>
---
Changes in V2:
 - add check that <asm/hypercall.h> isn't included directly.
---
 xen/include/asm-generic/hypercall.h | 18 ++++++++++++++++++
 1 file changed, 18 insertions(+)
 create mode 100644 xen/include/asm-generic/hypercall.h

Comments

Jan Beulich Nov. 13, 2023, 4:45 p.m. UTC | #1 
On 10.11.2023 17:30, Oleksii Kurochko wrote:
> Introduce an empty generic hypercall.h for archs which don't
> implement it.
> 
> Signed-off-by: Oleksii Kurochko <oleksii.kurochko@gmail.com>

Since - judging from Arm's present header - it looks technically possible
for an arch to get away with this:
Acked-by: Jan Beulich <jbeulich@suse.com>

Jan
Jan Beulich Nov. 13, 2023, 4:50 p.m. UTC | #2 
On 13.11.2023 17:45, Jan Beulich wrote:
> On 10.11.2023 17:30, Oleksii Kurochko wrote:
>> Introduce an empty generic hypercall.h for archs which don't
>> implement it.
>>
>> Signed-off-by: Oleksii Kurochko <oleksii.kurochko@gmail.com>
> 
> Since - judging from Arm's present header - it looks technically possible
> for an arch to get away with this:
> Acked-by: Jan Beulich <jbeulich@suse.com>

Actually - why does this patch not drop PPC's now redundant header right
away, along the lines of what you do in patch 1? This is also why I
refrained from offering A-b on patch 5.

Jan
Oleksii Nov. 14, 2023, 10:13 a.m. UTC | #3 
On Mon, 2023-11-13 at 17:50 +0100, Jan Beulich wrote:
> On 13.11.2023 17:45, Jan Beulich wrote:
> > On 10.11.2023 17:30, Oleksii Kurochko wrote:
> > > Introduce an empty generic hypercall.h for archs which don't
> > > implement it.
> > > 
> > > Signed-off-by: Oleksii Kurochko <oleksii.kurochko@gmail.com>
> > 
> > Since - judging from Arm's present header - it looks technically
> > possible
> > for an arch to get away with this:
> > Acked-by: Jan Beulich <jbeulich@suse.com>
> 
> Actually - why does this patch not drop PPC's now redundant header
> right
> away, along the lines of what you do in patch 1? This is also why I
> refrained from offering A-b on patch 5.
Missed that. I'll send a new patch series with dropped PPC's redundant
header.

Thanks.

~ Oleksii
diff mbox series

Patch

diff --git a/xen/include/asm-generic/hypercall.h b/xen/include/asm-generic/hypercall.h
new file mode 100644
index 0000000000..7743b35c0d
--- /dev/null
+++ b/xen/include/asm-generic/hypercall.h
@@ -0,0 +1,18 @@ 
+/* SPDX-License-Identifier: GPL-2.0-only */
+#ifndef __XEN_HYPERCALL_H__
+#error "asm/hypercall.h should not be included directly - include xen/hypercall.h instead"
+#endif
+
+#ifndef __ASM_GENERIC_HYPERCALL_H__
+#define __ASM_GENERIC_HYPERCALL_H__
+
+#endif /* __ASM_GENERIC_HYPERCALL_H__ */
+
+/*
+ * Local variables:
+ * mode: C
+ * c-file-style: "BSD"
+ * c-basic-offset: 4
+ * indent-tabs-mode: nil
+ * End:
+ */