Message ID | 87lgqb74fp.fsf@vitty.brq.redhat.com (mailing list archive) |
---|---|
State | New, archived |
Headers | show
Return-Path: <xen-devel-bounces@lists.xen.org> Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 638EB60362 for <patchwork-xen-devel@patchwork.kernel.org>; Fri, 5 May 2017 14:42:41 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 666A628678 for <patchwork-xen-devel@patchwork.kernel.org>; Fri, 5 May 2017 14:42:41 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 5978C286A0; Fri, 5 May 2017 14:42:41 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=2.0 tests=BAYES_00, RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 7467028697 for <patchwork-xen-devel@patchwork.kernel.org>; Fri, 5 May 2017 14:42:39 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from <xen-devel-bounces@lists.xen.org>) id 1d6eP2-000845-K9; Fri, 05 May 2017 14:40:16 +0000 Received: from mail6.bemta6.messagelabs.com ([193.109.254.103]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from <vkuznets@redhat.com>) id 1d6eP2-00083z-1Y for xen-devel@lists.xenproject.org; Fri, 05 May 2017 14:40:16 +0000 Received: from [193.109.254.147] by server-6.bemta-6.messagelabs.com id DA/9D-03920-FCE8C095; Fri, 05 May 2017 14:40:15 +0000 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrDIsWRWlGSWpSXmKPExsVysWW7jO65Pp5 Ig4/vDS2+b5nM5MDocfjDFZYAxijWzLyk/IoE1ow1a7axFPwTrLgxvYW5gfE9XxcjF4eQwGwm iYk3tzN2MXJysAjYSxy/+5cZxGYUKJPYteEclJ0rcebwTzaIGjuJTcca2SCatzNKPPo9kQUkw SagI/H96SmwBhEBNYmJJyYwgxQxC3QySpxru8IEkhAWSJCY8vow0DYOoO4iiXkfQkFMFgFVif YXDiDlnAJdjBIPJh0FO4hXwFBi1c4DYItFBSwlZh+8DRUXlDg58wnYXmYBCYmDL16A7ZUQ0JZ 4fHo6I8ggCYE+Romeu98ZJzAKz0LSMwtJzwJGplWMGsWpRWWpRbqGRnpJRZnpGSW5iZk5uoYG Znq5qcXFiempOYlJxXrJ+bmbGIEhzQAEOxgvbww4xCjJwaQkypsmyhMpxJeUn1KZkVicEV9Um pNafIhRhoNDSYKXBRgjQoJFqempFWmZOcDogklLcPAoifBO7AVK8xYXJOYWZ6ZDpE4x6nK8W/ rhPZMQS15+XqqUOK81yAwBkKKM0jy4EbBIv8QoKyXMywh0lBBPQWpRbmYJqvwrRnEORiVhXim QKTyZeSVwm14BHcEEdES0KNgRJYkIKakGxsIHz5Vnt/VfXWEXd+mmrYdXl1mg+8u0jhmnjncV mC1aJXNm6ox/z3evlLbzD1zjZ7opMS16TsG6HQ65044UMOfvsNnfJvjV9m3SlY0T15zg+M/Ad Gtee8j+oubXD08e9LHdHtlyvcesJctP3v/Ps/dfs2LerptlJPa6Y+8nf6UpG99uLzyYuUCJpT gj0VCLuag4EQDNZq1o7wIAAA== X-Env-Sender: vkuznets@redhat.com X-Msg-Ref: server-15.tower-27.messagelabs.com!1493995213!47754600!1 X-Originating-IP: [209.132.183.28] X-SpamReason: No, hits=0.0 required=7.0 tests=sa_preprocessor: VHJ1c3RlZCBJUDogMjA5LjEzMi4xODMuMjggPT4gNTQwNjQ=\n X-StarScan-Received: X-StarScan-Version: 9.4.12; banners=-,-,- X-VirusChecked: Checked Received: (qmail 36297 invoked from network); 5 May 2017 14:40:14 -0000 Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by server-15.tower-27.messagelabs.com with DHE-RSA-AES256-GCM-SHA384 encrypted SMTP; 5 May 2017 14:40:14 -0000 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id D4B874E4C5; Fri, 5 May 2017 14:40:12 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com D4B874E4C5 DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com D4B874E4C5 Received: from vitty.brq.redhat.com.redhat.com (vitty.brq.redhat.com [10.34.26.3]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 65FAD1841D; Fri, 5 May 2017 14:40:11 +0000 (UTC) From: Vitaly Kuznetsov <vkuznets@redhat.com> To: David Miller <davem@davemloft.net> References: <20170504122304.11735-1-vkuznets@redhat.com> <20170504.112150.391662736580694835.davem@davemloft.net> Date: Fri, 05 May 2017 16:40:10 +0200 In-Reply-To: <20170504.112150.391662736580694835.davem@davemloft.net> (David Miller's message of "Thu, 04 May 2017 11:21:50 -0400 (EDT)") Message-ID: <87lgqb74fp.fsf@vitty.brq.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.38]); Fri, 05 May 2017 14:40:13 +0000 (UTC) Cc: jgross@suse.com, xen-devel@lists.xenproject.org, boris.ostrovsky@oracle.com, linux-kernel@vger.kernel.org, netdev@vger.kernel.org Subject: Re: [Xen-devel] [PATCH] xen-netfront: avoid crashing on resume after a failure in talk_to_netback() X-BeenThere: xen-devel@lists.xen.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Xen developer discussion <xen-devel.lists.xen.org> List-Unsubscribe: <https://lists.xen.org/cgi-bin/mailman/options/xen-devel>, <mailto:xen-devel-request@lists.xen.org?subject=unsubscribe> List-Post: <mailto:xen-devel@lists.xen.org> List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help> List-Subscribe: <https://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xen.org?subject=subscribe> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" <xen-devel-bounces@lists.xen.org> X-Virus-Scanned: ClamAV using ClamSMTP |
diff --git a/drivers/net/xen-netfront.c b/drivers/net/xen-netfront.c index 6ffc482..7b61adb 100644 --- a/drivers/net/xen-netfront.c +++ b/drivers/net/xen-netfront.c @@ -1934,8 +1934,7 @@ static int talk_to_netback(struct xenbus_device *dev, xennet_disconnect_backend(info); xennet_destroy_queues(info); out: - unregister_netdev(info->netdev); - xennet_free_netdev(info->netdev); + device_unregister(&dev->dev); return err; }