| Message ID | 88bab81d8412588dab82bb53193105ff4993961a.1700761381.git.oleksii.kurochko@gmail.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | Enable build of full Xen for RISC-V | expand |
On 24.11.2023 11:30, Oleksii Kurochko wrote: > Signed-off-by: Oleksii Kurochko <oleksii.kurochko@gmail.com> With an empty description it is hard to judge whether this is really needed. I would sincerely hope we can get away without. Note how there already a few struct xen_domctl_* forward declarations there, which - if the #include really needs adding - should be dropped in exchange. As a nit on the subject - it's only singular (now?) and could hence do with being more precise on what the specific change is. Jan > --- a/xen/include/xen/domain.h > +++ b/xen/include/xen/domain.h > @@ -4,6 +4,7 @@ > > #include <xen/types.h> > > +#include <public/domctl.h> > #include <public/xen.h> > > struct guest_area {
On Thu, 2023-12-14 at 17:20 +0100, Jan Beulich wrote: > On 24.11.2023 11:30, Oleksii Kurochko wrote: > > Signed-off-by: Oleksii Kurochko <oleksii.kurochko@gmail.com> > > With an empty description it is hard to judge whether this is really > needed. > I would sincerely hope we can get away without. Note how there > already a few > struct xen_domctl_* forward declarations there, which - if the > #include > really needs adding - should be dropped in exchange. > > As a nit on the subject - it's only singular (now?) and could hence > do with > being more precise on what the specific change is. It will be another one reminder for me to write proper commit messages as I don't remember what was an issue. I double checked what was the issue and it seems that this change isn't needed any more... So I'll drop this patch. ~ Oleksii > > Jan > > > --- a/xen/include/xen/domain.h > > +++ b/xen/include/xen/domain.h > > @@ -4,6 +4,7 @@ > > > > #include <xen/types.h> > > > > +#include <public/domctl.h> > > #include <public/xen.h> > > > > struct guest_area { >
diff --git a/xen/include/xen/domain.h b/xen/include/xen/domain.h index 54d88bf5e3..a4e11342e3 100644 --- a/xen/include/xen/domain.h +++ b/xen/include/xen/domain.h @@ -4,6 +4,7 @@ #include <xen/types.h> +#include <public/domctl.h> #include <public/xen.h> struct guest_area {
Signed-off-by: Oleksii Kurochko <oleksii.kurochko@gmail.com> --- Changes in V2: - Nothing changed. Only rebase. --- xen/include/xen/domain.h | 1 + 1 file changed, 1 insertion(+)