| Message ID | 8e7762db94449c18e88171658c758a227e1fae9b.1698829473.git.nicola.vetrini@bugseng.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Fix or deviate various instances of missing declarations | expand |
On Wed, 1 Nov 2023, Nicola Vetrini wrote: > To avoid a violation of MISRA C:2012 Rule 8.4, as permitted > by docs/misra/rules.rst. > > The current_stack_pointer is a declaration: mark it as such > for ECLAIR. > > Signed-off-by: Nicola Vetrini <nicola.vetrini@bugseng.com> Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>
On 02.11.2023 00:12, Stefano Stabellini wrote: > On Wed, 1 Nov 2023, Nicola Vetrini wrote: >> To avoid a violation of MISRA C:2012 Rule 8.4, as permitted >> by docs/misra/rules.rst. >> >> The current_stack_pointer is a declaration: mark it as such >> for ECLAIR. >> >> Signed-off-by: Nicola Vetrini <nicola.vetrini@bugseng.com> > > Reviewed-by: Stefano Stabellini <sstabellini@kernel.org> Acked-by: Jan Beulich <jbeulich@suse.com>
diff --git a/xen/arch/x86/setup.c b/xen/arch/x86/setup.c index a3d3f797bb1e..d70ad1e44a60 100644 --- a/xen/arch/x86/setup.c +++ b/xen/arch/x86/setup.c @@ -75,7 +75,8 @@ static bool __initdata opt_invpcid = true; boolean_param("invpcid", opt_invpcid); bool __read_mostly use_invpcid; -unsigned long __read_mostly cr4_pv32_mask; +/* Only used in asm code and within this source file */ +unsigned long asmlinkage __read_mostly cr4_pv32_mask; /* **** Linux config option: propagated to domain0. */ /* "acpi=off": Sisables both ACPI table parsing and interpreter. */ @@ -146,14 +147,15 @@ cpumask_t __read_mostly cpu_present_map; unsigned long __read_mostly xen_phys_start; -char __section(".init.bss.stack_aligned") __aligned(STACK_SIZE) +/* Only used in asm code and within this source file */ +char asmlinkage __section(".init.bss.stack_aligned") __aligned(STACK_SIZE) cpu0_stack[STACK_SIZE]; /* Used by the BSP/AP paths to find the higher half stack mapping to use. */ void *stack_start = cpu0_stack + STACK_SIZE - sizeof(struct cpu_info); /* Used by the boot asm to stash the relocated multiboot info pointer. */ -unsigned int __initdata multiboot_ptr; +unsigned int asmlinkage __initdata multiboot_ptr; struct cpuinfo_x86 __read_mostly boot_cpu_data = { 0, 0, 0, 0, -1 };
To avoid a violation of MISRA C:2012 Rule 8.4, as permitted by docs/misra/rules.rst. The current_stack_pointer is a declaration: mark it as such for ECLAIR. Signed-off-by: Nicola Vetrini <nicola.vetrini@bugseng.com> --- Changes in v3: - Edited commit message - Add two new variables Changes in v5: - Mark current_stack_pointer as a declaration. - Use asmlinkage instead of SAF. Changes in v6: - moved asmlinkage after the type --- xen/arch/x86/setup.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-)