x86/monitor: don't open-code hvm_has_set_descriptor_access_exiting()

Commit Message

Jan Beulich Nov. 30, 2021, 4:11 p.m. UTC

Signed-off-by: Jan Beulich <[e-mail]>

Comments

Andrew Cooper Nov. 30, 2021, 4:34 p.m. UTC | #1

On 30/11/2021 16:11, Jan Beulich wrote:
> Signed-off-by: Jan Beulich <[e-mail]>

Acked-by: Andrew Cooper <[e-mail]>

Jan Beulich Dec. 9, 2021, 8:53 a.m. UTC | #2

On 30.11.2021 17:11, Jan Beulich wrote:
> Signed-off-by: Jan Beulich <[e-mail]>

May I ask for an ack (or otherwise) here please?

Thanks, Jan

> --- a/xen/arch/x86/monitor.c
> +++ b/xen/arch/x86/monitor.c
> @@ -263,7 +263,7 @@ int arch_monitor_domctl_event(struct dom
>          if ( unlikely(old_status == requested_status) )
>              return -EEXIST;
>  
> -        if ( !hvm_funcs.set_descriptor_access_exiting )
> +        if ( !hvm_has_set_descriptor_access_exiting() )
>              return -EOPNOTSUPP;
>  
>          domain_pause(d);
>

Alexandru Stefan ISAILA Dec. 9, 2021, 9:09 a.m. UTC | #3

> On 30 Nov 2021, at 18:11, Jan Beulich <[e-mail]> wrote:
> 
> CAUTION: This email originated from outside of our organization. Do not click links or open attachments unless you recognize the sender and know the content is safe.
> 
> Signed-off-by: Jan Beulich <[e-mail]>
Reviewed by: Alexandru Isaila <[e-mail]>
> 
> --- a/xen/arch/x86/monitor.c
> +++ b/xen/arch/x86/monitor.c
> @@ -263,7 +263,7 @@ int arch_monitor_domctl_event(struct dom
>         if ( unlikely(old_status == requested_status) )
>             return -EEXIST;
> 
> -        if ( !hvm_funcs.set_descriptor_access_exiting )
> +        if ( !hvm_has_set_descriptor_access_exiting() )
>             return -EOPNOTSUPP;
> 
>         domain_pause(d);
>

Patch

--- a/xen/arch/x86/monitor.c
+++ b/xen/arch/x86/monitor.c
@@ -263,7 +263,7 @@  int arch_monitor_domctl_event(struct dom
         if ( unlikely(old_status == requested_status) )
             return -EEXIST;
 
-        if ( !hvm_funcs.set_descriptor_access_exiting )
+        if ( !hvm_has_set_descriptor_access_exiting() )
             return -EOPNOTSUPP;
 
         domain_pause(d);