| Message ID | 92e5df23-0bdf-42d4-9ab0-c668110174f0@suse.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | x86/platform: correct #undef in compat checking | expand |
On Mon, May 06, 2024 at 11:06:07AM +0200, Jan Beulich wrote: > A stray 'p' was there, rendering the #undef ineffectual. > > Signed-off-by: Jan Beulich <jbeulich@suse.com> Acked-by: Roger Pau Monné <roger.pau@citrix.com> No Fixes tag? Thanks, Roger.
On 06.05.2024 11:22, Roger Pau Monné wrote: > On Mon, May 06, 2024 at 11:06:07AM +0200, Jan Beulich wrote: >> A stray 'p' was there, rendering the #undef ineffectual. >> >> Signed-off-by: Jan Beulich <jbeulich@suse.com> > > Acked-by: Roger Pau Monné <roger.pau@citrix.com> Thanks. > No Fixes tag? I didn't think it was worthwhile digging out the offending commit, as there's no real bug here. Assuming that a colliding identifier might be introduced elsewhere seems pretty far fetched to me. And Misra, which might have something to say here, would want us to avoid #undef altogether, iirc. Jan
--- a/xen/arch/x86/x86_64/platform_hypercall.c +++ b/xen/arch/x86/x86_64/platform_hypercall.c @@ -30,7 +30,7 @@ CHECK_pf_pcpu_version; #define xen_pf_ucode_revision xenpf_ucode_revision CHECK_pf_ucode_revision; -#undef xen_pf_pucode_revision +#undef xen_pf_ucode_revision #define xen_pf_enter_acpi_sleep xenpf_enter_acpi_sleep CHECK_pf_enter_acpi_sleep;
A stray 'p' was there, rendering the #undef ineffectual. Signed-off-by: Jan Beulich <jbeulich@suse.com>