From patchwork Thu Jun 8 12:42:26 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Paul Durrant X-Patchwork-Id: 9774597 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 804F06034B for ; Thu, 8 Jun 2017 12:44:40 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 71FDC284D2 for ; Thu, 8 Jun 2017 12:44:40 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 672402854A; Thu, 8 Jun 2017 12:44:40 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=2.0 tests=BAYES_00, RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id C302C284D2 for ; Thu, 8 Jun 2017 12:44:39 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dIwlj-0006Xh-6P; Thu, 08 Jun 2017 12:42:31 +0000 Received: from mail6.bemta6.messagelabs.com ([193.109.254.103]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dIwlh-0006XW-OG for xen-devel@lists.xenproject.org; Thu, 08 Jun 2017 12:42:29 +0000 Received: from [193.109.254.147] by server-6.bemta-6.messagelabs.com id 36/2C-03920-53649395; Thu, 08 Jun 2017 12:42:29 +0000 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrAIsWRWlGSWpSXmKPExsWyU9JRQtfEzTL S4PJVGYvvWyYzOTB6HP5whSWAMYo1My8pvyKBNeP6yyNMBa2cFZ+vHmBsYPzE1sXIySEh4CfR vHYKM4jNJqAjsfTofCYQW0RAVWLRofWsXYxcHMwC/UwSUxs2sIIkhAVcJP4fWswGUeQq8e10F yOEvYpRYtYshS5GDg4WARWJdRuDQMK8Au4Se5+sZAeZIyTwgENif+tSRpAaTgF7iS8/0kBqGA VkJb40rga7gVlAXOLWE4gbJAQEJJbsOc8MYYtKvHz8jxXCNpDYunQfC0S9jsSC3RC/MAtoSyx b+JoZYq+gxMmZT1gmMArPQjJ2FpKWWUhaZiFpWcDIsopRvTi1qCy1SNdYL6koMz2jJDcxM0fX 0MBMLze1uDgxPTUnMalYLzk/dxMjMPQZgGAHY8c/p0OMkhxMSqK8igKWkUJ8SfkplRmJxRnxR aU5qcWHGDU4OAQ2r119gVGKJS8/L1VJgpfZFahOsCg1PbUiLTMHGJ0wpRIcPEoivPpOQGne4o LE3OLMdIjUKUZFKXFeW5A+AZBERmkeXBssIVxilJUS5mUEOkqIpyC1KDezBFX+FaM4B6OSMG+ aM9AUnsy8Erjpr4AWMwEtXvLOAmRxSSJCSqqBMd7Jvj7mcaJ7xNEpi4PivWQVT7Tek3N6ya1w co2a9FSFk33c4WLLbrp6M8RXpmw/riJZNEXdP1H6ToltR8X2iqSoS4F/tq75k3in59Hz7UoT2 fg5VOebv5gWLbyc+dRPjWufl7WU7XJxdXvYeSNcv3NLXsaM4xskZD6dmJvHPnPuncOlR7lmKr EUZyQaajEXFScCAAgkENcDAwAA X-Env-Sender: prvs=3256debce=Paul.Durrant@citrix.com X-Msg-Ref: server-16.tower-27.messagelabs.com!1496925748!106376853!1 X-Originating-IP: [185.25.65.24] X-SpamReason: No, hits=0.0 required=7.0 tests=received_headers: No Received headers X-StarScan-Received: X-StarScan-Version: 9.4.19; banners=-,-,- X-VirusChecked: Checked Received: (qmail 8695 invoked from network); 8 Jun 2017 12:42:28 -0000 Received: from smtp.ctxuk.citrix.com (HELO SMTP.EU.CITRIX.COM) (185.25.65.24) by server-16.tower-27.messagelabs.com with RC4-SHA encrypted SMTP; 8 Jun 2017 12:42:28 -0000 X-IronPort-AV: E=Sophos;i="5.39,315,1493683200"; d="scan'208";a="47431234" From: Paul Durrant To: 'Jan Beulich' Thread-Topic: [Xen-devel] debian stretch dom0 + xen 4.9 fails to boot Thread-Index: AdLe0KoM3kANRDRYSf+PCIgyxC4kg///62kA///UqkD//530gIAAq+WA//7hiaAASaM11////+MQgAAfuwCAAAbUMIAAGXcAgAAQOnCAAEA9AIAAVefggADG/ACAAUkj0IACqxgAgAUy+oCACoPQgIATiwnQ Date: Thu, 8 Jun 2017 12:42:26 +0000 Message-ID: <94bf1caf8b95436fa7b3aed74a172ce1@AMSPEX02CL03.citrite.net> References: <5936E230020000780015FEDC@prv-mh.provo.novell.com> <3a0eb227-8302-50db-84a6-b07893ab0e91@oracle.com> <5937D4FF02000078001602F6@suse.com> <0e704f5e-5845-dc56-6058-d0451d43d842@citrix.com> <2baad09e48864a06873037240b8e39dd@AMSPEX02CL03.citrite.net> <5938048A02000078001604AE@prv-mh.provo.novell.com> <056e566f141c4715867e2bdbbe418977@AMSPEX02CL03.citrite.net> <593806FC02000078001604D1@prv-mh.provo.novell.com> <593813E602000078001605F7@prv-mh.provo.novell.com> <593838D20200007800160859@prv-mh.provo.novell.com> <59383D4F020000780016089F@prv-mh.provo.novell.com> In-Reply-To: <59383D4F020000780016089F@prv-mh.provo.novell.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-transport-fromentityheader: Hosted MIME-Version: 1.0 Cc: Juergen Gross , Andrew Cooper , "Julien Grall \(julien.grall@arm.com\)" , 'BorisOstrovsky' , "xen-devel\(xen-devel@lists.xenproject.org\)" Subject: Re: [Xen-devel] debian stretch dom0 + xen 4.9 fails to boot X-BeenThere: xen-devel@lists.xen.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" X-Virus-Scanned: ClamAV using ClamSMTP For those following this... By poking characters at the screen and bisecting where they stopped, I have narrowed the problem to the code in edd.S. I can successfully boot by setting opt_edd=off on the Xen cmd line and I can also boot with the following patch applied: (based on a hunch that the BIOS defaults to a 4K sector for my NVMe drive) I need to investigate some more but I do wonder whether the EDD info should be read first to determine the appropriate size of memory buffer to use when issuing the read of the MBR. Hardcoding a 4k reservation seems like the wrong thing to do, even if it is sufficient for this BIOS. Paul diff --git a/xen/arch/x86/boot/edd.S b/xen/arch/x86/boot/edd.S index 73371f98b5..5409f1d9a1 100644 --- a/xen/arch/x86/boot/edd.S +++ b/xen/arch/x86/boot/edd.S @@ -148,5 +148,6 @@ GLOBAL(boot_mbr_signature_nr) .byte 0 GLOBAL(boot_mbr_signature) .fill EDD_MBR_SIG_MAX*8,1,0 + .align 4096 GLOBAL(boot_edd_info) - .fill 512,1,0 # big enough for a disc sector + .fill 4096,1,0 # big enough for a disc sector