Message ID | 95467f2c-09ed-d34f-feef-5cd55c60f628@suse.com (mailing list archive) |
---|---|
State | New, archived |
Headers | show |
Series | build: shorten macro references | expand |
On 04/05/2023 5:16 pm, Jan Beulich wrote: > Presumably by copy-and-paste we've accumulated a number of instances of > $(@D)/$(@F), which really is nothing else than $@. The split form only > needs using when we want to e.g. insert a leading . at the beginning of > the file name portion of the full name. From the Kbuild work, we have $(dot-target) now which is marginally more legible than $(@D)/.$(@F), and we ought to use it consistently. > Signed-off-by: Jan Beulich <jbeulich@suse.com> Acked-by: Andrew Cooper <andrew.cooper3@citrix.com>, although ... > > --- a/xen/arch/arm/Makefile > +++ b/xen/arch/arm/Makefile > @@ -104,9 +104,9 @@ $(TARGET)-syms: $(objtree)/prelink.o $(o > $(MAKE) $(build)=$(@D) $(@D)/.$(@F).1.o > $(LD) $(XEN_LDFLAGS) -T $(obj)/xen.lds -N $< $(build_id_linker) \ > $(@D)/.$(@F).1.o -o $@ > - $(NM) -pa --format=sysv $(@D)/$(@F) \ > + $(NM) -pa --format=sysv $@ \ > | $(objtree)/tools/symbols --all-symbols --xensyms --sysv --sort \ > - >$(@D)/$(@F).map > + >$@.map ... any chance we can get a space between > and $ like we do almost everywhere else? ~Andrew
On 04.05.2023 19:24, Andrew Cooper wrote: > On 04/05/2023 5:16 pm, Jan Beulich wrote: >> Presumably by copy-and-paste we've accumulated a number of instances of >> $(@D)/$(@F), which really is nothing else than $@. The split form only >> needs using when we want to e.g. insert a leading . at the beginning of >> the file name portion of the full name. > > From the Kbuild work, we have $(dot-target) now which is marginally more > legible than $(@D)/.$(@F), and we ought to use it consistently. Oh, right - let me make yet another patch on top. >> Signed-off-by: Jan Beulich <jbeulich@suse.com> > > Acked-by: Andrew Cooper <andrew.cooper3@citrix.com>, although ... Thanks. >> --- a/xen/arch/arm/Makefile >> +++ b/xen/arch/arm/Makefile >> @@ -104,9 +104,9 @@ $(TARGET)-syms: $(objtree)/prelink.o $(o >> $(MAKE) $(build)=$(@D) $(@D)/.$(@F).1.o >> $(LD) $(XEN_LDFLAGS) -T $(obj)/xen.lds -N $< $(build_id_linker) \ >> $(@D)/.$(@F).1.o -o $@ >> - $(NM) -pa --format=sysv $(@D)/$(@F) \ >> + $(NM) -pa --format=sysv $@ \ >> | $(objtree)/tools/symbols --all-symbols --xensyms --sysv --sort \ >> - >$(@D)/$(@F).map >> + >$@.map > > ... any chance we can get a space between > and $ like we do almost > everywhere else? Since "almost everywhere else" wasn't quite right for xen/arch/*/Makefile I was first inclined to say no, but I can easily insert blanks when doing the $(dot-target) conversion as well, and then it looks like it'll end up fully consistent (in this one regard). Jan
Hi Jan, > On 4 May 2023, at 18:16, Jan Beulich <jbeulich@suse.com> wrote: > > Presumably by copy-and-paste we've accumulated a number of instances of > $(@D)/$(@F), which really is nothing else than $@. The split form only > needs using when we want to e.g. insert a leading . at the beginning of > the file name portion of the full name. > > Signed-off-by: Jan Beulich <jbeulich@suse.com> Reviewed-by: Bertrand Marquis <bertrand.marquis@arm.com> Cheers Bertrand > > --- a/xen/arch/arm/Makefile > +++ b/xen/arch/arm/Makefile > @@ -104,9 +104,9 @@ $(TARGET)-syms: $(objtree)/prelink.o $(o > $(MAKE) $(build)=$(@D) $(@D)/.$(@F).1.o > $(LD) $(XEN_LDFLAGS) -T $(obj)/xen.lds -N $< $(build_id_linker) \ > $(@D)/.$(@F).1.o -o $@ > - $(NM) -pa --format=sysv $(@D)/$(@F) \ > + $(NM) -pa --format=sysv $@ \ > | $(objtree)/tools/symbols --all-symbols --xensyms --sysv --sort \ > - >$(@D)/$(@F).map > + >$@.map > rm -f $(@D)/.$(@F).[0-9]* > > .PHONY: include > --- a/xen/arch/riscv/Makefile > +++ b/xen/arch/riscv/Makefile > @@ -10,9 +10,9 @@ $(TARGET): $(TARGET)-syms > > $(TARGET)-syms: $(objtree)/prelink.o $(obj)/xen.lds > $(LD) $(XEN_LDFLAGS) -T $(obj)/xen.lds -N $< $(build_id_linker) -o $@ > - $(NM) -pa --format=sysv $(@D)/$(@F) \ > + $(NM) -pa --format=sysv $@ \ > | $(objtree)/tools/symbols --all-symbols --xensyms --sysv --sort \ > - >$(@D)/$(@F).map > + >$@.map > > $(obj)/xen.lds: $(src)/xen.lds.S FORCE > $(call if_changed_dep,cpp_lds_S) > --- a/xen/arch/x86/Makefile > +++ b/xen/arch/x86/Makefile > @@ -150,9 +150,9 @@ $(TARGET)-syms: $(objtree)/prelink.o $(o > $(MAKE) $(build)=$(@D) $(@D)/.$(@F).1.o > $(LD) $(XEN_LDFLAGS) -T $(obj)/xen.lds -N $< $(build_id_linker) \ > $(orphan-handling-y) $(@D)/.$(@F).1.o -o $@ > - $(NM) -pa --format=sysv $(@D)/$(@F) \ > + $(NM) -pa --format=sysv $@ \ > | $(objtree)/tools/symbols --all-symbols --xensyms --sysv --sort \ > - >$(@D)/$(@F).map > + >$@.map > rm -f $(@D)/.$(@F).[0-9]* $(@D)/..$(@F).[0-9]* > ifeq ($(CONFIG_XEN_IBT),y) > $(SHELL) $(srctree)/tools/check-endbr.sh $@ > @@ -224,8 +224,9 @@ endif > $(MAKE) $(build)=$(@D) .$(@F).1r.o .$(@F).1s.o > $(LD) $(call EFI_LDFLAGS,$(VIRT_BASE)) -T $(obj)/efi.lds -N $< \ > $(@D)/.$(@F).1r.o $(@D)/.$(@F).1s.o $(orphan-handling-y) $(note_file_option) -o $@ > - $(NM) -pa --format=sysv $(@D)/$(@F) \ > - | $(objtree)/tools/symbols --all-symbols --xensyms --sysv --sort >$(@D)/$(@F).map > + $(NM) -pa --format=sysv $@ \ > + | $(objtree)/tools/symbols --all-symbols --xensyms --sysv --sort \ > + >$@.map > ifeq ($(CONFIG_DEBUG_INFO),y) > $(if $(filter --strip-debug,$(EFI_LDFLAGS)),:$(space))$(OBJCOPY) -O elf64-x86-64 $@ $@.elf > endif
--- a/xen/arch/arm/Makefile +++ b/xen/arch/arm/Makefile @@ -104,9 +104,9 @@ $(TARGET)-syms: $(objtree)/prelink.o $(o $(MAKE) $(build)=$(@D) $(@D)/.$(@F).1.o $(LD) $(XEN_LDFLAGS) -T $(obj)/xen.lds -N $< $(build_id_linker) \ $(@D)/.$(@F).1.o -o $@ - $(NM) -pa --format=sysv $(@D)/$(@F) \ + $(NM) -pa --format=sysv $@ \ | $(objtree)/tools/symbols --all-symbols --xensyms --sysv --sort \ - >$(@D)/$(@F).map + >$@.map rm -f $(@D)/.$(@F).[0-9]* .PHONY: include --- a/xen/arch/riscv/Makefile +++ b/xen/arch/riscv/Makefile @@ -10,9 +10,9 @@ $(TARGET): $(TARGET)-syms $(TARGET)-syms: $(objtree)/prelink.o $(obj)/xen.lds $(LD) $(XEN_LDFLAGS) -T $(obj)/xen.lds -N $< $(build_id_linker) -o $@ - $(NM) -pa --format=sysv $(@D)/$(@F) \ + $(NM) -pa --format=sysv $@ \ | $(objtree)/tools/symbols --all-symbols --xensyms --sysv --sort \ - >$(@D)/$(@F).map + >$@.map $(obj)/xen.lds: $(src)/xen.lds.S FORCE $(call if_changed_dep,cpp_lds_S) --- a/xen/arch/x86/Makefile +++ b/xen/arch/x86/Makefile @@ -150,9 +150,9 @@ $(TARGET)-syms: $(objtree)/prelink.o $(o $(MAKE) $(build)=$(@D) $(@D)/.$(@F).1.o $(LD) $(XEN_LDFLAGS) -T $(obj)/xen.lds -N $< $(build_id_linker) \ $(orphan-handling-y) $(@D)/.$(@F).1.o -o $@ - $(NM) -pa --format=sysv $(@D)/$(@F) \ + $(NM) -pa --format=sysv $@ \ | $(objtree)/tools/symbols --all-symbols --xensyms --sysv --sort \ - >$(@D)/$(@F).map + >$@.map rm -f $(@D)/.$(@F).[0-9]* $(@D)/..$(@F).[0-9]* ifeq ($(CONFIG_XEN_IBT),y) $(SHELL) $(srctree)/tools/check-endbr.sh $@ @@ -224,8 +224,9 @@ endif $(MAKE) $(build)=$(@D) .$(@F).1r.o .$(@F).1s.o $(LD) $(call EFI_LDFLAGS,$(VIRT_BASE)) -T $(obj)/efi.lds -N $< \ $(@D)/.$(@F).1r.o $(@D)/.$(@F).1s.o $(orphan-handling-y) $(note_file_option) -o $@ - $(NM) -pa --format=sysv $(@D)/$(@F) \ - | $(objtree)/tools/symbols --all-symbols --xensyms --sysv --sort >$(@D)/$(@F).map + $(NM) -pa --format=sysv $@ \ + | $(objtree)/tools/symbols --all-symbols --xensyms --sysv --sort \ + >$@.map ifeq ($(CONFIG_DEBUG_INFO),y) $(if $(filter --strip-debug,$(EFI_LDFLAGS)),:$(space))$(OBJCOPY) -O elf64-x86-64 $@ $@.elf endif
Presumably by copy-and-paste we've accumulated a number of instances of $(@D)/$(@F), which really is nothing else than $@. The split form only needs using when we want to e.g. insert a leading . at the beginning of the file name portion of the full name. Signed-off-by: Jan Beulich <jbeulich@suse.com>