| Message ID | 98175f394c2c8078a864071aacef04b8d9e1cb6a.1703066935.git.federico.serafini@bugseng.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | xen/arm: address violations of MISRA C:2012 Rule 16.3 | expand |
Hi, On 20/12/2023 11:03, Federico Serafini wrote: > Add missing break statements to address violations of Rule 16.3 > ("An unconditional `break' statement shall terminate every > switch-clause"). > No functional change. > > Signed-off-by: Federico Serafini <federico.serafini@bugseng.com> Acked-by: Julien Grall <jgrall@amazon.com> Cheers,
diff --git a/xen/arch/arm/guest_walk.c b/xen/arch/arm/guest_walk.c index d99b411f3b..2f7d3a0da7 100644 --- a/xen/arch/arm/guest_walk.c +++ b/xen/arch/arm/guest_walk.c @@ -165,6 +165,8 @@ static bool guest_walk_sd(const struct vcpu *v, *perms |= GV2M_WRITE; if ( !pte.sec.xn ) *perms |= GV2M_EXEC; + + break; } return true; @@ -260,6 +262,7 @@ static bool get_ttbr_and_gran_64bit(uint64_t *ttbr, unsigned int *gran, * fall back to 4K by default. */ *gran = GRANULE_SIZE_INDEX_4K; + break; } /* Use TTBR0 for GVA to IPA translation. */ @@ -291,6 +294,7 @@ static bool get_ttbr_and_gran_64bit(uint64_t *ttbr, unsigned int *gran, * fall back to 4K by default. */ *gran = GRANULE_SIZE_INDEX_4K; + break; } /* Use TTBR1 for GVA to IPA translation. */
Add missing break statements to address violations of Rule 16.3 ("An unconditional `break' statement shall terminate every switch-clause"). No functional change. Signed-off-by: Federico Serafini <federico.serafini@bugseng.com> --- xen/arch/arm/guest_walk.c | 4 ++++ 1 file changed, 4 insertions(+)