From patchwork Wed Mar 29 10:22:16 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jan Beulich X-Patchwork-Id: 13192279 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0DA18C6FD18 for ; Wed, 29 Mar 2023 10:22:38 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.516161.799838 (Exim 4.92) (envelope-from ) id 1phSwi-0001Gq-R5; Wed, 29 Mar 2023 10:22:24 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 516161.799838; Wed, 29 Mar 2023 10:22:24 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1phSwi-0001Gh-Nm; Wed, 29 Mar 2023 10:22:24 +0000 Received: by outflank-mailman (input) for mailman id 516161; Wed, 29 Mar 2023 10:22:24 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1phSwi-0000AN-6m for xen-devel@lists.xenproject.org; Wed, 29 Mar 2023 10:22:24 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on2062f.outbound.protection.outlook.com [2a01:111:f400:7d00::62f]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 9724d3e3-ce1b-11ed-85db-49a42c6b2330; Wed, 29 Mar 2023 12:22:23 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DU2PR04MB8646.eurprd04.prod.outlook.com (2603:10a6:10:2dd::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6222.35; Wed, 29 Mar 2023 10:22:18 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::154e:166d:ec25:531b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::154e:166d:ec25:531b%6]) with mapi id 15.20.6222.033; Wed, 29 Mar 2023 10:22:18 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9724d3e3-ce1b-11ed-85db-49a42c6b2330 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=A5K+KTgbZKxr5BFROl5peoFRwGa2g277T6soGF8cjDZ8Ih+aVFhU2+Xw9zkpbMWCjyz4Et4Q7cpt4LUhzZhFO98zxeKHoUI+twS0MPHwWDU4WHAIa0zEUbb73lvB6Nhn6XZph7aDjfskLFBFTGj3BNC7+XaoM8aq+d7BfJtYIOxFqZqiemAqcXcDgvbrUFezUbNInmeqDGo+ozNEHuIauXl5L/Qec1eaxyvnObtf+Fzv4nF4hc6RggDpbgpXPdVxSONCxzp+ZlODvUF0xRNMu1iMqtwo1jsNwKpwySBDUJDMuJlNpBppqPxYBZRbmrynn/yZUVVEnlJ7NCCM7htFVw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=WP/pn7PcqitYNzksceXHyWQ8WFxxaZJTAXiWHpt903Y=; b=V/xdUZSNQXhLa5UqPESrzT5SwHeZuFrMdCLtGVMj2RDCHAPvfvIEU6UMgeiDG9Td3wRXh/+ywCNJmrzspEE8bNY+CyXAn0ASq35uEwF2+WZbOEGAj9+B8TTN9GvjSSQex1ihp5i/l6O+XMgTsQ8L6VQUEUiTk9iDB1UnLsFqbRI4WZaPj/h3a14vpeHc1ntjC4WU9hPCk0RDhqXBG4cLvpG9oZa1CJaOl9yJ6WmVToa0K7Y15TFhp5Nk5E9AT4V2w0dkOuKSYsrAX1/bP/IVTQMxHUxuvtofOWtaYiKF55GY5rBXSeQuBsrD+RyUiaEltovrhZFCfn92lB2Qd2neBw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=WP/pn7PcqitYNzksceXHyWQ8WFxxaZJTAXiWHpt903Y=; b=xlYISuAgarliBTf5gW9z/Cm+SFyydo25P0pilG8OhtDJFpEZo7q5QvhIz3JiBrDdIFnwinPgwFYdBJl2RLetWEhTzZ18NHZnvV+h7OB8KKFinCWr9jxeYxDRuWYXETfB2DyDX6I4tDbmDtkhBOWq23qiIW0Yor9K/ikGeCjtbIXAXrNPYNkxKlUW5SMenMLnzdaxJ6E+SeXFqupF2z2EGUIWgYzrdg40ulECe0qOnRLakShyof+gpqvSvFqVHy83QeZInmD/aPjNqi4uJwtwpOwVl3L6jnT7eQvEPvRvmoHU+suEXtWYHOwqZNvpsoSGXmUpcMERV31BRvg+D533hw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <9e63c6e5-11cb-9f0e-b33e-0247b17e3785@suse.com> Date: Wed, 29 Mar 2023 12:22:16 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: [PATCH v2 1/2] build: don't export building_out_of_srctree Content-Language: en-US From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , Anthony Perard , =?utf-8?q?Roger_Pau_Monn=C3=A9?= References: <2e3c8f9d-8007-638a-c88b-21ad2783d8d3@suse.com> In-Reply-To: <2e3c8f9d-8007-638a-c88b-21ad2783d8d3@suse.com> X-ClientProxiedBy: FR3P281CA0123.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:94::9) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|DU2PR04MB8646:EE_ X-MS-Office365-Filtering-Correlation-Id: d8909c3f-54e9-4178-e14e-08db303f7988 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: N8DOJfQ7Sl6jT6pKJSKrvqzbgg9OP6wbghkH7olWoMbfLjRcUElTfX07We54Y6KOwOaxS9djNLZBQqSV4RTXLWWIkh/xecl+INLjbMRSCGvKwv3VFl7kFABcKIuyv8iifLlSoPUpDLIDq0ZHZJT2taOU0GKIqEtJ11PfnVHPQjA/Q+EFcQOjSpu/0bwzeWBSN6rFSfFCKNKYkynLBNoCqe8mAKNh76HX+0cjSFoXbFKdLi6L5grxEcIEegZEWsZEjA+zYPHa/++Jzc/P5pTb+RHNwJsBKaXtUEeMcGUDzgaShZcbidxTdmdHvN3QyPMgOh694Pn8jhEBVu1YBPQ1lKn1WpFkIkEYIRZ1UPbNssrwvFVvV5sdwecX1DtTxAmNPvTY9DonUGlizBNlqfQ+wZmAer2U6OgoV9TzuaQ+jpgg1XwrlKt9X48Gl37+fswCU79mkO9QAKAhNCwe9JgxewOTcREwZqOEIW60QKWL01N15V+sJy+NbqzamjlJmVp9oHBVVVBd+14XCGoeFLnkZBTJG4lZD1AAWKJmTWco0bUKAKabVxbiv5K/DYyKovgXgtKfV6WmtrcJ9vBp6uonLbNkv10OoCeZgYVTvRM29E2NTXl28RnRj+ahrK1tCgqMoSJ/QJ1trl5RcSpJPkblOQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(376002)(366004)(39860400002)(346002)(136003)(396003)(451199021)(6512007)(26005)(38100700002)(6486002)(2616005)(5660300002)(186003)(2906002)(8936002)(36756003)(54906003)(478600001)(6506007)(316002)(6916009)(4326008)(41300700001)(86362001)(31696002)(8676002)(66556008)(66476007)(66946007)(83380400001)(31686004)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?GGAMKQ3YExbiiqzOrfABkzzLbUJq?= =?utf-8?q?dQWtUg98eXdRyS7HI5bQY2hxE4aE1xZna86cHFIi+5H6F7S5O3ABtESOe1xtqxbE0?= =?utf-8?q?AkBN3Rw/gX3oKaScZdaRoZlP5Kbg4J1VxyylZMv41wacV3QCjT5FVXNahpSSbeBhN?= =?utf-8?q?/CB/cBpPrgwDALmG0W6wPSb1WXTdGejW4G3FwnKiorY2Qtk2Oqv2o0jkDgeQgXnjY?= =?utf-8?q?N9fjwaD/CaHLYX98WKIJ8+KY4Y16Du2DtmEzRl12FqW62/ig9Vbe29nxfmBeKr6Q3?= =?utf-8?q?UiVH+Ka4ZxaiAkVnzMMl4sAWemKmj9rz9K1SrHL7DZc17wRYtX2LaMPsJ2HbO2Xem?= =?utf-8?q?J2fegR5WboupNfE+zvuR618w5f35sTiEfYbVaR0pseHwpR52834G16OP46In9hgp9?= =?utf-8?q?6Oifbm81/mDk+hsuZxdCWXLV79DoWy95o0CDlsikBi4b4T3KlhnHfE2LPA0C0dhX1?= =?utf-8?q?8sk0CqUjwdw7QYje1dUIY+SWEVts26AZ+sEIYtt5ZgDizO4fYcXkcMAN6JR5nSdVK?= =?utf-8?q?zm+p5nwcWki5UQ5fHXCB8h0K3F2zjz63aXT2+TAxumnpf0jBk0HzvCZ5+Gf08Dwfh?= =?utf-8?q?uNF0QQFnqkMBY9xfN780a7H/qif8qro8WdOBYIzGZyuQw15B/r7EPTntiDVeC8zi3?= =?utf-8?q?PhZfV+yTEElEByylJHV6PF5fjAMGERUn22F3dglfKCfJguqK97c+qV9UgkQ0wMGPk?= =?utf-8?q?KeHm6Htsa1Pxk4JD0dz2kBdMt7fdjxNU3K+rGVsaHrOQNcNwI636BP4mOkSyaRRuU?= =?utf-8?q?JizrcQ7ePxl7ikmkh4EaecHn2bJ1cZxrIkNJau8a0qfnglPGPLif0/jKTy7IuUzTh?= =?utf-8?q?/Ve+zyQu/BIyHuFyB0ylBYbgw7G53icNN+mqJm77WBdvq1bUgNMuL1X/KJWXXGZO1?= =?utf-8?q?4ou2y44KzZ1WWomygVf7PRiI/LgA0i4xlUtnr56yGqw9PurzcZbiysqFbNPejDHfc?= =?utf-8?q?a5DuxjPxsgWaAC5X/EvrGLHcWChAzZJADM49FaYxyNAgB93lKnmQp3MytRrpKKalF?= =?utf-8?q?yZLhSSeywJz15oiXHSlloeK+qOnpbY4+651F9NTnzQOpF4DRdIUZFdutb3mksmmTX?= =?utf-8?q?7q/7kKMMmeGQwClqVpQjfNB5uCCSFtLor/FHtP21fRwg+DuX1p8mOdE3a/0nUhvGr?= =?utf-8?q?TCbV/EE4dOK6GUL5QM/3LpJrzNrWf9NqdsJHi7fRq0dLUe+ONGkE4R8I/SUB+XKDj?= =?utf-8?q?xijSdm4ZIGD9/i4M0EZmVTLACYqF0ZJ9wnsKygrQbrQKZ/vdHKWMGomh+vqMROgaC?= =?utf-8?q?Ifq47KeeBTe519PyP2qf+YxNHfMjYwT7wQh/j7yFzZLhnGzLwtgLuXYRT2fw/yBfy?= =?utf-8?q?+BDD3iVEbhue/wvcEkdyzfdERKN+UMTaE8L91slZO7FEntAzdB68US0rU505II1H3?= =?utf-8?q?eEya9VN8FkuEuqrSchs9id6zV+F4yHgdlIrBkT7g6gQc8/2WHUrXYTcDv9ygdMgCP?= =?utf-8?q?UGnomfcjH3Vtor5dxnC+2BGYh0z9p4iYNbruiBF2fjTwY/MnaeVevn1xrVHDEWvA6?= =?utf-8?q?ctOSN8I5l9Ea?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: d8909c3f-54e9-4178-e14e-08db303f7988 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Mar 2023 10:22:18.4862 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: vB+T58nMWgh0BdqqJ2wngRqlEXmYxgE0FBEzhDp5XblOJ6Z+07w505fcJsObKKHcpOPKdzs9Jy1nMZtm/50pzg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2PR04MB8646 I don't view a variable of this name as suitable for exporting, the more that it carries entirely redundant information. The reasons for its introduction in Linux commit 051f278e9d81 ("kbuild: replace KBUILD_SRCTREE with boolean building_out_of_srctree") also don't apply to us. Ditch exporting of the variable, replacing uses suitably. Signed-off-by: Jan Beulich Reviewed-by: Anthony PERARD --- v2: New. --- For further reasons (besides the similar redundancy aspect) exporting VPATH looks also suspicious: Its name being all uppercase makes it a "non application private" variable, i.e. it or its (pre-existing) value may have a purpose/use elsewhere. And exporting it looks to be easily avoidable: Instead of setting it in xen/Makefile, it looks like it could be set in xen/scripts/Kbuild.include. Thoughts? --- a/xen/Makefile +++ b/xen/Makefile @@ -208,7 +208,7 @@ endif objtree := . VPATH := $(srctree) -export building_out_of_srctree srctree objtree VPATH +export srctree objtree VPATH export XEN_ROOT := $(abs_srctree)/.. --- a/xen/arch/x86/boot/Makefile +++ b/xen/arch/x86/boot/Makefile @@ -14,7 +14,7 @@ $(obj)/head.o: $(head-bin-objs:.o=.bin) CFLAGS_x86_32 := $(subst -m64,-m32 -march=i686,$(XEN_TREEWIDE_CFLAGS)) $(call cc-options-add,CFLAGS_x86_32,CC,$(EMBEDDED_EXTRA_CFLAGS)) CFLAGS_x86_32 += -Werror -fno-builtin -g0 -msoft-float -ifdef building_out_of_srctree +ifneq ($(abs_objtree),$(abs_srctree)) CFLAGS_x86_32 += -I$(objtree)/include endif CFLAGS_x86_32 += -I$(srctree)/include --- a/xen/scripts/Makefile.host +++ b/xen/scripts/Makefile.host @@ -88,7 +88,7 @@ _hostcxx_flags = $(HOSTCXXFLAGS) $(HOST_ $(HOSTCXXFLAGS_$(target-stem).o) # $(objtree)/$(obj) for including generated headers from checkin source files -ifdef building_out_of_srctree +ifneq ($(abs_objtree),$(abs_srctree)) _hostc_flags += -I $(objtree)/$(obj) _hostcxx_flags += -I $(objtree)/$(obj) endif