| Message ID | 9f1949e5-665b-a153-342e-8b3482c8b9c8@suse.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Arm32: restore proper name of .dtb section start symbol | expand |
Hi Jan, > On 25 Jul 2022, at 11:12, Jan Beulich <jbeulich@suse.com> wrote: > > This addresses a build failure when CONFIG_DTB_FILE evaluates to a non- > empty string. > > Fixes: d07358f2dccd ("xen/arm32: head.S: Introduce a macro to load the physical address of a symbol") > Signed-off-by: Jan Beulich <jbeulich@suse.com> Reviewed-by: Bertrand Marquis <bertrand.marquis@arm.com> Cheers Bertrand > --- > Of course this really would be a prime candidate for avoiding the > use of linker-script-defined symbols in the first place, by using > .startof.(.dtb). If only Clang also supported that ... > > --- a/xen/arch/arm/arm32/head.S > +++ b/xen/arch/arm/arm32/head.S > @@ -162,7 +162,7 @@ past_zImage: > > /* Using the DTB in the .dtb section? */ > .ifnes CONFIG_DTB_FILE,"" > - load_paddr r8, _stdb > + load_paddr r8, _sdtb > .endif > > /* Initialize the UART if earlyprintk has been enabled. */
--- a/xen/arch/arm/arm32/head.S +++ b/xen/arch/arm/arm32/head.S @@ -162,7 +162,7 @@ past_zImage: /* Using the DTB in the .dtb section? */ .ifnes CONFIG_DTB_FILE,"" - load_paddr r8, _stdb + load_paddr r8, _sdtb .endif /* Initialize the UART if earlyprintk has been enabled. */
This addresses a build failure when CONFIG_DTB_FILE evaluates to a non- empty string. Fixes: d07358f2dccd ("xen/arm32: head.S: Introduce a macro to load the physical address of a symbol") Signed-off-by: Jan Beulich <jbeulich@suse.com> --- Of course this really would be a prime candidate for avoiding the use of linker-script-defined symbols in the first place, by using .startof.(.dtb). If only Clang also supported that ...