diff mbox series

[XEN,1/1] tools/xenstore: Add missing XENCONSOLED_ARGS variable

Message ID DU0P192MB170046CFB3F2977E45B08E3EE3332@DU0P192MB1700.EURP192.PROD.OUTLOOK.COM (mailing list archive)
State New
Headers show
Series tools/xenstore: Add missing XENCONSOLED_ARGS | expand

Commit Message

Rafaël Kooi March 20, 2024, 7:15 a.m. UTC
The systemd xenconsoled.service uses the XENCONSOLED_ARGS variable, but
it was missing from the xencommons file.

Signed-off-by: Rafaël Kooi <rafael_andreas@hotmail.com>
---
 tools/hotplug/Linux/init.d/sysconfig.xencommons.in | 6 ++++++
 1 file changed, 6 insertions(+)

Comments

Jan Beulich March 20, 2024, 7:30 a.m. UTC | #1
On 20.03.2024 08:15, Rafaël Kooi wrote:
> The systemd xenconsoled.service uses the XENCONSOLED_ARGS variable, but
> it was missing from the xencommons file.

As to the title prefix: How does xenstore come into play here?

Jan
Rafaël Kooi March 20, 2024, 7:36 a.m. UTC | #2
On 20/03/2024 08:30, Jan Beulich wrote:
> On 20.03.2024 08:15, Rafaël Kooi wrote:
>> The systemd xenconsoled.service uses the XENCONSOLED_ARGS variable, but
>> it was missing from the xencommons file.
> As to the title prefix: How does xenstore come into play here?
>
> Jan
I don't actually remember, I may have done my git log incorrectly as I
don't see other people use that prefix for it. I probably should've
double checked before posting.

Should I use `tools: init scripts:` as the proper prefix?

Thanks,

Rafaël Kooi
diff mbox series

Patch

diff --git a/tools/hotplug/Linux/init.d/sysconfig.xencommons.in b/tools/hotplug/Linux/init.d/sysconfig.xencommons.in
index 1bdd830d8a..42104ecaa4 100644
--- a/tools/hotplug/Linux/init.d/sysconfig.xencommons.in
+++ b/tools/hotplug/Linux/init.d/sysconfig.xencommons.in
@@ -5,6 +5,12 @@ 
 # Log xenconsoled messages (cf xl dmesg)
 #XENCONSOLED_TRACE=[none|guest|hv|all]
 
+## Type: string
+## Default: ""
+#
+# Additional commandline arguments to start xenconsoled.
+XENCONSOLED_ARGS=
+
 ## Type: string
 ## Default: daemon
 #