| Message ID | a2b2d290e62bf6727769af91d3955bdd989ede3c.1744313419.git.nicola.vetrini@bugseng.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | [XEN] automation/eclair: Remove bespoke service B.UNEVALEFF | expand |
On 10/04/2025 8:32 pm, Nicola Vetrini wrote: > The service is now part of the updated ECLAIR runner, therefore > redefining will result in an error. > > No functional change. > > Signed-off-by: Nicola Vetrini <nicola.vetrini@bugseng.com> Acked-by: Andrew Cooper <andrew.cooper3@citrix.com> Presumably this will be needed on all branches using Eclair ? ~Andrew
On 2025-04-10 22:08, Andrew Cooper wrote: > On 10/04/2025 8:32 pm, Nicola Vetrini wrote: >> The service is now part of the updated ECLAIR runner, therefore >> redefining will result in an error. >> >> No functional change. >> >> Signed-off-by: Nicola Vetrini <nicola.vetrini@bugseng.com> > > Acked-by: Andrew Cooper <andrew.cooper3@citrix.com> > > Presumably this will be needed on all branches using Eclair ? > Tes, that would allow to reuse the latest runner on those branches, which is probably the best course of action. Since they get (presumably?) less activity than staging, that might be held off until then, before any other backports. I'm still waiting for the container image to finish copying to the other runner though, so you might experience some short-term breakage. > ~Andrew
On 10/04/2025 9:17 pm, Nicola Vetrini wrote: > On 2025-04-10 22:08, Andrew Cooper wrote: >> On 10/04/2025 8:32 pm, Nicola Vetrini wrote: >>> The service is now part of the updated ECLAIR runner, therefore >>> redefining will result in an error. >>> >>> No functional change. >>> >>> Signed-off-by: Nicola Vetrini <nicola.vetrini@bugseng.com> >> >> Acked-by: Andrew Cooper <andrew.cooper3@citrix.com> >> >> Presumably this will be needed on all branches using Eclair ? >> > > Tes, that would allow to reuse the latest runner on those branches, > which is probably the best course of action. Since they get > (presumably?) less activity than staging, that might be held off until > then, before any other backports. Well, I'm doing backports for other reasons, so I'll include this. ~Andrew
diff --git a/automation/eclair_analysis/ECLAIR/B.UNEVALEFF.ecl b/automation/eclair_analysis/ECLAIR/B.UNEVALEFF.ecl deleted file mode 100644 index fa249b8e3625..000000000000 --- a/automation/eclair_analysis/ECLAIR/B.UNEVALEFF.ecl +++ /dev/null @@ -1,10 +0,0 @@ --clone_service=MC3A2.R13.6,B.UNEVALEFF - --config=B.UNEVALEFF,summary="The operand of the `alignof' and `typeof' operators shall not contain any expression which has potential side effects" --config=B.UNEVALEFF,stmt_child_matcher= -{"stmt(node(utrait_expr)&&operator(alignof))", expr, 0, "stmt(any())", {}}, -{"stmt(node(utrait_type)&&operator(alignof))", type, 0, "stmt(any())", {}}, -{"stmt(node(utrait_expr)&&operator(preferred_alignof))", expr, 0, "stmt(any())", {}}, -{"stmt(node(utrait_type)&&operator(preferred_alignof))", type, 0, "stmt(any())", {}}, -{"type(node(typeof_expr))", expr, 0, "stmt(any())", {}}, -{"type(node(typeof_type))", type, 0, "stmt(any())", {}} diff --git a/automation/eclair_analysis/ECLAIR/analysis.ecl b/automation/eclair_analysis/ECLAIR/analysis.ecl index 29409a9af0eb..399099938f45 100644 --- a/automation/eclair_analysis/ECLAIR/analysis.ecl +++ b/automation/eclair_analysis/ECLAIR/analysis.ecl @@ -50,7 +50,6 @@ their Standard Library equivalents." -eval_file=adopted.ecl -eval_file=out_of_scope.ecl --eval_file=B.UNEVALEFF.ecl -eval_file=deviations.ecl -eval_file=call_properties.ecl -eval_file=tagging.ecl
The service is now part of the updated ECLAIR runner, therefore redefining will result in an error. No functional change. Signed-off-by: Nicola Vetrini <nicola.vetrini@bugseng.com> --- To be applied after updating the ECLAIR runners --- automation/eclair_analysis/ECLAIR/B.UNEVALEFF.ecl | 10 ---------- automation/eclair_analysis/ECLAIR/analysis.ecl | 1 - 2 files changed, 11 deletions(-) delete mode 100644 automation/eclair_analysis/ECLAIR/B.UNEVALEFF.ecl