| Message ID | a2fb434d56dc668c27b51d03be0fab703583c18d.1725972157.git.nicola.vetrini@bugseng.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | [XEN] automation/eclair_analysis: address violation of Rule 20.7 | expand |
On Tue, 10 Sep 2024, Nicola Vetrini wrote: > MISRA Rule 20.7 states: > "Expressions resulting from the expansion of macro parameters > shall be enclosed in parentheses". > > The files imported from the gnu-efi package are already deviated, yet > the macro NextMemoryDescriptor is used in non-excluded code, so a further > deviation is needed to exclude also any expansion of the macro. > > No functional change. > > Signed-off-by: Nicola Vetrini <nicola.vetrini@bugseng.com> Acked-by: Stefano Stabellini <sstabellini@kernel.org> > --- > automation/eclair_analysis/ECLAIR/deviations.ecl | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/automation/eclair_analysis/ECLAIR/deviations.ecl b/automation/eclair_analysis/ECLAIR/deviations.ecl > index ed80ac795851..3241f96cd612 100644 > --- a/automation/eclair_analysis/ECLAIR/deviations.ecl > +++ b/automation/eclair_analysis/ECLAIR/deviations.ecl > @@ -566,7 +566,7 @@ of the IS_ENABLED or STATIC_IF/STATIC_IF_NOT macros, so it always receives a lit > not in scope for compliance are allowed, as that is imported code." > -file_tag+={gnu_efi_include, "^xen/include/efi/.*$"} > -file_tag+={acpi_cpu_idle, "^xen/arch/x86/acpi/cpu_idle\\.c$"} > --config=MC3R1.R20.7,reports+={safe, "any_area(any_loc(file(gnu_efi_include)))"} > +-config=MC3R1.R20.7,reports+={safe, "any_area(any_loc(file(gnu_efi_include)||any_exp(macro(^NextMemoryDescriptor$))))"} > -config=MC3R1.R20.7,reports+={safe, "any_area(any_loc(file(acpi_cpu_idle)))"} > -doc_end > > -- > 2.43.0 >
diff --git a/automation/eclair_analysis/ECLAIR/deviations.ecl b/automation/eclair_analysis/ECLAIR/deviations.ecl index ed80ac795851..3241f96cd612 100644 --- a/automation/eclair_analysis/ECLAIR/deviations.ecl +++ b/automation/eclair_analysis/ECLAIR/deviations.ecl @@ -566,7 +566,7 @@ of the IS_ENABLED or STATIC_IF/STATIC_IF_NOT macros, so it always receives a lit not in scope for compliance are allowed, as that is imported code." -file_tag+={gnu_efi_include, "^xen/include/efi/.*$"} -file_tag+={acpi_cpu_idle, "^xen/arch/x86/acpi/cpu_idle\\.c$"} --config=MC3R1.R20.7,reports+={safe, "any_area(any_loc(file(gnu_efi_include)))"} +-config=MC3R1.R20.7,reports+={safe, "any_area(any_loc(file(gnu_efi_include)||any_exp(macro(^NextMemoryDescriptor$))))"} -config=MC3R1.R20.7,reports+={safe, "any_area(any_loc(file(acpi_cpu_idle)))"} -doc_end
MISRA Rule 20.7 states: "Expressions resulting from the expansion of macro parameters shall be enclosed in parentheses". The files imported from the gnu-efi package are already deviated, yet the macro NextMemoryDescriptor is used in non-excluded code, so a further deviation is needed to exclude also any expansion of the macro. No functional change. Signed-off-by: Nicola Vetrini <nicola.vetrini@bugseng.com> --- automation/eclair_analysis/ECLAIR/deviations.ecl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)