From patchwork Wed Feb 22 16:42:28 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrew Cooper X-Patchwork-Id: 9587171 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 226B9600CA for ; Wed, 22 Feb 2017 16:45:20 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 0C0022840E for ; Wed, 22 Feb 2017 16:45:20 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 00938285EA; Wed, 22 Feb 2017 16:45:19 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=2.0 tests=BAYES_00, RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 6F64428640 for ; Wed, 22 Feb 2017 16:45:18 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cga0A-0004xF-6j; Wed, 22 Feb 2017 16:42:50 +0000 Received: from mail6.bemta6.messagelabs.com ([193.109.254.103]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cga09-0004x9-Sc for xen-devel@lists.xen.org; Wed, 22 Feb 2017 16:42:49 +0000 Received: from [193.109.254.147] by server-10.bemta-6.messagelabs.com id 3A/94-13192-98FBDA85; Wed, 22 Feb 2017 16:42:49 +0000 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrJIsWRWlGSWpSXmKPExsWyU9JRQrdj/9o Igw339CyWfFzM4sDocXT3b6YAxijWzLyk/IoE1oxXDx4zFczjqHjX8Iu9gfEDaxcjJ4eEgJ/E npPfWUBsYYFYidedh8HiIgJBEvN3z2XrYuTiEBLYwyzx7MgVZpAEs0CAxNeb+xlBbDYBfYndL z4xdTFycPAK2ErsXFkJEmYRUJVo3bGEHcQWFQiWODDxBpjNKyAocXLmE7BdnAJ2Encvr2WHGG kgcWTRHFYIW15i+9s5YKuEBNQkrvVfYoe4M11i699fzBMY+WchGTULSfssJO0LGJlXMWoUpxa VpRbpGhrqJRVlpmeU5CZm5ugaGpjp5aYWFyemp+YkJhXrJefnbmIEBiEDEOxg/LQs4BCjJAeT kigv3461EUJ8SfkplRmJxRnxRaU5qcWHGGU4OJQkeO/vBcoJFqWmp1akZeYA4wEmLcHBoyTCy 7QPKM1bXJCYW5yZDpE6xagoJc7bA9InAJLIKM2Da4PF4CVGWSlhXkagQ4R4ClKLcjNLUOVfMY pzMCoJ88aCjOfJzCuBm/4KaDET0GJLZ7DFJYkIKakGRnNpQZOEFR8OPzJitvjhrLwhcTdT90J L/ol5j+s4T3w7IBUm+bzHze1JkHLrUq9HHwMvLTOtOskaZFUx64HX/As5iScFbrHI51+0l5IR XHc6zdY6YP2rzH1m5ZNKHQwsjz9TlvgVvbV5Qr7WVMXfyy+9T3DQcHoa0WKpvsvC8oqlAvvry Xo/lViKMxINtZiLihMBK55RZ7wCAAA= X-Env-Sender: prvs=219ec1b1d=Andrew.Cooper3@citrix.com X-Msg-Ref: server-2.tower-27.messagelabs.com!1487781768!35917538!1 X-Originating-IP: [185.25.65.24] X-SpamReason: No, hits=0.0 required=7.0 tests=received_headers: No Received headers X-StarScan-Received: X-StarScan-Version: 9.2.3; banners=-,-,- X-VirusChecked: Checked Received: (qmail 40780 invoked from network); 22 Feb 2017 16:42:48 -0000 Received: from smtp.eu.citrix.com (HELO SMTP.EU.CITRIX.COM) (185.25.65.24) by server-2.tower-27.messagelabs.com with RC4-SHA encrypted SMTP; 22 Feb 2017 16:42:48 -0000 X-IronPort-AV: E=Sophos;i="5.35,195,1484006400"; d="scan'208";a="41236347" To: Boris Ostrovsky , Jan Beulich References: <1487353212-4395-1-git-send-email-boris.ostrovsky@oracle.com> <1487353212-4395-3-git-send-email-boris.ostrovsky@oracle.com> <58AD6E05020000780013CA69@prv-mh.provo.novell.com> <58ADB060020000780013CDA2@prv-mh.provo.novell.com> <4aa8a7a1-92fd-2e03-693f-2d1fe15c3df2@oracle.com> <19cf5c82-cba5-5842-cb46-be319e5a261c@citrix.com> From: Andrew Cooper Message-ID: Date: Wed, 22 Feb 2017 16:42:28 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Icedove/45.6.0 MIME-Version: 1.0 In-Reply-To: X-ClientProxiedBy: AMSPEX02CAS01.citrite.net (10.69.22.112) To AMSPEX02CL02.citrite.net (10.69.22.126) Cc: kevin.tian@intel.com, jun.nakajima@intel.com, xen-devel@lists.xen.org Subject: Re: [Xen-devel] [PATCH v2 2/3] x86/vpmu: Disable VPMU if guest's CPUID indicates no PMU support X-BeenThere: xen-devel@lists.xen.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" X-Virus-Scanned: ClamAV using ClamSMTP On 22/02/17 16:34, Boris Ostrovsky wrote: >> I think the code as-is is ok, although it would be nice to extend the >> basic{} union to have a named uint8_t for pmu_version. > > Something like this? This please, to match the AMD side. ~Andrew diff --git a/xen/include/asm-x86/cpuid.h b/xen/include/asm-x86/cpuid.h index bc3fc7c..363ef32 100644 --- a/xen/include/asm-x86/cpuid.h +++ b/xen/include/asm-x86/cpuid.h @@ -118,6 +118,18 @@ struct cpuid_policy /* Leaf 0x2 - TLB/Cache/Prefetch. */ uint8_t l2_nr_queries; /* Documented as fixed to 1. */ + uint8_t l2_desc[15]; + + uint64_t :64, :64; /* PSN. */ + uint64_t :64, :64; /* Structured Cache. */ + uint64_t :64, :64; /* MONITOR. */ + uint64_t :64, :64; /* Therm/Perf. */ + uint64_t :64, :64; /* Structured Features. */ + uint64_t :64, :64; /* rsvd */ + uint64_t :64, :64; /* DCA */ + + /* Leaf 0xa - Intel PMU. */ + uint8_t pmu_version; }; } basic;