From patchwork Wed Aug 7 16:49:15 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stefano Stabellini X-Patchwork-Id: 11082453 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 01D57112C for ; Wed, 7 Aug 2019 16:50:58 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id E6AA628994 for ; Wed, 7 Aug 2019 16:50:57 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id DB36C28A14; Wed, 7 Aug 2019 16:50:57 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.0 required=2.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 8B7A328994 for ; Wed, 7 Aug 2019 16:50:57 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1hvP7o-0007HA-1S; Wed, 07 Aug 2019 16:49:20 +0000 Received: from us1-rack-dfw2.inumbo.com ([104.130.134.6]) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1hvP7l-0007H1-Tr for xen-devel@lists.xenproject.org; Wed, 07 Aug 2019 16:49:17 +0000 X-Inumbo-ID: 4ac3e3d2-b933-11e9-8980-bc764e045a96 Received: from mail.kernel.org (unknown [198.145.29.99]) by us1-rack-dfw2.inumbo.com (Halon) with ESMTPS id 4ac3e3d2-b933-11e9-8980-bc764e045a96; Wed, 07 Aug 2019 16:49:16 +0000 (UTC) Received: from localhost (c-67-164-102-47.hsd1.ca.comcast.net [67.164.102.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 9A59A2229C; Wed, 7 Aug 2019 16:49:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1565196555; bh=44PYsWGCqETOMJ0ipTggdvBTvhlwEFkJIxoLSe6BBg4=; h=Date:From:To:cc:Subject:From; b=UQpcXohvpR9Ywx9yerec1YSIr6fHnH1FOGpsDJHq5d/agM7i3zB8JkWdDZJptc/bM Tyyo4U2SOSrvX46ud2YvYQpgQxL2VqBe7fvPxTvS7UHXgyxGwHGuOGSAwgRoUjFjlk VsrmqJlI2LnIDMfdkEzkLuiEodGkLcvE0Gao6f8A= Date: Wed, 7 Aug 2019 09:49:15 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@sstabellini-ThinkPad-T480s To: xen-devel@lists.xenproject.org Message-ID: User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Subject: [Xen-devel] [PATCH v2] xen/arm: unbreak arm64 build for older toolchains X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: julien.grall@arm.com, sstabellini@kernel.org, Volodymyr_Babchuk@epam.com Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" X-Virus-Scanned: ClamAV using ClamSMTP Commit 4941bfb "xen/arm64: macros: Introduce an assembly macro to alias x30" moved lr .req x30 to macros.h. A later patch (1396dab "xen/arm64: head: Don't clobber x30/lr in the macro PRINT") started to use "lr" in head.S, however, it didn't add an #include macros.h to head.S. This commit fixes it. The lack of alias breaks the build with gcc-linaro-5.3.1-2016.05-x86_64_aarch64-linux-gnu. The alias was added later to binutiles 2.29 in 2017. Signed-off-by: Stefano Stabellini Reviewed-by: Julien Grall --- Changes in v2: - improve commit message diff --git a/xen/arch/arm/arm64/head.S b/xen/arch/arm/arm64/head.S index 28efe9230c..50cff08756 100644 --- a/xen/arch/arm/arm64/head.S +++ b/xen/arch/arm/arm64/head.S @@ -25,6 +25,7 @@ #include #include #include +#include #define PT_PT 0xf7f /* nG=1 AF=1 SH=11 AP=01 NS=1 ATTR=111 T=1 P=1 */ #define PT_MEM 0xf7d /* nG=1 AF=1 SH=11 AP=01 NS=1 ATTR=111 T=0 P=1 */