| Message ID | alpine.DEB.2.21.2011051312120.2323@sstabellini-ThinkPad-T480s (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | libxl: set vuart_gfn in libxl__build_hvm | expand |
On Thu, Nov 05, 2020 at 01:15:05PM -0800, Stefano Stabellini wrote: > libxl: set vuart_gfn in libxl__build_hvm The subject is written two times ;-) > Setting vuart_gfn was missed when switching ARM guests to the PVH build. > Like libxl__build_pv, libxl__build_hvm should set state->vuart_gfn to > dom->vuart_gfn. > > Without this change, xl console cannot connect to the vuart console (-t > vuart), see https://marc.info/?l=xen-devel&m=160402342101366. > > Signed-off-by: Stefano Stabellini <stefano.stabellini@xilinx.com> > > diff --git a/tools/libxl/libxl_dom.c b/tools/libxl/libxl_dom.c > index f8661e90d4..36fe8915e7 100644 > --- a/tools/libxl/libxl_dom.c > +++ b/tools/libxl/libxl_dom.c > @@ -1184,6 +1184,7 @@ int libxl__build_hvm(libxl__gc *gc, uint32_t domid, > LOG(ERROR, "hvm build set params failed"); > goto out; > } > + state->vuart_gfn = dom->vuart_gfn; > > rc = hvm_build_set_xs_values(gc, domid, dom, info); > if (rc != 0) { Reviewed-by: Anthony PERARD <anthony.perard@citrix.com> Thanks,
On Fri, Nov 06, 2020 at 03:11:46PM +0000, Anthony PERARD wrote: > On Thu, Nov 05, 2020 at 01:15:05PM -0800, Stefano Stabellini wrote: > > libxl: set vuart_gfn in libxl__build_hvm > > The subject is written two times ;-) > > > Setting vuart_gfn was missed when switching ARM guests to the PVH build. > > Like libxl__build_pv, libxl__build_hvm should set state->vuart_gfn to > > dom->vuart_gfn. > > > > Without this change, xl console cannot connect to the vuart console (-t > > vuart), see https://marc.info/?l=xen-devel&m=160402342101366. > > > > Signed-off-by: Stefano Stabellini <stefano.stabellini@xilinx.com> > > > > diff --git a/tools/libxl/libxl_dom.c b/tools/libxl/libxl_dom.c > > index f8661e90d4..36fe8915e7 100644 > > --- a/tools/libxl/libxl_dom.c > > +++ b/tools/libxl/libxl_dom.c > > @@ -1184,6 +1184,7 @@ int libxl__build_hvm(libxl__gc *gc, uint32_t domid, > > LOG(ERROR, "hvm build set params failed"); > > goto out; > > } > > + state->vuart_gfn = dom->vuart_gfn; > > > > rc = hvm_build_set_xs_values(gc, domid, dom, info); > > if (rc != 0) { > > Reviewed-by: Anthony PERARD <anthony.perard@citrix.com> This patch is based on an old tree. I have ported it to staging. Please check the code and shout if it is not done correctly. Wei. > > Thanks, > > -- > Anthony PERARD
On Fri, 6 Nov 2020, Wei Liu wrote: > On Fri, Nov 06, 2020 at 03:11:46PM +0000, Anthony PERARD wrote: > > On Thu, Nov 05, 2020 at 01:15:05PM -0800, Stefano Stabellini wrote: > > > libxl: set vuart_gfn in libxl__build_hvm > > > > The subject is written two times ;-) > > > > > Setting vuart_gfn was missed when switching ARM guests to the PVH build. > > > Like libxl__build_pv, libxl__build_hvm should set state->vuart_gfn to > > > dom->vuart_gfn. > > > > > > Without this change, xl console cannot connect to the vuart console (-t > > > vuart), see https://marc.info/?l=xen-devel&m=160402342101366. > > > > > > Signed-off-by: Stefano Stabellini <stefano.stabellini@xilinx.com> > > > > > > diff --git a/tools/libxl/libxl_dom.c b/tools/libxl/libxl_dom.c > > > index f8661e90d4..36fe8915e7 100644 > > > --- a/tools/libxl/libxl_dom.c > > > +++ b/tools/libxl/libxl_dom.c > > > @@ -1184,6 +1184,7 @@ int libxl__build_hvm(libxl__gc *gc, uint32_t domid, > > > LOG(ERROR, "hvm build set params failed"); > > > goto out; > > > } > > > + state->vuart_gfn = dom->vuart_gfn; > > > > > > rc = hvm_build_set_xs_values(gc, domid, dom, info); > > > if (rc != 0) { > > > > Reviewed-by: Anthony PERARD <anthony.perard@citrix.com> > > This patch is based on an old tree. I have ported it to staging. Please > check the code and shout if it is not done correctly. all good, thanks!
diff --git a/tools/libxl/libxl_dom.c b/tools/libxl/libxl_dom.c index f8661e90d4..36fe8915e7 100644 --- a/tools/libxl/libxl_dom.c +++ b/tools/libxl/libxl_dom.c @@ -1184,6 +1184,7 @@ int libxl__build_hvm(libxl__gc *gc, uint32_t domid, LOG(ERROR, "hvm build set params failed"); goto out; } + state->vuart_gfn = dom->vuart_gfn; rc = hvm_build_set_xs_values(gc, domid, dom, info); if (rc != 0) {
libxl: set vuart_gfn in libxl__build_hvm Setting vuart_gfn was missed when switching ARM guests to the PVH build. Like libxl__build_pv, libxl__build_hvm should set state->vuart_gfn to dom->vuart_gfn. Without this change, xl console cannot connect to the vuart console (-t vuart), see https://marc.info/?l=xen-devel&m=160402342101366. Signed-off-by: Stefano Stabellini <stefano.stabellini@xilinx.com>