From patchwork Thu Nov 5 21:15:05 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stefano Stabellini X-Patchwork-Id: 11885229 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id EBBF5697 for ; Thu, 5 Nov 2020 21:15:47 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id AF2822073A for ; Thu, 5 Nov 2020 21:15:47 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="oP67AJyC" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AF2822073A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from list by lists.xenproject.org with outflank-mailman.20190.45885 (Exim 4.92) (envelope-from ) id 1kamb7-0003b0-MQ; Thu, 05 Nov 2020 21:15:09 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 20190.45885; Thu, 05 Nov 2020 21:15:09 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kamb7-0003at-JD; Thu, 05 Nov 2020 21:15:09 +0000 Received: by outflank-mailman (input) for mailman id 20190; Thu, 05 Nov 2020 21:15:08 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kamb6-0003an-IY for xen-devel@lists.xenproject.org; Thu, 05 Nov 2020 21:15:08 +0000 Received: from mail.kernel.org (unknown [198.145.29.99]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 215af06f-87c6-4754-914e-9f4172478095; Thu, 05 Nov 2020 21:15:07 +0000 (UTC) Received: from sstabellini-ThinkPad-T480s (c-24-130-65-46.hsd1.ca.comcast.net [24.130.65.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 0426920724; Thu, 5 Nov 2020 21:15:05 +0000 (UTC) Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kamb6-0003an-IY for xen-devel@lists.xenproject.org; Thu, 05 Nov 2020 21:15:08 +0000 X-Inumbo-ID: 215af06f-87c6-4754-914e-9f4172478095 Received: from mail.kernel.org (unknown [198.145.29.99]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 215af06f-87c6-4754-914e-9f4172478095; Thu, 05 Nov 2020 21:15:07 +0000 (UTC) Received: from sstabellini-ThinkPad-T480s (c-24-130-65-46.hsd1.ca.comcast.net [24.130.65.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 0426920724; Thu, 5 Nov 2020 21:15:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1604610906; bh=elF/Vxj2afwaRZRW6dqOS+Fhq/qJJgeJJ1Y621Iu2JA=; h=Date:From:To:cc:Subject:From; b=oP67AJyC7TFmD/Rd8exjUFC6dOnMB03jKiMiDgBfYDlG5hYtQ5cIv+uvhCw5qO7Gc xn7rZ1i1RyvcNc9imOzyIvtUDpB7Ay7SGUlqe7TsFQpB5sBT74JvMbDaJrh1kLdf3Q qdHE2vSh6cN4mWziqxl7jNiCXskegwSm1k1lsZk0= Date: Thu, 5 Nov 2020 13:15:05 -0800 (PST) From: Stefano Stabellini X-X-Sender: sstabellini@sstabellini-ThinkPad-T480s To: xen-devel@lists.xenproject.org cc: takahiro.akashi@linaro.org, alex.bennee@linaro.org, masami.hiramatsu@linaro.org, ian.jackson@eu.citrix.com, wl@xen.org, anthony.perard@citrix.com, sstabellini@kernel.org Subject: [PATCH] libxl: set vuart_gfn in libxl__build_hvm Message-ID: User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 libxl: set vuart_gfn in libxl__build_hvm Setting vuart_gfn was missed when switching ARM guests to the PVH build. Like libxl__build_pv, libxl__build_hvm should set state->vuart_gfn to dom->vuart_gfn. Without this change, xl console cannot connect to the vuart console (-t vuart), see https://marc.info/?l=xen-devel&m=160402342101366. Signed-off-by: Stefano Stabellini Reviewed-by: Anthony PERARD diff --git a/tools/libxl/libxl_dom.c b/tools/libxl/libxl_dom.c index f8661e90d4..36fe8915e7 100644 --- a/tools/libxl/libxl_dom.c +++ b/tools/libxl/libxl_dom.c @@ -1184,6 +1184,7 @@ int libxl__build_hvm(libxl__gc *gc, uint32_t domid, LOG(ERROR, "hvm build set params failed"); goto out; } + state->vuart_gfn = dom->vuart_gfn; rc = hvm_build_set_xs_values(gc, domid, dom, info); if (rc != 0) {