diff mbox series

[1/3] x86/vLAPIC: don't leak regs page from vlapic_init() upon error

Message ID b437de21-f108-c30e-4e0c-1137ad7d99fe@suse.com (mailing list archive)
State New, archived
Headers show
Series x86: plug 2 vCPU creation resource leaks + some cleanup | expand

Commit Message

Jan Beulich Oct. 2, 2020, 10:30 a.m. UTC 
Fixes: 8a981e0bf25e ("Make map_domain_page_global fail")
Signed-off-by: Jan Beulich <jbeulich@suse.com>

Comments

Andrew Cooper Oct. 2, 2020, 10:43 a.m. UTC | #1 
On 02/10/2020 11:30, Jan Beulich wrote:
> Fixes: 8a981e0bf25e ("Make map_domain_page_global fail")
> Signed-off-by: Jan Beulich <jbeulich@suse.com>

Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>
diff mbox series

Patch

--- a/xen/arch/x86/hvm/vlapic.c
+++ b/xen/arch/x86/hvm/vlapic.c
@@ -1625,6 +1625,7 @@  int vlapic_init(struct vcpu *v)
         vlapic->regs = __map_domain_page_global(vlapic->regs_page);
         if ( vlapic->regs == NULL )
         {
+            free_domheap_page(vlapic->regs_page);
             dprintk(XENLOG_ERR, "map vlapic regs error: %d/%d\n",
                     v->domain->domain_id, v->vcpu_id);
             return -ENOMEM;