From patchwork Thu Nov 19 08:57:52 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jan Beulich X-Patchwork-Id: 11916877 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CD0ECC388F9 for ; Thu, 19 Nov 2020 08:58:04 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5E2532158C for ; Thu, 19 Nov 2020 08:58:04 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=suse.com header.i=@suse.com header.b="f08MdXrg" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5E2532158C Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=suse.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from list by lists.xenproject.org with outflank-mailman.30481.60517 (Exim 4.92) (envelope-from ) id 1kfflL-0006iP-Jh; Thu, 19 Nov 2020 08:57:55 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 30481.60517; Thu, 19 Nov 2020 08:57:55 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kfflL-0006iH-Gj; Thu, 19 Nov 2020 08:57:55 +0000 Received: by outflank-mailman (input) for mailman id 30481; Thu, 19 Nov 2020 08:57:54 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kfflK-0006hJ-Bp for xen-devel@lists.xenproject.org; Thu, 19 Nov 2020 08:57:54 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 39181b60-33e7-40bd-9e5d-fe6ef796f688; Thu, 19 Nov 2020 08:57:53 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 8CFAEAD2F; Thu, 19 Nov 2020 08:57:52 +0000 (UTC) Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kfflK-0006hJ-Bp for xen-devel@lists.xenproject.org; Thu, 19 Nov 2020 08:57:54 +0000 X-Inumbo-ID: 39181b60-33e7-40bd-9e5d-fe6ef796f688 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 39181b60-33e7-40bd-9e5d-fe6ef796f688; Thu, 19 Nov 2020 08:57:53 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1605776272; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=crdjdM7DkXckInu6b41yqI+iMgZG4mEeVJLCAwg6n94=; b=f08MdXrgrVvmsx1/OmMAn7evZs1MuyGyfJ2FgL2Ow/nYJmYC0/CfEdCIfOgIw8D4sSMq1T nI422J0yc8a/yHtyRB5EtmMebeNakNMFzT+9f80qOmpsx/RSWWVJi98tImcT9kN40fu/uj VMwDDJB4lthuxvZcuiXOpDNROSB5OAg= Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 8CFAEAD2F; Thu, 19 Nov 2020 08:57:52 +0000 (UTC) Subject: [PATCH 2/2] ns16550: drop stray "#ifdef CONFIG_HAS_PCI" From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , George Dunlap , Ian Jackson , Julien Grall , Stefano Stabellini , Wei Liu References: Message-ID: Date: Thu, 19 Nov 2020 09:57:52 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.4.3 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US There's no point wrapping the function invocation when - the function body is already suitably wrapped, - the function itself is unconditionally available. Reported-by: Julien Grall Signed-off-by: Jan Beulich --- a/xen/drivers/char/ns16550.c +++ b/xen/drivers/char/ns16550.c @@ -968,9 +968,7 @@ static int __init check_existence(struct return 1; /* Everything is MMIO */ #endif -#ifdef CONFIG_HAS_PCI pci_serial_early_init(uart); -#endif /* * Do a simple existence test first; if we fail this,