From patchwork Fri Jun 30 04:07:34 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dou Liyang X-Patchwork-Id: 9818975 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id F052160224 for ; Fri, 30 Jun 2017 09:21:00 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id E13EA285FB for ; Fri, 30 Jun 2017 09:21:00 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id D5C9928607; Fri, 30 Jun 2017 09:21:00 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=2.0 tests=BAYES_00, RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 6C212285FB for ; Fri, 30 Jun 2017 09:21:00 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dQs4A-0005W6-VT; Fri, 30 Jun 2017 09:18:18 +0000 Received: from mail6.bemta6.messagelabs.com ([193.109.254.103]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dQnE7-0008Ip-NX for xen-devel@lists.xenproject.org; Fri, 30 Jun 2017 04:08:15 +0000 Received: from [193.109.254.147] by server-2.bemta-6.messagelabs.com id 8A/14-03032-FAEC5595; Fri, 30 Jun 2017 04:08:15 +0000 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrDIsWRWlGSWpSXmKPExsViPb2gRXfdudB Ig/crdC2+b5nM5MDocfjDFZYAxijWzLyk/IoE1oxNh76zFqxSrlj+expzA2OLXBcjJ4eEgJ/E tGsvWEFsIYFaiQfT9jB1MXIB2SsZJT4cvguVOM4o0XXREMRmE9CRONP8gB3EFhEIl1i7tpsNp IFZ4BmjxKefPxhBEsIC0RJrdu9iA7FZBFQlvrb8YwKxeQXiJVbunMwGsVlOYtuWPWD1nAK2Ek uuPGeHWGYj8WhXN1S9oMTJmU9YQGxmAQmJgy9eMEP0Kkm8XneABcLWlZj6bDkjhK0psW31Oaj 5ZhJHdv5nhbAFJXY+v8A2gVFkFpKxs5CMXcDItIpRvTi1qCy1SNdIL6koMz2jJDcxM0fX0MBM Lze1uDgxPTUnMalYLzk/dxMjMMwZgGAH47K/TocYJTmYlER5zy0KjRTiS8pPqcxILM6ILyrNS S0+xCjDwaEkwRt2FignWJSanlqRlpkDjDiYtAQHj5IIr8ASoDRvcUFibnFmOkTqFKMxx4bV67 8wcRyb8fMbkxBLXn5eqpQ470yQSQIgpRmleXCDYIngEqOslDAvI9BpQjwFqUW5mSWo8q8YxTk YlYR5eUCm8GTmlcDtewV0ChPQKcIzQkBOKUlESEk1MCoaz2Ot3nPgWLFmTn/eFtYY5+atutI3 9uZHVJeqRNaabRXeO+X42s0+bvKz6hwZIjetfvx3hmzFpB/NHDkuwgdapr7RD7Jd7BL1cfuiJ 7G2E26GubjdOlzu8H/RU+Fuw0tLw01lHq3/oOK1puq2SO/P+p22mv4/fZXKt0xLnf9oU992rn tNB5RYijMSDbWYi4oTASUmQcz/AgAA X-Env-Sender: douly.fnst@cn.fujitsu.com X-Msg-Ref: server-11.tower-27.messagelabs.com!1498795685!74337025!4 X-Originating-IP: [59.151.112.132] X-SpamReason: No, hits=0.0 required=7.0 tests= X-StarScan-Received: X-StarScan-Version: 9.4.19; banners=-,-,- X-VirusChecked: Checked Received: (qmail 64089 invoked from network); 30 Jun 2017 04:08:14 -0000 Received: from cn.fujitsu.com (HELO heian.cn.fujitsu.com) (59.151.112.132) by server-11.tower-27.messagelabs.com with SMTP; 30 Jun 2017 04:08:14 -0000 X-IronPort-AV: E=Sophos;i="5.22,518,1449504000"; d="scan'208";a="20680350" Received: from unknown (HELO cn.fujitsu.com) ([10.167.33.5]) by heian.cn.fujitsu.com with ESMTP; 30 Jun 2017 12:08:06 +0800 Received: from G08CNEXCHPEKD03.g08.fujitsu.local (unknown [10.167.33.85]) by cn.fujitsu.com (Postfix) with ESMTP id C01D146B53F6; Fri, 30 Jun 2017 12:08:05 +0800 (CST) Received: from localhost.localdomain.localdomain (10.167.226.106) by G08CNEXCHPEKD03.g08.fujitsu.local (10.167.33.89) with Microsoft SMTP Server (TLS) id 14.3.319.2; Fri, 30 Jun 2017 12:08:04 +0800 From: Dou Liyang To: , , Date: Fri, 30 Jun 2017 12:07:34 +0800 Message-ID: X-Mailer: git-send-email 2.5.5 In-Reply-To: References: MIME-Version: 1.0 X-Originating-IP: [10.167.226.106] X-yoursite-MailScanner-ID: C01D146B53F6.A4DBB X-yoursite-MailScanner: Found to be clean X-yoursite-MailScanner-From: douly.fnst@cn.fujitsu.com X-Mailman-Approved-At: Fri, 30 Jun 2017 09:18:16 +0000 Cc: Dou Liyang , bhe@redhat.com, peterz@infradead.org, mingo@kernel.org, ebiederm@xmission.com, hpa@zytor.com, izumi.taku@jp.fujitsu.com, boris.ostrovsky@oracle.com, tglx@linutronix.de Subject: [Xen-devel] [PATCH v5 06/12] x86/apic: Mark the apic_intr_mode extern for sanity check cleanup X-BeenThere: xen-devel@lists.xen.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" X-Virus-Scanned: ClamAV using ClamSMTP Calling native_smp_prepare_cpus() to prepare for SMP bootup, does some sanity checking, enables APIC mode and disables SMP feature. Now, APIC mode setup has been unified to apic_intr_mode_init(), some sanity checks are redundant and need to be cleanup. Mark the apic_intr_mode extern to refine the switch and remove the redundant sanity check. Signed-off-by: Dou Liyang --- arch/x86/include/asm/apic.h | 9 ++++++++ arch/x86/kernel/apic/apic.c | 11 +++------- arch/x86/kernel/smpboot.c | 50 ++++++++------------------------------------- 3 files changed, 21 insertions(+), 49 deletions(-) diff --git a/arch/x86/include/asm/apic.h b/arch/x86/include/asm/apic.h index c3bedbd..bfbf715 100644 --- a/arch/x86/include/asm/apic.h +++ b/arch/x86/include/asm/apic.h @@ -53,6 +53,15 @@ extern int local_apic_timer_c2_ok; extern int disable_apic; extern unsigned int lapic_timer_frequency; +extern enum apic_intr_mode_id apic_intr_mode; +enum apic_intr_mode_id { + APIC_PIC, + APIC_VIRTUAL_WIRE, + APIC_VIRTUAL_WIRE_NO_CONFIG, + APIC_SYMMETRIC_IO, + APIC_SYMMETRIC_IO_NO_ROUTING +}; + #ifdef CONFIG_SMP extern void __inquire_remote_apic(int apicid); #else /* CONFIG_SMP */ diff --git a/arch/x86/kernel/apic/apic.c b/arch/x86/kernel/apic/apic.c index bea8032..0601054 100644 --- a/arch/x86/kernel/apic/apic.c +++ b/arch/x86/kernel/apic/apic.c @@ -1157,13 +1157,7 @@ void __init sync_Arb_IDs(void) APIC_INT_LEVELTRIG | APIC_DM_INIT); } -enum apic_intr_mode { - APIC_PIC, - APIC_VIRTUAL_WIRE, - APIC_VIRTUAL_WIRE_NO_CONFIG, - APIC_SYMMETRIC_IO, - APIC_SYMMETRIC_IO_NO_ROUTING, -}; +enum apic_intr_mode_id apic_intr_mode; static int __init apic_intr_mode_select(int *upmode) { @@ -1291,7 +1285,8 @@ void __init apic_intr_mode_init(void) { int upmode = false; - switch (apic_intr_mode_select(&upmode)) { + apic_intr_mode = apic_intr_mode_select(&upmode); + switch (apic_intr_mode) { case APIC_PIC: apic_printk(APIC_VERBOSE, KERN_INFO "Keep in PIC mode(8259)\n"); diff --git a/arch/x86/kernel/smpboot.c b/arch/x86/kernel/smpboot.c index b9b2a43..2db61dcb 100644 --- a/arch/x86/kernel/smpboot.c +++ b/arch/x86/kernel/smpboot.c @@ -1193,7 +1193,7 @@ enum { /* * Various sanity checks. */ -static int __init smp_sanity_check(unsigned max_cpus) +static void __init smp_sanity_check(void) { preempt_disable(); @@ -1231,16 +1231,6 @@ static int __init smp_sanity_check(unsigned max_cpus) } /* - * If we couldn't find an SMP configuration at boot time, - * get out of here now! - */ - if (!smp_found_config && !acpi_lapic) { - preempt_enable(); - pr_notice("SMP motherboard not detected\n"); - return SMP_NO_CONFIG; - } - - /* * Should not be necessary because the MP table should list the boot * CPU too, but we do it for the sake of robustness anyway. */ @@ -1250,29 +1240,6 @@ static int __init smp_sanity_check(unsigned max_cpus) physid_set(hard_smp_processor_id(), phys_cpu_present_map); } preempt_enable(); - - /* - * If we couldn't find a local APIC, then get out of here now! - */ - if (APIC_INTEGRATED(boot_cpu_apic_version) && - !boot_cpu_has(X86_FEATURE_APIC)) { - if (!disable_apic) { - pr_err("BIOS bug, local APIC #%d not detected!...\n", - boot_cpu_physical_apicid); - pr_err("... forcing use of dummy APIC emulation (tell your hw vendor)\n"); - } - return SMP_NO_APIC; - } - - /* - * If SMP should be disabled, then really disable it! - */ - if (!max_cpus) { - pr_info("SMP mode deactivated\n"); - return SMP_FORCE_UP; - } - - return SMP_OK; } static void __init smp_cpu_index_default(void) @@ -1322,20 +1289,20 @@ void __init native_smp_prepare_cpus(unsigned int max_cpus) set_cpu_sibling_map(0); apic_intr_mode_init(); + smp_sanity_check(); - switch (smp_sanity_check(max_cpus)) { - case SMP_NO_CONFIG: - disable_smp(); - return; - case SMP_NO_APIC: + switch (apic_intr_mode) { + case APIC_PIC: + case APIC_VIRTUAL_WIRE_NO_CONFIG: disable_smp(); return; - case SMP_FORCE_UP: + case APIC_SYMMETRIC_IO_NO_ROUTING: disable_smp(); /* Setup local timer */ x86_init.timers.setup_percpu_clockev(); return; - case SMP_OK: + case APIC_VIRTUAL_WIRE: + case APIC_SYMMETRIC_IO: break; } @@ -1343,6 +1310,7 @@ void __init native_smp_prepare_cpus(unsigned int max_cpus) cpu0_logical_apicid = apic_read(APIC_LDR); else cpu0_logical_apicid = GET_APIC_LOGICAL_ID(apic_read(APIC_LDR)); + /* Setup local timer */ x86_init.timers.setup_percpu_clockev();