From patchwork Wed Sep 16 07:28:47 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Jan Beulich X-Patchwork-Id: 11779177 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 59467618 for ; Wed, 16 Sep 2020 07:29:54 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 368922076C for ; Wed, 16 Sep 2020 07:29:54 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 368922076C Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kIRs1-00026K-Vi; Wed, 16 Sep 2020 07:28:49 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kIRs1-00026F-Aa for xen-devel@lists.xenproject.org; Wed, 16 Sep 2020 07:28:49 +0000 X-Inumbo-ID: 5f6d04b5-5094-41f1-acc1-0b90b5aeedb4 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 5f6d04b5-5094-41f1-acc1-0b90b5aeedb4; Wed, 16 Sep 2020 07:28:48 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 24EB2AD65; Wed, 16 Sep 2020 07:29:03 +0000 (UTC) To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , George Dunlap , Ian Jackson , Julien Grall , Wei Liu , Stefano Stabellini , =?utf-8?q?Roger_Pau_Monn=C3=A9?= From: Jan Beulich Subject: [PATCH] mm: adjust get_page()'s types Message-ID: Date: Wed, 16 Sep 2020 09:28:47 +0200 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 Content-Language: en-US X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" The passed in domain doesn't get altered and hence can be const. While modifying its prototype anyway, also switch to bool. Signed-off-by: Jan Beulich Reviewed-by: Roger Pau Monné Reviewed-by: Julien Grall --- a/xen/arch/arm/mm.c +++ b/xen/arch/arm/mm.c @@ -1560,17 +1560,17 @@ void put_page(struct page_info *page) } } -int get_page(struct page_info *page, struct domain *domain) +bool get_page(struct page_info *page, const struct domain *domain) { - struct domain *owner = page_get_owner_and_reference(page); + const struct domain *owner = page_get_owner_and_reference(page); if ( likely(owner == domain) ) - return 1; + return true; if ( owner != NULL ) put_page(page); - return 0; + return false; } /* Common code requires get_page_type and put_page_type. --- a/xen/arch/x86/mm.c +++ b/xen/arch/x86/mm.c @@ -2510,12 +2510,12 @@ struct domain *page_get_owner_and_refere } -int get_page(struct page_info *page, struct domain *domain) +bool get_page(struct page_info *page, const struct domain *domain) { - struct domain *owner = page_get_owner_and_reference(page); + const struct domain *owner = page_get_owner_and_reference(page); if ( likely(owner == domain) ) - return 1; + return true; if ( !paging_mode_refcounts(domain) && !domain->is_dying ) gprintk(XENLOG_INFO, @@ -2526,7 +2526,7 @@ int get_page(struct page_info *page, str if ( owner ) put_page(page); - return 0; + return false; } /* --- a/xen/include/xen/mm.h +++ b/xen/include/xen/mm.h @@ -151,7 +151,7 @@ TYPE_SAFE(unsigned long, pfn); struct page_info; void put_page(struct page_info *); -int get_page(struct page_info *, struct domain *); +bool get_page(struct page_info *, const struct domain *); struct domain *__must_check page_get_owner_and_reference(struct page_info *); /* Boot-time allocator. Turns into generic allocator after bootstrap. */