From patchwork Tue Apr 19 09:39:06 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jan Beulich X-Patchwork-Id: 12817662 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4BDC8C433EF for ; Tue, 19 Apr 2022 09:39:27 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.307964.523394 (Exim 4.92) (envelope-from ) id 1ngkKD-0001V4-7Y; Tue, 19 Apr 2022 09:39:09 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 307964.523394; Tue, 19 Apr 2022 09:39:09 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ngkKD-0001Ux-4E; Tue, 19 Apr 2022 09:39:09 +0000 Received: by outflank-mailman (input) for mailman id 307964; Tue, 19 Apr 2022 09:39:08 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ngkKB-0001Ur-Ub for xen-devel@lists.xenproject.org; Tue, 19 Apr 2022 09:39:07 +0000 Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.109.102]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 8e5ecdd3-bfc4-11ec-a405-831a346695d4; Tue, 19 Apr 2022 11:39:06 +0200 (CEST) Received: from EUR03-DB5-obe.outbound.protection.outlook.com (mail-db5eur03lp2052.outbound.protection.outlook.com [104.47.10.52]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id de-mta-41-OTSCuYS-NNO6nJgkuH7isA-1; Tue, 19 Apr 2022 11:39:05 +0200 Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16) by AM0PR0402MB3651.eurprd04.prod.outlook.com (2603:10a6:208:5::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5164.20; Tue, 19 Apr 2022 09:39:03 +0000 Received: from DU2PR04MB8616.eurprd04.prod.outlook.com ([fe80::5cb0:5195:4203:7c2f]) by DU2PR04MB8616.eurprd04.prod.outlook.com ([fe80::5cb0:5195:4203:7c2f%7]) with mapi id 15.20.5186.013; Tue, 19 Apr 2022 09:39:03 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8e5ecdd3-bfc4-11ec-a405-831a346695d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1650361146; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=8IB4UsuGr6nOaXGYqGr/XjpHpdc46ZSgT5vo4vAcxZc=; b=IdN+qkH4arxPtJ9ChOlSCxwZt8UrFDqxkMq3MZZTrYKG66zX3XRFRgzu8LYuCB6zhizGsu YelOhKDjDhY/rqkKzKN1aZNia2dRkULwQx3QzXXiD+GlDG0iFf1Pu70fHsk4Vu1QLd9oUM UkyUpbT5TUYZH5BwwIecMlD2g19PFao= X-MC-Unique: OTSCuYS-NNO6nJgkuH7isA-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=StD1eZnyjb8BemLR6ngAYb6foIajHvliufCCoquI+mvgBgebV/imiRAQrUfJciXl8RNCr+QN/CkHcWAtsVEdTWITL3euEuFpkCAktEZB4BQgFSBXLuRXV+JcS7WFW3GejnESNnnJeZQzZEE+Eb6shopfw2QEAaMYTbl9Kf7Cb88RME4K6hYFc7L0W/00zt7534w/ZX+/2i/U+mr82WpAKr92cRdMaccqGK+yZ6iXEog2JO1v3Px931LVypPf/Idy+fappN2uuXIBPJnHmVxns9Ilj0Yqd0Gm0Bf4HUNooa3kWv5i/MBoCN9m4PKyDSW30HBPepPW9wFN8LXMyLEmJA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=8IB4UsuGr6nOaXGYqGr/XjpHpdc46ZSgT5vo4vAcxZc=; b=aACtUyXWtZJNOSYXjfSUjhhnTdxAzdh8mmA18jDnC2CZNdHDpcdjRqlHGcwlwHvpHBIP0DpObteM4uud3owc1+Uz4f9GmSGDE/hwba2ALsd0aEzB2gcqDYxG/LzpUEnQpjpVzMiZOf2RYwUdzRdap7Srsq8i3fTlKP+WsiRC0oJS4oPjbS6nFbJnKGYPYxuk5ROAbAzdV93YvrRHcA/b11rdZDcve14nIUGDYKETsc5ECya9zJKLMTBoU2QltKuBks66ksAPTZK5qr7ylV52kBHp09mwbtqvP4kr4OSf7NAHYHtYr7bve4cdzoOj9/9j6oLyybZxKaOghRy+hqR0Ww== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Tue, 19 Apr 2022 11:39:06 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.8.0 Content-Language: en-US To: "xen-devel@lists.xenproject.org" Cc: Paul Durrant From: Jan Beulich Subject: [PATCH] IOMMU: make domctl handler tolerate NULL domain X-ClientProxiedBy: AM6P194CA0038.EURP194.PROD.OUTLOOK.COM (2603:10a6:209:84::15) To DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 0f4e531e-6833-4ec8-aea1-08da21e870d4 X-MS-TrafficTypeDiagnostic: AM0PR0402MB3651:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: f8u/jEM1GHsM3cIXqDwtKtZz2fK/i7vkinR+JBadogJaQGoDsiwj0FQyruYpnmCZUQ51BxAFddi31mYMBNP6TywVOxfmTwo5XU4DvVthqRbADMA4DqosTmBSLwgkKZtOPj9a3BIFWBQ+rGyNtyP0h1HnXKU8QtWlKzWPTK+/MbOj7ktNWOzjWm1jJdx+JX5PRRdrpFGR09OeUAtO1caBsFL+mFjmOGVi161761uXtekK52IaAp77GQaw33RenDvC9iOdpjrqlOqilPjiF93YFpzEQltgMexU+IDqPkpR5Jrtnh0qyFxBY5hIRySxnFj3Fv6tt8Ll5bjJHBeKffb+3UvUgIanlQ48xQYwpZUNbH8xnexaJZ2eLgnAfbfyhT9yMdR6eqm1Aj8Xs47KaQfKIRgxKtKSu/I7hu4sx9AKubcpcx+R8i3l2/d3LoBd1aB7IbvPyOp+PuSqtAVPBR0Y6A0gKIBekHLzJYedfLjp0GVa+jBMJMyHGxcnON40HkU79HC5R1yqYC7cyebTdwdOcOlcMP7l6VJ2QgYUFmVcZM7h7fWBjYwzFOYDV/sBJnZ7SJ9ffhCvSRaSqV34BQt+C9ZCo3v9aV8lUNSboeT1QBxPFUdR9PdSHN61vE7Q6GyLDi8tmT/T89giNsMBfQU5Ib47UUo15WND/QgsdvYGzLz01fUIxwZZCLI7/0Bfnd0hpc8Mph4VSqzSdM1F5nrk5SWFGesZGKI6LVFpTZ2zeAo= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(316002)(66476007)(66946007)(6512007)(38100700002)(2906002)(6506007)(508600001)(6486002)(26005)(36756003)(8676002)(66556008)(6916009)(186003)(4326008)(5660300002)(4744005)(86362001)(8936002)(2616005)(31696002)(31686004)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?UeoD25+akuP19p2Mvjk1DjRrNHmP?= =?utf-8?q?dJbjJLWx2tNX5rBjh8xDfdp1hUx85bq9nZVKUb+s7scqhkyi2/7Tm/a87+dHOLjZj?= =?utf-8?q?y+mkkhjxJmOHW++6XEy8KncQHojqu/VPqk74LZ90EFFXRw6/04n6uUcLIDTwV3tMu?= =?utf-8?q?klXoKTHfYO9o5aFn64LYf9P/KqlvuiCC68zATCrs4c+x0MxNto/c/KBQsU1bpqV1T?= =?utf-8?q?PteQGUuClAv0shjUNgQ302HagGz6aiM0rfrgdjDoEF66wAnIXRGMH0q3yBGLVbuMg?= =?utf-8?q?H6n0ysBTnM8wCd92UxLlYoK9AyNHD2+icT+/6oyYfwy9vCyfXzM2Cy81KI1W2qjDG?= =?utf-8?q?jSmwN9qQFg1nFccyyU1b780Jfw7B/VCjR0yF28yM0TehB0ROk82fJEkxcVWY6ZPjB?= =?utf-8?q?mnrSAbPppwi4QCuHIG9dzSxRW9usPAHeOc7o01akgYd6TvznfT0UhGtzLAxD3z4WA?= =?utf-8?q?lRsfdTzHNlVuxuCCzOJeFGi6vrbRH08IFtK8KtosYSYZu69X8oEJWtgxnicpNHHvX?= =?utf-8?q?tgIw6tCglUTiVh1ulHtBcjknEx++JBFTsOuOXfcDjP7RATfE9pNjrHzsDMu9RycRn?= =?utf-8?q?DuoEOcYWC+3JR62f7hcXXvcg3EKY0DT8mC449Tk05a/FQfrVeSdLhGLWQFAnFmeAl?= =?utf-8?q?xz6fE3EepJJZ8nuaa5g8+6PuDbFFKrntavc3GECL5t5k1thAX+7ULF6k5BqiO3Zgp?= =?utf-8?q?cIGmOBHFRogPsnLHDAb+TiOnRatKNKYh6+bIFR4rDO51zr+X0HncmKaqdLVlyeiuW?= =?utf-8?q?kusK6/MH5ym0+Mj8NXA5EgnJKoGhtHdfCzsJrrM6SDXV4UH+248PIoWXd6MSd/q4e?= =?utf-8?q?+1pTkaPldn+sPRUaajsejIAnELU2cFBWPZhLwUUTuwk/uOdHYCOMo6npq8YhfvXMe?= =?utf-8?q?H1+YRohjUAiwnJSRy8dIvGEQlGygG3v1srakh9FjzjDsK4O/+/Vpo6ZFaQ8TG6imS?= =?utf-8?q?mTBGNff4yePh87LDpudUaHQRyEoZJnKOG6xHjiCOKHF61/mIQpVKstpoOPmRdxfLB?= =?utf-8?q?XbmL12Y89G4B766FvR6jbCEyMgs2RHJEbwJR++stDNbbrwHL5lSMTBLVKt9yIv2BG?= =?utf-8?q?Cdndm8VF9R1LmBu4m8ojZN9y+MVRtkICVkoof6uOJuHBD+qfaJntFc0RlC018h3Jk?= =?utf-8?q?q+POjEx6ZqroRNAvj0azxGdng5/sKv96PXIRRgrgumBldVlT24UNrLRHs+uPmiZvl?= =?utf-8?q?I0eb7x2tRJXaYakkGH7tcutuyz2Hvg35aMN+O0Njus9V6+epAeif6enS7y2Kc3ZvT?= =?utf-8?q?CsMC56adLEx/eUYOCOpxUK1SipdoyTHuYI5tgqGHiR9opDB99N8wN9NGSTzxyyAJU?= =?utf-8?q?vXjwvw6aWde8lKbwg455RKMzFQt6iFQ3JHNNzqkru9utVLR5tD9z4FFggpFJegACr?= =?utf-8?q?e/IIdbAi4sjk90Icns/PyEluDVDZxEnpeQzoET1JHbF+PdqdF+zpIRqPVbAWbEkUo?= =?utf-8?q?z+F5zjtCtOm53H7q1CXUyy+pUF1TSUxUfi1xCjgcdfOnHshiqMqlUBuTVuiOct3hI?= =?utf-8?q?aKm5w+VJcXfxDT0PAa/tQYEGTHED+eRqgIClGSwYPR3cbN7nH6zboHgcPN0mCxS+w?= =?utf-8?q?sCJ3e6oJUJ6mwfTt9Y83hJb1svq74HXqRrKk22s5kzQS7iyFGK7Ac4488fwIOB5V6?= =?utf-8?q?DjP4KzxcucaT+BTlBNSxNlJeS/OYA3og=3D=3D?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0f4e531e-6833-4ec8-aea1-08da21e870d4 X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Apr 2022 09:39:03.7181 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: SevL1HqaIJCJjpBwBNUpV9UG5HTxPe42h7UGruPtd6gnC7f/dxCO3UPzd215FsOeGNcAN5KIgHd9zRQisjeGAQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR0402MB3651 Besides the reporter's issue of hitting a NULL deref when !CONFIG_GDBSX, XEN_DOMCTL_test_assign_device can legitimately end up having NULL passed here, when the domctl was passed DOMID_INVALID. Fixes: 71e617a6b8f6 ("use is_iommu_enabled() where appropriate...") Reported-by: Cheyenne Wills Signed-off-by: Jan Beulich Reviewed-by: Paul Durrant Reviewed-by: Juergen Gross --- a/xen/drivers/passthrough/iommu.c +++ b/xen/drivers/passthrough/iommu.c @@ -558,7 +558,7 @@ int iommu_do_domctl( { int ret = -ENODEV; - if ( !is_iommu_enabled(d) ) + if ( !(d ? is_iommu_enabled(d) : iommu_enabled) ) return -EOPNOTSUPP; #ifdef CONFIG_HAS_PCI