From patchwork Mon Dec 6 13:31:13 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jan Beulich X-Patchwork-Id: 12658421 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EBD41C433EF for ; Mon, 6 Dec 2021 13:31:32 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.238926.414092 (Exim 4.92) (envelope-from ) id 1muE5P-0004B2-VQ; Mon, 06 Dec 2021 13:31:19 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 238926.414092; Mon, 06 Dec 2021 13:31:19 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1muE5P-0004Au-Ro; Mon, 06 Dec 2021 13:31:19 +0000 Received: by outflank-mailman (input) for mailman id 238926; Mon, 06 Dec 2021 13:31:18 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1muE5O-0002vN-Cd for xen-devel@lists.xenproject.org; Mon, 06 Dec 2021 13:31:18 +0000 Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.111.102]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id ca8b90c9-5698-11ec-8a4d-196798b21f7b; Mon, 06 Dec 2021 14:31:17 +0100 (CET) Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-vi1eur04lp2056.outbound.protection.outlook.com [104.47.14.56]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id de-mta-10-1203vd6lPwWmIyTnIi7LrQ-1; Mon, 06 Dec 2021 14:31:16 +0100 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) by VI1PR0402MB2829.eurprd04.prod.outlook.com (2603:10a6:800:bb::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4734.23; Mon, 6 Dec 2021 13:31:15 +0000 Received: from VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::5951:a489:1cf0:19fe]) by VI1PR04MB5600.eurprd04.prod.outlook.com ([fe80::5951:a489:1cf0:19fe%6]) with mapi id 15.20.4755.021; Mon, 6 Dec 2021 13:31:15 +0000 Received: from [10.156.60.236] (37.24.206.209) by AS9PR04CA0059.eurprd04.prod.outlook.com (2603:10a6:20b:46a::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4755.11 via Frontend Transport; Mon, 6 Dec 2021 13:31:14 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ca8b90c9-5698-11ec-8a4d-196798b21f7b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1638797477; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=NCSQ+AXXRTjdtJyeP2akK62GyR4QHv+YZ2pLR/0+MYY=; b=N+jIBQTod0rSqSca6OhF0Y5AAPCqiCSEBvM9INGhPUR53QF8VsO/f3KwwuLv/IRQXqPTAK 7Qm50/OLOwkeUuKGo8OAT9/tDB3LrMAdOhL2WjWExO2LvucAOz+4TXtS4vgJyOTc3aN2B0 6ZDCCnELuSZA/eNsUTlR+5JJFwNTfNA= X-MC-Unique: 1203vd6lPwWmIyTnIi7LrQ-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=YXD/pMNJm4DdDLSYKHPhETw1V5AUWHQkHOyd1x7mmvyAbmqBaKt/bbBDF2Sfx1pwgW5PlklwXnbR7Hefaf0XZjeOceUmCxTPfImxs89dLm/WRDJNtLYiGAO5616Llkl9WgDW+T7Gal/C+QR8UACAjlhsdeBKP+ur+Btr+jtFo2wyCov5SPoG0K+ODyVzewGVqQYCNsp0LkUeL5ttLc9N+AVbQSVRSfyWnxCL4CXYEP9YVsEs0+f8Xeef5v1MZgq5vVBx39kFMaLJkAtXZz8HYmYvc/FZxYBQWqj7PgDTM6veHJgLgNe4K/aHa1znbKmuDLjtzpCHmr95pDRVjkhxCw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=NCSQ+AXXRTjdtJyeP2akK62GyR4QHv+YZ2pLR/0+MYY=; b=g48RbDNF3lnvgZuKyy30myXG1eODG+qfVC2IkR38+ApkVofWlP4KNmRzVZCuU0gSgV3iWpsUx/i6jmyYvRpJciBvmhxyCgNDnAdXUgUyag0hTARMGbsLreHIx01YPHkuFJSQrMSzhkQL0xb35FGRMsR+p8VKhhStmaVSZNDTGVpvi2h6SeK3ISIhyMOB0rS6SSBPZXSAw/20S6xjpT39EdTKBDbDtFos84pk764Y+22hMh3TNAoqad/fxcZFR/AgoHlzuClBWuXlGNSppj34DnvwbDKEL6jQsf8GKcj0CGLCv4bQ4njYopnbaaUCRTbgN5fg41q75hhDuHE5qGiLug== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Mon, 6 Dec 2021 14:31:13 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.3.2 Subject: [PATCH v2 2/7] xz: fix XZ_DYNALLOC to avoid useless memory reallocations Content-Language: en-US From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , George Dunlap , Ian Jackson , Julien Grall , Stefano Stabellini , Wei Liu References: In-Reply-To: X-ClientProxiedBy: AS9PR04CA0059.eurprd04.prod.outlook.com (2603:10a6:20b:46a::9) To VI1PR04MB5600.eurprd04.prod.outlook.com (2603:10a6:803:e7::16) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: ad052fe7-2175-4be0-37cb-08d9b8bcad4c X-MS-TrafficTypeDiagnostic: VI1PR0402MB2829:EE_ X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:56; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: G83S7QF4hvyypzbKflfnJf+cTPkeQng7ZZXzeHHUtmjk3U5z/bI46C2wR7Gmr1BjH/GBpyD3oCG2I2Dqwz+kMnAyvzDkO+K4DiRIL1x6g3xiokR5dc8eTGSzwp7XdnfjnJlXxBv3hy9XissWzOjtxt5JqIkwVKllQiXlNBRS+sNxHqUlnWJlDqRU7odeCXtCeI96fA90+pJB/nBjJgP0R/ITKStUaHQiUlXwof1P2NbgRdp4uQ9+idMQmVJJfHjZRFo4hxWns5qU6MIIVCbTrj1mkd6gT8ntZouoOrMZRg6JneLiX85pkEl2bjFJIaGQ84r1FE2tCac5Igx5cGk6QEbkGGOwu+H+/t2QY1D43Fs3oXyXfOCURnFwCYaiZ+fGw2yaxPs766hrEVH/rDRbk2I5+nz8WDj8TNnmJqn40axia/Mh3GQ4x+Twa82uW43oTQhYyR08M19LWAg1xEWdieSL+itYc9+SlKmh1EiYP0hf/xJ1oX5AKCNPFgGb10o8d6pCxBctIT+GKNMezUG90Qe25eLFphgdGQPPxe3YBJJjFoZldV3MXaBwJncHQWpuDo5uJdULqQ2q9yLslC45zKR4ahGiPe/pf8JLQMOLw2j+ZHvvTbOAE3vrdJH5tXyoveXGgyEDSV1keI+Mh3qUoZTSL1/GgI0s0/dFDGdsnqd20aydg/JduM6miiDVg3nf1eYiTyrlkdxN73+f1JzUg9dKWySWFarZmbJgCXTOLNUfyMdeN2TlB7slMrMDjOwlgVVo5vC8fYsjsqf3F04sARfM9JYiASjoe15TLyQsx75hQaJeEl6elZ0G/GDuqVVQ X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5600.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(38100700002)(4744005)(956004)(2616005)(8936002)(186003)(31686004)(8676002)(36756003)(6486002)(66476007)(316002)(6916009)(5660300002)(86362001)(31696002)(2906002)(26005)(4326008)(966005)(54906003)(66946007)(16576012)(508600001)(66556008)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?7BXFafvaXYJ9qOxnT25aqY+zGVNb?= =?utf-8?q?eQOFLJHn9aDxKYTaON1WNtEYVkVxhCr1v/WEwdDxx8JuOeERK/mgbNoO/ZJavN3xO?= =?utf-8?q?V1XO/42BOQ49fkGN9OPZFJ4favhVFTV3J77xY235ebRXsYgZkvzarVdfVXOeC8yPa?= =?utf-8?q?4Rt9+HgeuE2YvDvQexc3+K4s0Wy5fbkr+UTq7VQmRIJ5mKdkK40wJJo7Rlzwk1hgB?= =?utf-8?q?PvwkDxu/SAL3w+mHobGLmc5dJl/9RtWCkBbsy2nprcrQtAtPwvqNX1kDKHQhXyvG4?= =?utf-8?q?OD/6RyXjpIRXNqptYrqI10tkbPKidnRVVwwCw9xXvga3rL3d6opg54ETD/Vrqz7ny?= =?utf-8?q?kQNZyt0IplD8M9pqLsagUj4Tz4Sc79mVWBtCyhbyWutz1kyHWPXgZCIGpD5mjSdrE?= =?utf-8?q?RLzkoPwbgMNsnc6mhp6M14s2FqgdjKnMs9T75kAG0expJWzZgkprKQUuvGCZl24oB?= =?utf-8?q?5fWkC4qyGyBaRYs/a1s63y5zMOHAlkXb2HMSBvXcKCfpdBG4WZY7llHCZSzXpAGRq?= =?utf-8?q?qi1DmnxDQesa1EMOSwspDIez/HkCWBkUt9Gn+XNZsG7Ui9IcPkokGZxC0hMXNze8w?= =?utf-8?q?sME7oNJLOa2jObDdSSQqt3vUeb4vIXrgJzEg8K+yKbRBU2hx/BxT0NFb6KpmKVlA6?= =?utf-8?q?kGEoDwxxpABYoSkcjTM7vcy5X21QlxoMqT8pW1/sM4GtvVkavprtYPtmcLq8DuBD7?= =?utf-8?q?DKTTwNH7cJIkginerxsC7Agm0cYN5XVkcjSijF+lyv6O6bC5FnlQVQvqD/2lYmWtS?= =?utf-8?q?Iu0Qui9a86AwZwI3vO5su9pLsqUaij0uks2bWJejYS3Iwfkg+tx7q+A6f9xKBTaS9?= =?utf-8?q?r35TxF3iq8iwxt1ikCmsl1WNg56g3QikYdDvTvkcfIKD8lAYQEkrwsgccbWkFfcPx?= =?utf-8?q?YJWPVHirjtQKl6BmWAd32r2u5yxzVBOQxzm6nAafzYdMG4p8+L5XZlJ8VPT5MH47Y?= =?utf-8?q?wqPBzgfSRmbzZcLelmZ7jZA6WDFrzriOheY29iP2oxFGcqO+ctgCgbjmJZvENUwJC?= =?utf-8?q?QVFmBQPCDPL/zVPO+ew/h8yCrt64TpCcq6QXVRn7xLU8INNeczIITRovD/+PZpfSv?= =?utf-8?q?SYsc21pPCqld6Ns1MVd9WydImFSbFaKEbMbYuUeCGy0PF1rB03fUp1ikWsnesFTLo?= =?utf-8?q?vWwHPdbAlCVt1N0N4h65YJfquQW2WR+niN4K/K0XkkHPRVp3qVoaIYPtsxRZfDgFK?= =?utf-8?q?nJ8kTN1svFVXHG1j7Z+caFPxE68AED21e0vGTKy2GiQvHXNxL3QBiAEML/lH9DuPX?= =?utf-8?q?6ITj8R1OfcL6kEObjrgq61vHM2y+UmxQMXaXV4/FjB+UzH23cfixt2aTssGm4cThD?= =?utf-8?q?8zRvYPerzqibNQij+uRsJaadnF74850SB/pXVWhnF3iBsdXCXtH6KAA2heI+1234U?= =?utf-8?q?NaQ8m6ua92RwFxJdKm44ss4lcoPRscgvNs5oN8EN3nOGYbbpCdUPKbDRX/pcoKhJM?= =?utf-8?q?yDlhhlOSvSCgPUNAkxDDJmsAPRC/8/K5Xw8NAoU1oDCPOarleUNZjaPsGJJT4WbNy?= =?utf-8?q?T5V5xkriltdc4AeJouHdaJuT4z9RQFcNrWHcU8ay71cJTPiYxXOyf14=3D?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: ad052fe7-2175-4be0-37cb-08d9b8bcad4c X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5600.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Dec 2021 13:31:15.1770 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ZwuFnTOYtfaJ8ww7xrKzlOSXNUvNI2Tmy7z1kt78Vqx3PVsXqcclc5vpkbD8uSNzJLWt/g2jx80yGONhGHbP7Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0402MB2829 From: Lasse Collin s->dict.allocated was initialized to 0 but never set after a successful allocation, thus the code always thought that the dictionary buffer has to be reallocated. Link: http://lkml.kernel.org/r/20191104185107.3b6330df@tukaani.org Reported-by: Yu Sun Signed-off-by: Lasse Collin Acked-by: Daniel Walker [Linux commit: 8e20ba2e53fc6198cbfbcc700e9f884157052a8d] Signed-off-by: Jan Beulich Reviewed-by: Luca Fancellu --- a/xen/common/xz/dec_lzma2.c +++ b/xen/common/xz/dec_lzma2.c @@ -1146,6 +1146,7 @@ XZ_EXTERN enum xz_ret __init xz_dec_lzma if (DEC_IS_DYNALLOC(s->dict.mode)) { if (s->dict.allocated < s->dict.size) { + s->dict.allocated = s->dict.size; large_free(s->dict.buf); s->dict.buf = large_malloc(s->dict.size); if (s->dict.buf == NULL) {